From: Jon Hunter <jonathanh@nvidia.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Marek Behún" <marek.behun@nic.cz>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v2] PCI: Assign PCI domain by ida_alloc()
Date: Tue, 28 Mar 2023 18:02:48 +0100 [thread overview]
Message-ID: <9baff4c3-31ff-c19c-01fb-f438797da9ea@nvidia.com> (raw)
In-Reply-To: <CAL_JsqJ+3j60WK0HSr0rFQYwPkMbs=ZW=mifd7ggeNQA8+iuaA@mail.gmail.com>
On 28/03/2023 14:31, Rob Herring wrote:
...
> Does this fix it?:
>
> diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
> index 0145aef1b930..22d39e12b236 100644
> --- a/drivers/pci/remove.c
> +++ b/drivers/pci/remove.c
> @@ -157,8 +157,6 @@ void pci_remove_root_bus(struct pci_bus *bus)
> list_for_each_entry_safe(child, tmp,
> &bus->devices, bus_list)
> pci_remove_bus_device(child);
> - pci_remove_bus(bus);
> - host_bridge->bus = NULL;
>
> #ifdef CONFIG_PCI_DOMAINS_GENERIC
> /* Release domain_nr if it was dynamically allocated */
> @@ -166,6 +164,9 @@ void pci_remove_root_bus(struct pci_bus *bus)
> pci_bus_release_domain_nr(bus, host_bridge->dev.parent);
> #endif
>
> + pci_remove_bus(bus);
> + host_bridge->bus = NULL;
> +
> /* remove the host bridge */
> device_del(&host_bridge->dev);
> }
Yes that does fix it! I had been meaning to get back to this this week
to figure out what is going on and so thanks for figuring this out.
If you plan to send a fix for this, please add my ...
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers!
Jon
--
nvpublic
prev parent reply other threads:[~2023-03-28 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 20:47 [PATCH] PCI: Assign PCI domain by ida_alloc() Pali Rohár
2022-07-14 18:41 ` [PATCH v2] " Pali Rohár
2022-08-18 13:50 ` Pali Rohár
2022-08-18 14:59 ` Andrew Lunn
2022-08-18 16:37 ` Pali Rohár
2022-08-18 16:52 ` Bjorn Helgaas
2022-10-09 11:29 ` Pali Rohár
2022-10-09 13:39 ` Christophe JAILLET
2022-11-01 23:06 ` Pali Rohár
2022-10-09 13:36 ` Christophe JAILLET
2022-10-09 14:02 ` Pali Rohár
2022-11-07 23:05 ` Bjorn Helgaas
2023-03-20 20:26 ` Jon Hunter
2023-03-20 20:59 ` Pali Rohár
2023-03-21 18:44 ` Jon Hunter
2023-03-22 14:36 ` Jon Hunter
2023-03-22 17:21 ` Pali Rohár
2023-03-22 20:13 ` Jon Hunter
2023-03-28 13:31 ` Rob Herring
2023-03-28 17:02 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9baff4c3-31ff-c19c-01fb-f438797da9ea@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).