From: Zhou Wang <wangzhou1@hisilicon.com>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-crypto@vger.kernel.org>
Cc: <linux-pci@vger.kernel.org>, <alex.williamson@redhat.com>,
<jgg@nvidia.com>, <cohuck@redhat.com>, <mgurtovoy@nvidia.com>,
<yishaih@nvidia.com>, <linuxarm@huawei.com>,
<liulongfang@huawei.com>, <prime.zeng@hisilicon.com>,
<jonathan.cameron@huawei.com>
Subject: Re: [PATCH v8 7/9] crypto: hisilicon/qm: Set the VF QM state register
Date: Fri, 4 Mar 2022 17:43:03 +0800 [thread overview]
Message-ID: <9ea8eabb-0581-dbc6-d7af-acd019173f7e@hisilicon.com> (raw)
In-Reply-To: <20220303230131.2103-8-shameerali.kolothum.thodi@huawei.com>
> From: Longfang Liu <liulongfang@huawei.com>>
> We use VF QM state register to record the status of the QM configuration
> state. This will be used in the ACC migration driver to determine whether
> we can safely save and restore the QM data.
>
> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Acked-by: Zhou Wang <wangzhou1@hisilicon.com>
Best,
Zhou
> ---
> drivers/crypto/hisilicon/qm.c | 8 ++++++++
> include/linux/hisi_acc_qm.h | 6 ++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
> index c88e013371af..6a8776db38b5 100644
> --- a/drivers/crypto/hisilicon/qm.c
> +++ b/drivers/crypto/hisilicon/qm.c
> @@ -3492,6 +3492,12 @@ static void hisi_qm_pci_uninit(struct hisi_qm *qm)
> pci_disable_device(pdev);
> }
>
> +static void hisi_qm_set_state(struct hisi_qm *qm, u8 state)
> +{
> + if (qm->ver > QM_HW_V2 && qm->fun_type == QM_HW_VF)
> + writel(state, qm->io_base + QM_VF_STATE);
> +}
> +
> /**
> * hisi_qm_uninit() - Uninitialize qm.
> * @qm: The qm needed uninit.
> @@ -3520,6 +3526,7 @@ void hisi_qm_uninit(struct hisi_qm *qm)
> dma_free_coherent(dev, qm->qdma.size,
> qm->qdma.va, qm->qdma.dma);
> }
> + hisi_qm_set_state(qm, QM_NOT_READY);
> up_write(&qm->qps_lock);
>
> qm_irq_unregister(qm);
> @@ -3745,6 +3752,7 @@ int hisi_qm_start(struct hisi_qm *qm)
> if (!ret)
> atomic_set(&qm->status.flags, QM_START);
>
> + hisi_qm_set_state(qm, QM_READY);
> err_unlock:
> up_write(&qm->qps_lock);
> return ret;
> diff --git a/include/linux/hisi_acc_qm.h b/include/linux/hisi_acc_qm.h
> index 00f2a4db8723..177f7b7cd414 100644
> --- a/include/linux/hisi_acc_qm.h
> +++ b/include/linux/hisi_acc_qm.h
> @@ -67,6 +67,7 @@
> #define QM_DB_RAND_SHIFT_V2 16
> #define QM_DB_INDEX_SHIFT_V2 32
> #define QM_DB_PRIORITY_SHIFT_V2 48
> +#define QM_VF_STATE 0x60
>
> /* qm cache */
> #define QM_CACHE_CTL 0x100050
> @@ -162,6 +163,11 @@ enum qm_debug_file {
> DEBUG_FILE_NUM,
> };
>
> +enum qm_vf_state {
> + QM_READY = 0,
> + QM_NOT_READY,
> +};
> +
> struct qm_dfx {
> atomic64_t err_irq_cnt;
> atomic64_t aeq_irq_cnt;
>
next prev parent reply other threads:[~2022-03-04 9:43 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 23:01 [PATCH v8 0/9] vfio/hisilicon: add ACC live migration driver Shameer Kolothum
2022-03-03 23:01 ` [PATCH v8 1/9] crypto: hisilicon/qm: Move the QM header to include/linux Shameer Kolothum
2022-03-04 9:03 ` Zhou Wang
2022-03-04 11:33 ` Shameerali Kolothum Thodi
2022-03-08 1:07 ` liulongfang
2022-03-08 10:27 ` yekai(A)
2022-03-03 23:01 ` [PATCH v8 2/9] crypto: hisilicon/qm: Move few definitions to common header Shameer Kolothum
2022-03-04 9:06 ` Zhou Wang
2022-03-03 23:01 ` [PATCH v8 3/9] hisi_acc_qm: Move VF PCI device IDs " Shameer Kolothum
2022-03-04 9:34 ` Zhou Wang
2022-03-04 11:35 ` Shameerali Kolothum Thodi
2022-03-07 17:53 ` Alex Williamson
2022-03-10 13:55 ` Shameerali Kolothum Thodi
2022-03-08 1:08 ` liulongfang
2022-03-08 10:28 ` yekai(A)
2022-03-03 23:01 ` [PATCH v8 4/9] hisi_acc_vfio_pci: add new vfio_pci driver for HiSilicon ACC devices Shameer Kolothum
2022-03-03 23:01 ` [PATCH v8 5/9] hisi_acc_vfio_pci: Restrict access to VF dev BAR2 migration region Shameer Kolothum
2022-03-08 1:11 ` liulongfang
2022-03-08 6:23 ` Tian, Kevin
2022-03-08 8:33 ` Shameerali Kolothum Thodi
2022-03-08 10:09 ` Tian, Kevin
2022-03-08 11:02 ` Shameerali Kolothum Thodi
2022-03-03 23:01 ` [PATCH v8 6/9] hisi_acc_vfio_pci: Add helper to retrieve the struct pci_driver Shameer Kolothum
2022-03-04 9:40 ` Zhou Wang
2022-03-04 11:31 ` Shameerali Kolothum Thodi
2022-03-08 10:28 ` yekai(A)
2022-03-08 12:02 ` liulongfang
2022-03-03 23:01 ` [PATCH v8 7/9] crypto: hisilicon/qm: Set the VF QM state register Shameer Kolothum
2022-03-04 9:43 ` Zhou Wang [this message]
2022-03-08 6:31 ` Tian, Kevin
2022-03-08 8:46 ` Shameerali Kolothum Thodi
2022-03-08 10:10 ` Tian, Kevin
2022-03-03 23:01 ` [PATCH v8 8/9] hisi_acc_vfio_pci: Add support for VFIO live migration Shameer Kolothum
2022-03-04 8:48 ` Shameerali Kolothum Thodi
2022-03-04 19:44 ` Alex Williamson
2022-03-04 20:36 ` Shameerali Kolothum Thodi
2022-03-04 20:40 ` Alex Williamson
2022-03-04 20:57 ` Jason Gunthorpe
2022-03-07 19:05 ` Alex Williamson
2022-03-07 19:29 ` Shameerali Kolothum Thodi
2022-03-07 19:52 ` Alex Williamson
2022-03-08 8:11 ` Tian, Kevin
2022-03-08 19:33 ` Alex Williamson
2022-03-09 10:11 ` Tian, Kevin
2022-03-10 20:49 ` Alex Williamson
2022-03-11 8:52 ` Cornelia Huck
2022-03-11 13:21 ` Shameerali Kolothum Thodi
2022-03-14 3:40 ` Tian, Kevin
2022-03-14 15:03 ` Jason Gunthorpe
2022-03-08 9:46 ` liulongfang
2022-03-08 7:41 ` Tian, Kevin
2022-03-08 8:52 ` Shameerali Kolothum Thodi
2022-03-08 10:17 ` Tian, Kevin
2022-03-03 23:01 ` [PATCH v8 9/9] hisi_acc_vfio_pci: Use its own PCI reset_done error handler Shameer Kolothum
2022-03-04 20:54 ` Jason Gunthorpe
2022-03-08 1:14 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea8eabb-0581-dbc6-d7af-acd019173f7e@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mgurtovoy@nvidia.com \
--cc=prime.zeng@hisilicon.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).