From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F9BC433EF for ; Wed, 20 Apr 2022 07:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359776AbiDTHcc convert rfc822-to-8bit (ORCPT ); Wed, 20 Apr 2022 03:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359816AbiDTHc2 (ORCPT ); Wed, 20 Apr 2022 03:32:28 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 609033B2B3 for ; Wed, 20 Apr 2022 00:29:43 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nh4mB-0007Lb-2j; Wed, 20 Apr 2022 09:29:23 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nh4m9-0047V2-BD; Wed, 20 Apr 2022 09:29:19 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1nh4m6-0002mx-Pi; Wed, 20 Apr 2022 09:29:18 +0200 Message-ID: <9ee4e73d0b6c9d1cdf6c9ebe94474e7200240701.camel@pengutronix.de> Subject: Re: [RFC/RFT 3/6] phy: rockchip: Support pcie v3 From: Philipp Zabel To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Lorenzo Pieralisi , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Johan Jonker , Peter Geis , Michael Riesch , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Date: Wed, 20 Apr 2022 09:29:18 +0200 In-Reply-To: <20220416135458.104048-4-linux@fw-web.de> References: <20220416135458.104048-1-linux@fw-web.de> <20220416135458.104048-4-linux@fw-web.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pci@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sa, 2022-04-16 at 15:54 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > RK3568 supports PCIe v3 using not Combphy like PCIe v2 on rk3566. > It use a dedicated pcie-phy. Add support for this. > > Signed-off-by: Frank Wunderlich > --- > driver was taken from linux 5.10 based on in > https://github.com/JeffyCN/mirrors > which now has disappeared > --- [...] > + priv->p30phy = devm_reset_control_get(dev, "phy"); Please use devm_reset_control_get_exclusive() instead. It is functionally identical but makes clear that this driver requires exclusive control over the reset line. regards Philipp