From: Logan Gunthorpe <logang@deltatee.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Wesley Sheng <wesley.sheng@microchip.com>
Cc: kurt.schwemmer@microsemi.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, wesleyshenggit@sina.com
Subject: Re: [PATCH 5/5] switchtec: MRPC DMA mode implementation
Date: Thu, 13 Dec 2018 09:46:13 -0700 [thread overview]
Message-ID: <9f81d636-95da-af77-0a7c-0ad439c0a866@deltatee.com> (raw)
In-Reply-To: <20181213151756.GD4701@google.com>
On 2018-12-13 8:17 a.m., Bjorn Helgaas wrote:
>> static void init_pff(struct switchtec_dev *stdev)
>> @@ -1294,6 +1367,19 @@ static int switchtec_init_pci(struct switchtec_dev *stdev,
>>
>> pci_set_drvdata(pdev, stdev);
>>
>> + if (!use_dma_mrpc)
>> + return 0;
>> +
>> + if (!(ioread32(&stdev->mmio_mrpc->dma_ver) ? true : false))
>> + return 0;
>
> This is ... harder to decode than necessary. It's obvious that the
> intent is to return if the adapter firmware doesn't support DMA, but I
> lost interest before I could verify that it works as intended.
Oh, ick, yes. I must have missed that in my review.
@Wesley, that would definitely be something worth cleaning up. That
ternary operator doesn't make any sense.
Thanks, Bjorn, for the review and picking up the series.
Logan
next prev parent reply other threads:[~2018-12-13 16:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 9:12 [PATCH 0/5] Switchtec MRPC DMA mode support Wesley Sheng
2018-12-10 9:12 ` [PATCH 1/5] switchtec: Remove immediate status check after submit a MRPC command Wesley Sheng
2018-12-10 9:12 ` [PATCH 2/5] switchtec: Set DMA coherent mask in Switchtec driver Wesley Sheng
2018-12-10 9:12 ` [PATCH 3/5] switchtec: A temporary variable should be used for the flags of switchtec_ioctl_event_ctl Wesley Sheng
2018-12-12 22:43 ` Bjorn Helgaas
2018-12-12 22:52 ` Logan Gunthorpe
2018-12-10 9:12 ` [PATCH 4/5] switchtec: Improve MRPC efficiency by leveraging write combining Wesley Sheng
2018-12-10 9:12 ` [PATCH 5/5] switchtec: MRPC DMA mode implementation Wesley Sheng
2018-12-12 22:52 ` Bjorn Helgaas
2018-12-12 22:58 ` Logan Gunthorpe
2018-12-13 15:16 ` Bjorn Helgaas
2018-12-13 15:17 ` Bjorn Helgaas
2018-12-13 16:46 ` Logan Gunthorpe [this message]
2018-12-13 15:20 ` [PATCH 0/5] Switchtec MRPC DMA mode support Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2018-11-15 9:43 Wesley Sheng
2018-11-15 9:44 ` [PATCH 5/5] switchtec: MRPC DMA mode implementation Wesley Sheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f81d636-95da-af77-0a7c-0ad439c0a866@deltatee.com \
--to=logang@deltatee.com \
--cc=helgaas@kernel.org \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wesley.sheng@microchip.com \
--cc=wesleyshenggit@sina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).