From: Xiaowei Bao <xiaowei.bao@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Leo Li <leoyang.li@nxp.com>, "M.h. Lian" <minghuan.lian@nxp.com>,
Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Z.q. Hou" <zhiqiang.hou@nxp.com>
Subject: RE: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
Date: Tue, 8 Oct 2019 07:11:47 +0000 [thread overview]
Message-ID: <AM5PR04MB329984A4B6BAD35510310CF5F59A0@AM5PR04MB3299.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191003091019.GB22491@X250>
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: 2019年10月3日 17:11
> To: Xiaowei Bao <xiaowei.bao@nxp.com>
> Cc: robh+dt@kernel.org; mark.rutland@arm.com; Leo Li
> <leoyang.li@nxp.com>; M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu
> <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>;
> lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linuxppc-dev@lists.ozlabs.org;
> bhelgaas@google.com; Z.q. Hou <zhiqiang.hou@nxp.com>
> Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
>
> On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> > Add support for the LS1028a PCIe controller.
> >
> > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> > v2:
> > - No change.
> > v3:
> > - Reuse the ls2088 driver data structurt.
> > v4:
> > - No change.
> > v5:
> > - No change.
> > v6:
> > - No change.
> >
> > drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c
> > b/drivers/pci/controller/dwc/pci-layerscape.c
> > index 3a5fa26..f24f79a 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata
> > = { static const struct of_device_id ls_pcie_of_match[] = {
> > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
>
> I think you can save this driver change by using "fsl,ls2088a-pcie" as
> compatible fallback like below.
>
> compatible = "fsl,ls1028a-pcie", "fsl,ls2088a-pcie";
Yes, it is ok to do so, but according to the previous code, I think add a new compatible " fsl,ls1028a-pcie " to driver is better.
Thanks
Xiaowei
>
> Shawn
>
> > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> > --
> > 2.9.5
> >
next prev parent reply other threads:[~2019-10-08 7:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 3:43 [PATCH v6 1/3] dt-bindings: pci: layerscape-pci: add compatible strings "fsl,ls1028a-pcie" Xiaowei Bao
2019-09-02 3:43 ` [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes Xiaowei Bao
2020-02-24 8:11 ` Michael Walle
2020-02-24 8:43 ` Shawn Guo
2020-02-24 8:53 ` Michael Walle
2020-02-24 9:22 ` Z.q. Hou
2020-02-26 15:42 ` Michael Walle
2019-09-02 3:43 ` [PATCH v6 3/3] PCI: layerscape: Add LS1028a support Xiaowei Bao
2019-10-03 9:10 ` Shawn Guo
2019-10-08 7:11 ` Xiaowei Bao [this message]
2019-11-05 11:04 ` Andrew Murray
2019-11-05 12:32 ` Lorenzo Pieralisi
2019-11-06 3:35 ` Xiaowei Bao
2019-11-06 3:46 ` M.h. Lian
2019-11-06 15:01 ` Lorenzo Pieralisi
2019-11-05 11:05 ` [PATCH v6 1/3] dt-bindings: pci: layerscape-pci: add compatible strings "fsl,ls1028a-pcie" Andrew Murray
2019-11-06 16:09 ` Lorenzo Pieralisi
2019-11-07 3:07 ` Xiaowei Bao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR04MB329984A4B6BAD35510310CF5F59A0@AM5PR04MB3299.eurprd04.prod.outlook.com \
--to=xiaowei.bao@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=minghuan.lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh+dt@kernel.org \
--cc=roy.zang@nxp.com \
--cc=shawnguo@kernel.org \
--cc=zhiqiang.hou@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).