From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Leo Li <leoyang.li@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
Mingkai Hu <mingkai.hu@nxp.com>,
"M.h. Lian" <minghuan.lian@nxp.com>
Subject: RE: [PATCH 2/4] doc/layerscape-pci: removed unsuitable compatible string
Date: Fri, 23 Nov 2018 06:22:06 +0000 [thread overview]
Message-ID: <AM6PR04MB5781C1086B4EFF1BF73F72B284D40@AM6PR04MB5781.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181122112809.GA11952@e107981-ln.cambridge.arm.com>
Hi Lorenzo,
Thanks a lot for your comments!
> -----Original Message-----
> From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com]
> Sent: 2018年11月22日 19:28
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> linux-pci@vger.kernel.org; devicetree@vger.kernel.org; robh+dt@kernel.org;
> Leo Li <leoyang.li@nxp.com>; shawnguo@kernel.org;
> mark.rutland@arm.com; bhelgaas@google.com; Mingkai Hu
> <mingkai.hu@nxp.com>; M.h. Lian <minghuan.lian@nxp.com>
> Subject: Re: [PATCH 2/4] doc/layerscape-pci: removed unsuitable compatible
> string
>
> On Mon, Oct 08, 2018 at 11:14:26AM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > Removed the compatible string "snps,dw-pcie", it is for the reference
> > platform driver for PCI RC IP Protoyping Kits based on the ARC SDP, so
> > it is not suitable for all platform with designware PCIe controller,
> > and platform vendors have themselves' drivers.
> >
> > The compatible string "snsp,dw-pcie" was added by mistake and it's not
> > matched that time, but it is matched because pcie drivers has been
> > collected recently.
>
> I do not understand what you mean, please explain it to me and I will update
> the commit log accordingly before merging it.
Before moving PCIe controller drivers to directory drivers/pci/controllers/, pci-layerscape.c can be matched correctly, but after that the pcie-designware-plat.c is matched instead of the pci-layerscape.c. So this patch is to avoid matching pcie-designware-plat.c by removing the "snps,dw-pcie".
Thanks,
Zhiqiang
> Lorenzo
>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > index 5eb1c202932f..9b2b8d66d1f4 100644
> > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > @@ -13,8 +13,8 @@ information.
> >
> > Required properties:
> > - compatible: should contain the platform identifier such as:
> > - "fsl,ls1021a-pcie", "snps,dw-pcie"
> > - "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
> > + "fsl,ls1021a-pcie"
> > + "fsl,ls2080a-pcie", "fsl,ls2085a-pcie"
> > "fsl,ls2088a-pcie"
> > "fsl,ls1088a-pcie"
> > "fsl,ls1046a-pcie"
> > @@ -36,7 +36,7 @@ Required properties:
> > Example:
> >
> > pcie@3400000 {
> > - compatible = "fsl,ls1021a-pcie", "snps,dw-pcie";
> > + compatible = "fsl,ls1021a-pcie";
> > reg = <0x00 0x03400000 0x0 0x00010000 /* controller registers
> */
> > 0x40 0x00000000 0x0 0x00002000>; /* configuration space
> */
> > reg-names = "regs", "config";
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2018-11-23 6:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 3:14 [PATCH 0/4] dts/layerscape-pci: removed unsuitable compatible string Zhiqiang Hou
2018-10-08 3:14 ` [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible strings Zhiqiang Hou
2018-10-17 13:51 ` Rob Herring
2018-10-25 9:27 ` Z.q. Hou
2018-10-08 3:14 ` [PATCH 2/4] doc/layerscape-pci: removed unsuitable compatible string Zhiqiang Hou
2018-10-17 13:53 ` Rob Herring
2018-10-25 9:28 ` Z.q. Hou
2018-11-22 11:28 ` Lorenzo Pieralisi
2018-11-23 6:22 ` Z.q. Hou [this message]
2018-10-08 3:14 ` [PATCH 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings Zhiqiang Hou
2018-10-08 3:14 ` [PATCH 4/4] dts/arm64/layerscape: " Zhiqiang Hou
2018-11-20 12:53 ` [PATCH 0/4] dts/layerscape-pci: removed unsuitable compatible string Lorenzo Pieralisi
2018-11-23 7:36 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB5781C1086B4EFF1BF73F72B284D40@AM6PR04MB5781.eurprd04.prod.outlook.com \
--to=zhiqiang.hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=minghuan.lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).