RE: [PATCH v1 0/2] Fix the wrong order of phy callbacks

[Hongxing Zhu <hongxing.zhu@nxp.com>]

> -----Original Message-----
> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Sent: 2022年8月29日 14:34
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; l.stach@pengutronix.de;
> bhelgaas@google.com; lorenzo.pieralisi@arm.com; vkoul@kernel.org; Marcel
> Ziswiler <marcel.ziswiler@toradex.com>; kishon@ti.com
> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; kernel@pengutronix.de; linux-phy@lists.infradead.org;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v1 0/2] Fix the wrong order of phy callbacks
> 
> Hi,
> 
> On 22.08.22 15:10, Richard Zhu wrote:
> > Refer [1], phy_init() must be called before phy_power_on().
> > This series used to fix the wrong order of the phy_init() and
> > phy_power_on(), introduced by commit 1aa97b002258 ("phy: freescale:
> > pcie: Initialize the imx8 pcie standalone phy driver") Tested on i.MX8MM EVK
> board when one NVME device is used.
> >
> > [1]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
> >
> it.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.gi
> >
> t%2Ftree%2Fdrivers%2Fphy%2Fphy-core.c%3Fid%3Dv5.19-rc1%23n233&amp;
> data
> >
> =05%7C01%7Chongxing.zhu%40nxp.com%7C327761bac5b9407d977008da89
> 886b15%7
> >
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63797351625465698
> 5%7CUnkno
> >
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiL
> >
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=6SnkRdLAX2tLp1iGgE78d
> JAm%2BLOf
> > LLpANfR1e4xIYFY%3D&amp;reserved=0
> >
> > [PATCH v1 1/2] PCI: imx6: Fix the wrong order of phy_init() and [PATCH
> > v1 2/2] phy: freescale: imx8m-pcie: Fix the wrong order of
> 
> This introduces an intermittent breakage. Can you squash?

Hi Ahmad:
Thanks for your comments.
Do you mean to squash this fix to the preview series?
I'm afraid that it's not easy to do that.
Because there are a lot of pci-imx6 code changes after 
commit: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver").

Best Regards
Richard Zhu
> 
> >
> >
> 
> 
> --
> Pengutronix e.K.                           |
> |
> Steuerwalder Str. 21                       |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
> ngutronix.de%2F&amp;data=05%7C01%7Chongxing.zhu%40nxp.com%7C3277
> 61bac5b9407d977008da89886b15%7C686ea1d3bc2b4c6fa92cd99c5c30163
> 5%7C0%7C0%7C637973516254656985%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C3000%7C%7C%7C&amp;sdata=hasOtX77%2Fea5yLbV8C7wOfdZStF5erHOL58
> Zf6ZZbo4%3D&amp;reserved=0  |
> 31137 Hildesheim, Germany                  | Phone:
> +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:
> +49-5121-206917-5555 |