linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	"Antonovitch, Anatoli" <Anatoli.Antonovitch@amd.com>
Cc: Lukas Wunner <lukas@wunner.de>,
	Anatoli Antonovitch <a.antonovitch@gmail.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: RE: [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock.
Date: Fri, 17 Feb 2023 18:37:54 +0000	[thread overview]
Message-ID: <BL1PR12MB51445CE9642195E9DEBC9CB8F7A19@BL1PR12MB5144.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230217160358.GA3404296@bhelgaas>

[Public]

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Friday, February 17, 2023 11:04 AM
> To: Antonovitch, Anatoli <Anatoli.Antonovitch@amd.com>
> Cc: Lukas Wunner <lukas@wunner.de>; Anatoli Antonovitch
> <a.antonovitch@gmail.com>; linux-pci@vger.kernel.org;
> bhelgaas@google.com; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>
> Subject: Re: [PATCH] PCI/hotplug: Replaced down_write_nested with
> hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock.
> 
> On Mon, Feb 13, 2023 at 09:59:52AM -0500, Anatoli Antonovitch wrote:
> > Hi Lukas,
> >
> > Can we revisit the patches again to get a fix?
> > The issue still reproduce and visible in the kernel 6.2.0-rc8.
> 
> > On 2023-01-23 14:30, Anatoli Antonovitch wrote:
> > > I do not see a deadlock, when applying the following old patch:
> > > https://lore.kernel.org/linux-pci/908047f7699d9de9ec2efd6b79aa752d73
> > > dab4b6.1595329748.git.lukas@wunner.de/
> 
> This old patch would need to be updated and reposted.  There was a 0-day
> bot issue and a question to be resolved.  Maybe this is all already resolved,
> but it needs to be posted and tested with a current kernel.

Lukas, can you resend that patch?  We can test it.

Alex

> 
> > > after merge for the kernel 6.2.0-rc5, and applied the alternative patch:
> > > https://patchwork.kernel.org/project/linux-pci/patch/3dc88ea82bdc0e3
> > > 7d9000e413d5ebce481cbd629.1674205689.git.lukas@wunner.de/
> 
> This one is on track to appear in v6.3-rc1:
> https://git.kernel.org/cgit/linux/kernel/git/pci/pci.git/commit/?id=74ff8864c
> c84
> 
> > > I have uploaded the merged patch and the system log for the upstream
> > > kernel.
> > >
> > > Anatoli
> > >
> > >
> > > On 2023-01-21 02:21, Lukas Wunner wrote:
> > > > You're now getting a different deadlock. That one is addressed by
> > > > this old patch (it's already linked from the bugzilla):
> > > >
> > > > https://lore.kernel.org/linux-pci/908047f7699d9de9ec2efd6b79aa752d
> > > > 73dab4b6.1595329748.git.lukas@wunner.de/
> > > >
> > > >
> > > > If you apply that patch plus the new one, do you still see a deadlock?

  reply	other threads:[~2023-02-17 18:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 17:01 [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock Anatoli Antonovitch
2023-01-20  9:28 ` Lukas Wunner
2023-01-20 21:35   ` Anatoli Antonovitch
2023-01-21  7:21     ` Lukas Wunner
2023-01-23 19:30       ` Anatoli Antonovitch
2023-02-13 14:59         ` Anatoli Antonovitch
2023-02-17 16:03           ` Bjorn Helgaas
2023-02-17 18:37             ` Deucher, Alexander [this message]
2023-02-19 20:21               ` Lukas Wunner
2023-04-10 20:36                 ` Anatoli Antonovitch
  -- strict thread matches above, loose matches on Subject: below --
2023-01-05 18:43 Anatoli Antonovitch
2023-01-05 19:18 ` Bjorn Helgaas
     [not found]   ` <5b9a2dc7-54ab-82c5-81e7-1770a4ec891c@amd.com>
2023-01-16 18:37     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL1PR12MB51445CE9642195E9DEBC9CB8F7A19@BL1PR12MB5144.namprd12.prod.outlook.com \
    --to=alexander.deucher@amd.com \
    --cc=Anatoli.Antonovitch@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=a.antonovitch@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).