From: Long Li <longli@microsoft.com>
To: Leon Romanovsky <leon@kernel.org>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Purna Pavan Chandra Aekkaladevi <paekkaladevi@microsoft.com>
Subject: RE: [Patch v3] PCI: hv: Fix NUMA node assignment when kernel boots with custom NUMA topology
Date: Wed, 26 Jan 2022 02:11:31 +0000 [thread overview]
Message-ID: <BY5PR21MB1506581FBD71CE22CE88A9F8CE209@BY5PR21MB1506.namprd21.prod.outlook.com> (raw)
In-Reply-To: <Ye0wSwQhsnk2nB8z@unreal>
> Subject: Re: [Patch v3] PCI: hv: Fix NUMA node assignment when kernel boots
> with custom NUMA topology
>
> On Wed, Jan 19, 2022 at 11:59:06AM -0800, longli@linuxonhyperv.com wrote:
> > From: Long Li <longli@microsoft.com>
> >
> > When kernel boots with a NUMA topology with some NUMA nodes offline,
> > the PCI driver should only set an online NUMA node on the device. This
> > can happen during KDUMP where some NUMA nodes are not made online by
> the KDUMP kernel.
> >
> > This patch also fixes the case where kernel is booting with "numa=off".
> >
> > Fixes: 999dd956d838 ("PCI: hv: Add support for protocol 1.3 and
> > support PCI_BUS_RELATIONS2")
> >
>
> No blank line here, please
>
> > Signed-off-by: Long Li <longli@microsoft.com>
>
> Everything below needs to be under "---" marker.
I'm sending v4 to address the comments.
Long
>
> Thanks
>
> >
> > Change log:
> > v2: use numa_map_to_online_node() to assign a node to device
> > (suggested by Michael Kelly <mikelley@microsoft.com>)
> >
> > v3: add "Fixes" and check for num_possible_nodes()
> > ---
> > drivers/pci/controller/pci-hyperv.c | 13 +++++++++++--
> > 1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/pci-hyperv.c
> > b/drivers/pci/controller/pci-hyperv.c
> > index 6c9efeefae1b..b5276e81bb44 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -2129,8 +2129,17 @@ static void hv_pci_assign_numa_node(struct
> hv_pcibus_device *hbus)
> > if (!hv_dev)
> > continue;
> >
> > - if (hv_dev->desc.flags &
> HV_PCI_DEVICE_FLAG_NUMA_AFFINITY)
> > - set_dev_node(&dev->dev, hv_dev-
> >desc.virtual_numa_node);
> > + if (hv_dev->desc.flags &
> HV_PCI_DEVICE_FLAG_NUMA_AFFINITY &&
> > + hv_dev->desc.virtual_numa_node < num_possible_nodes())
> > + /*
> > + * The kernel may boot with some NUMA nodes offline
> > + * (e.g. in a KDUMP kernel) or with NUMA disabled via
> > + * "numa=off". In those cases, adjust the host provided
> > + * NUMA node to a valid NUMA node used by the kernel.
> > + */
> > + set_dev_node(&dev->dev,
> > + numa_map_to_online_node(
> > + hv_dev->desc.virtual_numa_node));
> >
> > put_pcichild(hv_dev);
> > }
> > --
> > 2.25.1
> >
prev parent reply other threads:[~2022-01-26 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 19:59 [Patch v3] PCI: hv: Fix NUMA node assignment when kernel boots with custom NUMA topology longli
2022-01-19 22:57 ` Michael Kelley (LINUX)
2022-01-23 10:39 ` Leon Romanovsky
2022-01-26 2:11 ` Long Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR21MB1506581FBD71CE22CE88A9F8CE209@BY5PR21MB1506.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=paekkaladevi@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).