From: Dexuan Cui <decui@microsoft.com>
To: "Krzysztof Wilczyński" <kw@linux.com>,
"Dexuan-Linux Cui" <dexuan.linux@gmail.com>
Cc: "Pali Rohár" <pali@kernel.org>,
"Koen Vandeputte" <koen.vandeputte@citymesh.com>,
"Petr Štetiar" <ynezz@true.cz>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>, "Yinghai Lu" <yinghai@kernel.org>,
"Sasha Levin" <sashal@kernel.org>
Subject: RE: PCI: Race condition in pci_create_sysfs_dev_files
Date: Thu, 18 Nov 2021 03:42:26 +0000 [thread overview]
Message-ID: <BYAPR21MB1270F854FECEE55279525698BF9B9@BYAPR21MB1270.namprd21.prod.outlook.com> (raw)
In-Reply-To: <YZXEBXVc03uA904k@rocinante>
> From: Krzysztof Wilczyński <kw@linux.com>
> Sent: Wednesday, November 17, 2021 7:10 PM
> [...]
> > I think we're seeing the same issue with a Linux VM on Hyper-V.
>
> Are you still seeing this issue happen? If so, does it happen often?
This doesn't happen often. It's found by our test team.
> We haven't had a report from a system that runs as a hypervisor guest
> before. I also assume this is x86 or x86_64 platform, correct?
Yes, x86_64.
> > Here the kernel is ...
> >
> This is quite an old kernel, however the 5.4 is a long-term kernel, and
> therefore we need to make sure that it would also work properly.
>
> >
> '/devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A03:00/device:07/VMBUS:01/475
> 05500-0003-0000-3130-444531334632/pci0003:00/0003:00:00.0/config'
>
> Following the commit e1d3f3268b0e ("PCI/sysfs: Convert "config" to static
> attribute"), the issue particularly with the "config" attribute should be
> resolved, thus more modern kernel versions are no long suffer from the race
> condition related to this specific and some other problematic attributes.
Thanks for sharing the commit info! It's great to know this has been fixed
in the mainlinekernel.
> We quite likely have to back-port these changes to a number of older
> long-term kernels. I am going to look into it.
Sounds good! Thank you, Krzysztof!
> Hopefully, once the patches land in upstream long-term kernels, then
> distributions would be able to cherry-pick them and apply to their kernels
> releases.
>
> Krzysztof
Yes, this should work.
Thanks,
-- Dexuan
next prev parent reply other threads:[~2021-11-18 3:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 11:04 PCI: Race condition in pci_create_sysfs_dev_files Pali Rohár
2020-08-14 8:08 ` Pali Rohár
2020-09-09 11:28 ` Pali Rohár
2020-10-05 8:20 ` Pali Rohár
2020-10-05 13:54 ` Bjorn Helgaas
2020-10-06 22:22 ` Bjorn Helgaas
2020-10-07 1:47 ` Oliver O'Halloran
2020-10-07 8:14 ` Pali Rohár
2020-10-07 16:14 ` Bjorn Helgaas
2020-10-08 19:59 ` Bjorn Helgaas
2020-10-09 8:08 ` Pali Rohár
2020-11-04 16:29 ` Pali Rohár
2020-11-15 6:19 ` Krzysztof Wilczyński
2020-11-15 12:10 ` Pali Rohár
2020-10-07 8:12 ` Pali Rohár
2021-04-07 14:25 ` Petr Štetiar
2021-04-07 14:51 ` Pali Rohár
2021-04-07 15:30 ` Petr Štetiar
2021-06-25 11:29 ` Koen Vandeputte
2021-06-25 11:54 ` Pali Rohár
2021-10-13 6:18 ` Dexuan-Linux Cui
2021-11-18 3:09 ` Krzysztof Wilczyński
2021-11-18 3:42 ` Dexuan Cui [this message]
2020-11-04 16:46 ` Pali Rohár
2021-04-07 14:41 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR21MB1270F854FECEE55279525698BF9B9@BYAPR21MB1270.namprd21.prod.outlook.com \
--to=decui@microsoft.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=dexuan.linux@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=helgaas@kernel.org \
--cc=koen.vandeputte@citymesh.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pali@kernel.org \
--cc=sashal@kernel.org \
--cc=yinghai@kernel.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).