> On Jun 26, 2015, at 11:04 AM, Rustad, Mark D wrote: > >> Sorry, Mark, I've just been busy with other issues and haven't had a >> chance to look at this yet. > > Is there any chance of this getting into this merge window? Well, it has missed the merge window, but this really is a bug fix. These patches address problems that, under race conditions, can corrupt VPD data and under other conditions can cause hangs. In fact I would submit that the reason that the VPD operations have been made interruptible is directly related to hangs caused by the sharing of VPD capability registers between functions. You see, if one function ever performs a VPD write, any subsequent read on any other function that shares those registers will definitely hang. I imagine that there are many devices beyond Intel's Ethernet devices that would benefit from using the quirk that these patches introduce. Please apply it and consider it for -stable. -- Mark Rustad, Networking Division, Intel Corporation