From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9076C3F68F for ; Thu, 13 Feb 2020 15:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A156924687 for ; Thu, 13 Feb 2020 15:54:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="gy+gwxeq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387635AbgBMPyS (ORCPT ); Thu, 13 Feb 2020 10:54:18 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46583 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387965AbgBMPyR (ORCPT ); Thu, 13 Feb 2020 10:54:17 -0500 Received: by mail-wr1-f68.google.com with SMTP id z7so7277696wrl.13 for ; Thu, 13 Feb 2020 07:54:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BncL0+XD43RhxS89iRgODSVbvs7SMtr+UstAFU48Su0=; b=gy+gwxeqTOksSrRrjnTNb3ooArrrBq/WJqL2vuteprKqijh6HcJ5Eii/2Bj7ABgQxZ V5fweqnHLTMgJtX2vj5uBNW265L7AIbR2+zEOQEeZCDD33AwiWT2j+I8vzgBHiAhVifi KRcUHQYZdKuL3aQ1U/udIIbDSSSOiDXeUVaoc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BncL0+XD43RhxS89iRgODSVbvs7SMtr+UstAFU48Su0=; b=Oo2BeDed9NU7GeOrjdHu3u9S1SjkMuzvl+i2wEHPdblhYUepGHLJ364YwAgqiYPSQR KKp3Mphk0WDZ325zxiPpgUwfp+PuPIF8JNaJg096pKKVEOLpDRFlCZa9kPlee3d7MYPo rFelEeWmWwKNuFotWsDEq/RASBW0F4LomABaYBqHgxK5l9cPYdSTpPea9SNrPzxyZBQG uSReVSwQhoWjD0ngcBtCRh7YqV63axRct5UzxMPZBVgZ6G8lLeap4H8eqdLJVQ6uc+3H GJst1J3feyg3bZgEz42o02XdRwtVoNKrKLR8C9wcNvJUl7o4pD6w3wELkkRoa7hjFw/M cA5A== X-Gm-Message-State: APjAAAX1XMx6CAMfTxZfWflB5vQMyiXJi17M9/DNQu5poz+P4H+RLHAy t07529mC92Y437czB+20pSt8+HutpHl9Gda2yUodeA== X-Google-Smtp-Source: APXvYqzqlhfTv3u6j/of0GU1h8UocABGOozIc4x6AqtA+5+X784yM3rvl4U9lh/7hs2hMWYofh+E1Afe7RpyRN9Cs5c= X-Received: by 2002:adf:e692:: with SMTP id r18mr22518034wrm.413.1581609255837; Thu, 13 Feb 2020 07:54:15 -0800 (PST) MIME-Version: 1.0 References: <20200213025930.27943-1-jaedon.shin@gmail.com> <6ba4bb21-034b-93f0-d4b7-13ac7c5a925d@gmail.com> <44052F86-D0DD-4FDD-A62B-09280E956405@gmail.com> In-Reply-To: <44052F86-D0DD-4FDD-A62B-09280E956405@gmail.com> From: Jim Quinlan Date: Thu, 13 Feb 2020 10:54:04 -0500 Message-ID: Subject: Re: [PATCH 0/3] PCI: brcmstb: Add Broadcom STB support To: Jaedon Shin Cc: Florian Fainelli , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, Bjorn Helgaas , Rob Herring , Mark Rutland , Lorenzo Pieralisi , Andrew Murray , Gregory Fong , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Feb 13, 2020 at 12:15 AM Jaedon Shin wrote: > > > > 2020. 2. 13. =EC=98=A4=ED=9B=84 12:54, Florian Fainelli =EC=9E=91=EC=84=B1: > > > > +Jim, > > > > On 2/12/2020 6:59 PM, Jaedon Shin wrote: > >> This series enables the ARM based Broadcom STB SoCs and supports GPIO > >> based regulators for its power supplies. and this has an improvement o= n > >> devm_ APIS. > > > > Which ARM-based SoCs did you try this on? We still have an issue with > > the multiple dma-ranges that must be handled to support 7445 with memor= y > > in the extension regions as well as 7278 and 7216. > > > I'm using BCM72604 which has only one memc. and device is Qualcomm Athero= s > QCA6174 Wi-Fi module. > You apparently have a simple enough memory configuration such that the current upstream driver will work. But this will not work for a 7445-based chip or other BCM7xxx chips that either have a memory region extension or a non-zero system memory offset. IIRC, similar regulator code was submitted before as part of the complete driver that could handle our curious DMA situation, but was rejected because someone objected to us using a generic list of regulators without specific explanation for each in the device tree documentations. I hope you have better luck :-) Thanks, Jim > > > > See comments in specific patches. > > > >> > >> Jaedon Shin (3): > >> PCI: brcmstb: Enable ARCH_BRCMSTB > >> PCI: brcmstb: Add regulator support > >> PCI: brcmstb: Drop clk_put when probe fails and remove > >> > >> .../bindings/pci/brcm,stb-pcie.yaml | 8 +- > >> drivers/gpio/gpio-brcmstb.c | 13 +++- > >> drivers/pci/controller/Kconfig | 2 +- > >> drivers/pci/controller/pcie-brcmstb.c | 78 ++++++++++++++++++- > >> 4 files changed, 97 insertions(+), 4 deletions(-) > >> > > > > -- > > Florian >