From: Mathias Krause <minipli@googlemail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Mathias Krause <minipli@googlemail.com>
Subject: Re: [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION
Date: Sun, 9 Sep 2012 18:54:56 +0200 [thread overview]
Message-ID: <CA+rthh-nAf8jejcfqjT+uBSVNjpv4y_+tzUD4P7p9TcW1furHA@mail.gmail.com> (raw)
In-Reply-To: <1346621844-31211-1-git-send-email-minipli@googlemail.com>
On Sun, Sep 2, 2012 at 11:37 PM, Mathias Krause <minipli@googlemail.com> wrote:
> It's redundant and makes sparse complain about it.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
> include/linux/pci.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 5faa831..aee24a8 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1472,7 +1472,7 @@ enum pci_fixup_pass {
> /* Anonymous variables would be nice... */
> #define DECLARE_PCI_FIXUP_SECTION(section, name, vendor, device, class, \
> class_shift, hook) \
> - static const struct pci_fixup const __pci_fixup_##name __used \
> + static const struct pci_fixup __pci_fixup_##name __used \
> __attribute__((__section__(#section), aligned((sizeof(void *))))) \
> = { vendor, device, class, class_shift, hook };
>
> --
> 1.7.10.4
>
Ping? It's janitor work, but hey, it fixes a sparse warning.
Mathias
next prev parent reply other threads:[~2012-09-09 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 21:37 [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION Mathias Krause
2012-09-09 16:54 ` Mathias Krause [this message]
2012-09-11 0:07 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+rthh-nAf8jejcfqjT+uBSVNjpv4y_+tzUD4P7p9TcW1furHA@mail.gmail.com \
--to=minipli@googlemail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).