From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BAB9C2BB9A for ; Tue, 15 Dec 2020 13:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C39322286 for ; Tue, 15 Dec 2020 13:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727348AbgLONKR (ORCPT ); Tue, 15 Dec 2020 08:10:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727113AbgLONKE (ORCPT ); Tue, 15 Dec 2020 08:10:04 -0500 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8168EC06179C; Tue, 15 Dec 2020 05:09:24 -0800 (PST) Received: by mail-qv1-xf44.google.com with SMTP id a13so9397195qvv.0; Tue, 15 Dec 2020 05:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hdqeyKkCIkULH5xghW+2OPTmzGrNx+Inf0KzB+LcKvU=; b=h0Eu8pPEqm4M6eudkGrpydocbz0OgQtwdUoB2bgUwS39ZQAvEggcsjM02N7PSSJvCA SsS3FvHATcVhRzWfqA7JOtBE2z8I2IdwspFMySEDhpicCeTfvd4r8Xq8MwWRGYCQFLo3 /zYsjEmBjL7FS6VwxsA1Uq2Q7I1dUXIZ+ldktKfyWIPT0hli/OyqDK96wU+3UEhWmPNo 3BylVFloB41crHzIVjGIiO8uqxp9odzKPirwkmkMJJzpRAe7vKVg1iBu3GD5txDcwpk9 IeaXnG6W1rTi00jihmXS+FuGMyBm3dEiN0rHDjryPBiL9D8cpjKL6u6i5xsIMEvGXOKU jczQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hdqeyKkCIkULH5xghW+2OPTmzGrNx+Inf0KzB+LcKvU=; b=hxyobqDaEOGnrAEmaAlNisLMI/oW3Uwgb3MBEh/jUWPfCNxI6NL7CMqeC1ze2CuiFF aEXWuAC/cNuXRHK6HZPg8cBlbkImKTPOTs1lpE24NNTsigwhxI7Bo4uaZK3kH4UN+fOK O32ZGfip6BrFJGSYtxoqHyUp/qzQLdJJHaaCNXuE7txJjB+kYbmksPUgYdhS6MtTqvG3 sYzrBFmIdxtI9DHxOtGRpQMRStMOr0OUOvJs16zrcpHx0auON4aavc6a7l2C8qzQc+AJ kq5VN1DHxCrMdQKWjvHfFxqokDy7TEaushYQcdI4u/YQKjY5ZtStkxLgTohQk32l1F0T khhg== X-Gm-Message-State: AOAM531ZdsfPuvGqGx5rfnN+BOnW0XLN2e3BPfaz6SHfSD6tltM+eVE1 s+b7xr72I7myuAVRgBNDWdXkHwr4kB3XSROmINs= X-Google-Smtp-Source: ABdhPJxlGdBwLcqYBPtaQEMyirP/hdBZ95RAAqVxvBNdnGMzkIna/DL9tdprm+WLHCBJjyDfXP66FkFmREuxLR2xRkE= X-Received: by 2002:a0c:b3d1:: with SMTP id b17mr37337119qvf.41.1608037763580; Tue, 15 Dec 2020 05:09:23 -0800 (PST) MIME-Version: 1.0 References: <20201215004004.GA280628@bjorn-Precision-5520> In-Reply-To: <20201215004004.GA280628@bjorn-Precision-5520> From: Ian Kumlien Date: Tue, 15 Dec 2020 14:09:12 +0100 Message-ID: Subject: Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check To: Bjorn Helgaas Cc: Kai-Heng Feng , linux-pci , Alexander Duyck , "Saheed O. Bolarinwa" , Puranjay Mohan , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Jakub Kicinski , Heiner Kallweit , intel-wired-lan , Linux Kernel Network Developers , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Dec 15, 2020 at 1:40 AM Bjorn Helgaas wrote: > > On Mon, Dec 14, 2020 at 11:56:31PM +0100, Ian Kumlien wrote: > > On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > > > If you're interested, you could probably unload the Realtek drivers, > > > remove the devices, and set the PCI_EXP_LNKCTL_LD (Link Disable) bit > > > in 02:04.0, e.g., > > > > > > # RT=/sys/devices/pci0000:00/0000:00:01.2/0000:01:00.0/0000:02:04.0 > > > # echo 1 > $RT/0000:04:00.0/remove > > > # echo 1 > $RT/0000:04:00.1/remove > > > # echo 1 > $RT/0000:04:00.2/remove > > > # echo 1 > $RT/0000:04:00.4/remove > > > # echo 1 > $RT/0000:04:00.7/remove > > > # setpci -s02:04.0 CAP_EXP+0x10.w=0x0010 > > > > > > That should take 04:00.x out of the picture. > > > > Didn't actually change the behaviour, I'm suspecting an errata for AMD pcie... > > > > So did this, with unpatched kernel: > > [ ID] Interval Transfer Bitrate Retr Cwnd > > [ 5] 0.00-1.00 sec 4.56 MBytes 38.2 Mbits/sec 0 67.9 KBytes > > [ 5] 1.00-2.00 sec 4.47 MBytes 37.5 Mbits/sec 0 96.2 KBytes > > [ 5] 2.00-3.00 sec 4.85 MBytes 40.7 Mbits/sec 0 50.9 KBytes > > [ 5] 3.00-4.00 sec 4.23 MBytes 35.4 Mbits/sec 0 70.7 KBytes > > [ 5] 4.00-5.00 sec 4.23 MBytes 35.4 Mbits/sec 0 48.1 KBytes > > [ 5] 5.00-6.00 sec 4.23 MBytes 35.4 Mbits/sec 0 45.2 KBytes > > [ 5] 6.00-7.00 sec 4.23 MBytes 35.4 Mbits/sec 0 36.8 KBytes > > [ 5] 7.00-8.00 sec 3.98 MBytes 33.4 Mbits/sec 0 36.8 KBytes > > [ 5] 8.00-9.00 sec 4.23 MBytes 35.4 Mbits/sec 0 36.8 KBytes > > [ 5] 9.00-10.00 sec 4.23 MBytes 35.4 Mbits/sec 0 48.1 KBytes > > - - - - - - - - - - - - - - - - - - - - - - - - - > > [ ID] Interval Transfer Bitrate Retr > > [ 5] 0.00-10.00 sec 43.2 MBytes 36.2 Mbits/sec 0 sender > > [ 5] 0.00-10.00 sec 42.7 MBytes 35.8 Mbits/sec receiver > > > > and: > > echo 0 > /sys/devices/pci0000:00/0000:00:01.2/0000:01:00.0/link/l1_aspm > > BTW, thanks a lot for testing out the "l1_aspm" sysfs file. I'm very > pleased that it seems to be working as intended. It was nice to find it for easy disabling :) > > and: > > [ ID] Interval Transfer Bitrate Retr Cwnd > > [ 5] 0.00-1.00 sec 113 MBytes 951 Mbits/sec 153 772 KBytes > > [ 5] 1.00-2.00 sec 109 MBytes 912 Mbits/sec 276 550 KBytes > > [ 5] 2.00-3.00 sec 111 MBytes 933 Mbits/sec 123 625 KBytes > > [ 5] 3.00-4.00 sec 111 MBytes 933 Mbits/sec 31 687 KBytes > > [ 5] 4.00-5.00 sec 110 MBytes 923 Mbits/sec 0 679 KBytes > > [ 5] 5.00-6.00 sec 110 MBytes 923 Mbits/sec 136 577 KBytes > > [ 5] 6.00-7.00 sec 110 MBytes 923 Mbits/sec 214 645 KBytes > > [ 5] 7.00-8.00 sec 110 MBytes 923 Mbits/sec 32 628 KBytes > > [ 5] 8.00-9.00 sec 110 MBytes 923 Mbits/sec 81 537 KBytes > > [ 5] 9.00-10.00 sec 110 MBytes 923 Mbits/sec 10 577 KBytes > > - - - - - - - - - - - - - - - - - - - - - - - - - > > [ ID] Interval Transfer Bitrate Retr > > [ 5] 0.00-10.00 sec 1.08 GBytes 927 Mbits/sec 1056 sender > > [ 5] 0.00-10.00 sec 1.07 GBytes 923 Mbits/sec receiver > > > > But this only confirms that the fix i experience is a side effect. > > > > The original code is still wrong :) > > What exactly is this machine? Brand, model, config? Maybe you could > add this and a dmesg log to the buzilla? It seems like other people > should be seeing the same problem, so I'm hoping to grub around on the > web to see if there are similar reports involving these devices. ASUS Pro WS X570-ACE with AMD Ryzen 9 3900X > https://bugzilla.kernel.org/show_bug.cgi?id=209725 > > Here's one that is superficially similar: > https://linux-hardware.org/index.php?probe=e5f24075e5&log=lspci_all > in that it has a RP -- switch -- I211 path. Interestingly, the switch > here advertises <64us L1 exit latency instead of the <32us latency > your switch advertises. Of course, I can't tell if it's exactly the > same switch. Same chipset it seems I'm running bios version: Version: 2206 Release Date: 08/13/2020 ANd latest is: Version 3003 2020/12/07 Will test upgrading that as well, but it could be that they report the incorrect latency of the switch - I don't know how many things AGESA changes but... It's been updated twice since my upgrade. > Bjorn