From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64951C4332F for ; Thu, 26 May 2022 20:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236795AbiEZU56 (ORCPT ); Thu, 26 May 2022 16:57:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232749AbiEZU54 (ORCPT ); Thu, 26 May 2022 16:57:56 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 697DDE7335 for ; Thu, 26 May 2022 13:57:55 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id d21so3020951qtj.5 for ; Thu, 26 May 2022 13:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NnCxigS7717S4njhAa3y/7BST7UjGl9n1OtAhplN6mo=; b=iy8H4nTnpm0ptlxNnAfnptyOMTeebWks3Da6z5yaa83efvUxLdEFA6QiomkdP/+Hzy yGPRJVd/DX4QjTA59rmSXFpGDgY4Cjm1YbVIXG19mzU9QK3+5lK9B+1PZRTK4IoE4s8T 9IPWTj4hxoPFqg+GicSYLid1B5BKBLnQsK90KqogfV78AMoAmiizhqdC9G94/eng6w0N MCe1USh1na/Akozw674DMHIelIANS7AoTi2NuicYGT5cFAcKnJLARbxNLc4jzKdH+exG LNaUOcbO3Ughtk1/OrNbJgA5hK+Votqe1UI80q5s3DFKTMCSindC8Xh83YVHkH28/t9S lvWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NnCxigS7717S4njhAa3y/7BST7UjGl9n1OtAhplN6mo=; b=Kej7Z9kzL8uDu4CeGQjlDGHCxSqc1Pqjwppzz1oQ9WeMhlm0ulIy2wlFrIrd1js19V ebOSCEFSp4qdFt8GtYUvzrXkIUNgeBPjk02du19jGuygG5QosKsSPb/u8H5oZQSCZc6Q Q/cpIhJbJ2CiQZNfjL0uRQjuPJ3Ab/dYHV4afXmxGD5x0HSKFK+MBtieE+FxDCBmZS6C Hs4vtOCPalGpjmvYZ5TgjcjhM9WX2X0NN1a1mTjuFB8F7ZYKtntqABtsR22XWHBagQg1 lTaLeqdLOFmyBJnk4ln2Q+3G+GUwPmqt2Uk6IP2BlIP96EQv7OcK5DpR7WjmJTGEhgYY 6cUQ== X-Gm-Message-State: AOAM531Eadfuc0wasYUFBJG7+tJSeYVmVsSsiTFCDP2+ZhCagOnv0grQ qRm9xoQdyOkXBwDcD9EODCOBbPWIg3CViVq1jr89Mw== X-Google-Smtp-Source: ABdhPJy9Iz128w6gl1rgxD4Wu4fUG4Ck/3/iu0g5XksP6rXdeZf88bLGlHne4Fhza3E/987ymifCxf9V9t82dGR0qjI= X-Received: by 2002:ac8:5e54:0:b0:2f3:f4ee:efbd with SMTP id i20-20020ac85e54000000b002f3f4eeefbdmr30013444qtx.295.1653598674574; Thu, 26 May 2022 13:57:54 -0700 (PDT) MIME-Version: 1.0 References: <20220523181836.2019180-1-dmitry.baryshkov@linaro.org> <20220523181836.2019180-5-dmitry.baryshkov@linaro.org> <20220526180955.GC54904-robh@kernel.org> In-Reply-To: <20220526180955.GC54904-robh@kernel.org> From: Dmitry Baryshkov Date: Thu, 26 May 2022 23:57:43 +0300 Message-ID: Subject: Re: [PATCH v12 4/8] PCI: dwc: split MSI IRQ parsing/allocation to a separate function To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Bjorn Helgaas , Stanimir Varbanov , Manivannan Sadhasivam , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, 26 May 2022 at 21:09, Rob Herring wrote: > > On Mon, May 23, 2022 at 09:18:32PM +0300, Dmitry Baryshkov wrote: > > Split handling of MSI host IRQs to a separate dw_pcie_msi_host_init() > > function. The code is complex enough to warrant a separate function. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > .../pci/controller/dwc/pcie-designware-host.c | 98 +++++++++++-------- > > 1 file changed, 56 insertions(+), 42 deletions(-) > > Reviewed-by: Rob Herring > > Note that we should probably apply this[1] or whatever fix we end up > with first. Ack, I will rebase this patch series the fix gets merged. > [1] https://lore.kernel.org/all/20220525223316.388490-1-willmcvicker@google.com/ -- With best wishes Dmitry