From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Kalle Valo <kvalo@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Saravana Kannan <saravanak@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Arnd Bergmann <arnd@arndb.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Alex Elder <elder@linaro.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Abel Vesa <abel.vesa@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
Amit Pundir <amit.pundir@linaro.org>,
Xilin Wu <wuxilin123@gmail.com>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v7 01/16] regulator: dt-bindings: describe the PMU module of the QCA6390 package
Date: Wed, 24 Apr 2024 23:48:03 +0300 [thread overview]
Message-ID: <CAA8EJpq81Z4YH1apTidntwcfpsL3YjgMM_y+G0=waaoPjRL-Cw@mail.gmail.com> (raw)
In-Reply-To: <20240410124628.171783-2-brgl@bgdev.pl>
On Wed, 10 Apr 2024 at 15:46, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The QCA6390 package contains discreet modules for WLAN and Bluetooth. They
> are powered by the Power Management Unit (PMU) that takes inputs from the
> host and provides LDO outputs. This document describes this module.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Acked-by: Mark Brown <broonie@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/regulator/qcom,qca6390-pmu.yaml | 151 ++++++++++++++++++
> 1 file changed, 151 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/qcom,qca6390-pmu.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,qca6390-pmu.yaml b/Documentation/devicetree/bindings/regulator/qcom,qca6390-pmu.yaml
> new file mode 100644
> index 000000000000..9d39ff9a75fd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/qcom,qca6390-pmu.yaml
> @@ -0,0 +1,151 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. QCA6390 PMU Regulators
> +
> +maintainers:
> + - Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> +
> +description:
> + The QCA6390 package contains discreet modules for WLAN and Bluetooth. They
> + are powered by the Power Management Unit (PMU) that takes inputs from the
> + host and provides LDO outputs. This document describes this module.
> +
> +properties:
> + compatible:
> + const: qcom,qca6390-pmu
> +
> + vddaon-supply:
> + description: VDD_AON supply regulator handle
> +
> + vddpmu-supply:
> + description: VDD_PMU supply regulator handle
> +
> + vddrfa0p95-supply:
> + description: VDD_RFA_0P95 supply regulator handle
> +
> + vddrfa1p3-supply:
> + description: VDD_RFA_1P3 supply regulator handle
> +
> + vddrfa1p9-supply:
> + description: VDD_RFA_1P9 supply regulator handle
> +
> + vddpcie1p3-supply:
> + description: VDD_PCIE_1P3 supply regulator handle<S-Del>
> +
> + vddpcie1p9-supply:
> + description: VDD_PCIE_1P9 supply regulator handle
> +
> + vddio-supply:
> + description: VDD_IO supply regulator handle
> +
> + wlan-enable-gpios:
> + maxItems: 1
> + description: GPIO line enabling the ATH11K WLAN module supplied by the PMU
> +
> + bt-enable-gpios:
> + maxItems: 1
> + description: GPIO line enabling the ATH11K Bluetooth module supplied by the PMU
As a side node, I think we should also steal swctrl pin from the
bluetooth device node. It represents the status of the PMU and as such
it is not BT-specific.
> +
> + regulators:
> + type: object
> + description:
> + LDO outputs of the PMU
> +
> + patternProperties:
> + "^ldo[0-9]$":
> + $ref: regulator.yaml#
> + type: object
> + unevaluatedProperties: false
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - regulators
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,qca6390-pmu
> + then:
> + required:
> + - vddaon-supply
> + - vddpmu-supply
> + - vddrfa0p95-supply
> + - vddrfa1p3-supply
> + - vddrfa1p9-supply
> + - vddpcie1p3-supply
> + - vddpcie1p9-supply
> + - vddio-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + pmu {
> + compatible = "qcom,qca6390-pmu";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&bt_en_state>, <&wlan_en_state>;
> +
> + vddaon-supply = <&vreg_s6a_0p95>;
> + vddpmu-supply = <&vreg_s2f_0p95>;
> + vddrfa0p95-supply = <&vreg_s2f_0p95>;
> + vddrfa1p3-supply = <&vreg_s8c_1p3>;
> + vddrfa1p9-supply = <&vreg_s5a_1p9>;
> + vddpcie1p3-supply = <&vreg_s8c_1p3>;
> + vddpcie1p9-supply = <&vreg_s5a_1p9>;
> + vddio-supply = <&vreg_s4a_1p8>;
> +
> + wlan-enable-gpios = <&tlmm 20 GPIO_ACTIVE_HIGH>;
> + bt-enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
> +
> + regulators {
> + vreg_pmu_rfa_cmn: ldo0 {
> + regulator-name = "vreg_pmu_rfa_cmn";
> + };
> +
> + vreg_pmu_aon_0p59: ldo1 {
> + regulator-name = "vreg_pmu_aon_0p59";
> + };
> +
> + vreg_pmu_wlcx_0p8: ldo2 {
> + regulator-name = "vreg_pmu_wlcx_0p8";
> + };
> +
> + vreg_pmu_wlmx_0p85: ldo3 {
> + regulator-name = "vreg_pmu_wlmx_0p85";
> + };
> +
> + vreg_pmu_btcmx_0p85: ldo4 {
> + regulator-name = "vreg_pmu_btcmx_0p85";
> + };
> +
> + vreg_pmu_rfa_0p8: ldo5 {
> + regulator-name = "vreg_pmu_rfa_0p8";
> + };
> +
> + vreg_pmu_rfa_1p2: ldo6 {
> + regulator-name = "vreg_pmu_rfa_1p2";
> + };
> +
> + vreg_pmu_rfa_1p7: ldo7 {
> + regulator-name = "vreg_pmu_rfa_1p7";
> + };
> +
> + vreg_pmu_pcie_0p9: ldo8 {
> + regulator-name = "vreg_pmu_pcie_0p9";
> + };
> +
> + vreg_pmu_pcie_1p8: ldo9 {
> + regulator-name = "vreg_pmu_pcie_1p8";
> + };
> + };
> + };
> --
> 2.40.1
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2024-04-24 20:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 12:46 [PATCH v7 00/16] power: sequencing: implement the subsystem and add first users Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 01/16] regulator: dt-bindings: describe the PMU module of the QCA6390 package Bartosz Golaszewski
2024-04-24 20:48 ` Dmitry Baryshkov [this message]
2024-04-10 12:46 ` [PATCH v7 02/16] regulator: dt-bindings: describe the PMU module of the WCN7850 package Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 03/16] dt-bindings: net: bluetooth: qualcomm: describe regulators for QCA6390 Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 04/16] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390 Bartosz Golaszewski
2024-04-12 7:53 ` Krzysztof Kozlowski
2024-04-10 12:46 ` [PATCH v7 05/16] dt-bindings: net: wireless: describe the ath12k PCI module Bartosz Golaszewski
2024-04-10 15:27 ` Jeff Johnson
2024-04-10 12:46 ` [PATCH v7 06/16] arm64: dts: qcom: sm8550-qrd: add the Wifi node Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 07/16] arm64: dts: qcom: sm8650-qrd: " Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 08/16] arm64: dts: qcom: qrb5165-rb5: " Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 09/16] PCI: hold the rescan mutex when scanning for the first time Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 10/16] PCI/pwrctl: reuse the OF node for power controlled devices Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 11/16] PCI/pwrctl: create platform devices for child OF nodes of the port node Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 12/16] PCI/pwrctl: add PCI power control core code Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 13/16] power: sequencing: implement the pwrseq core Bartosz Golaszewski
2024-04-14 10:39 ` Simon Horman
2024-04-10 12:46 ` [PATCH v7 14/16] power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets Bartosz Golaszewski
2024-04-10 15:57 ` Jeff Johnson
2024-04-14 10:44 ` Simon Horman
2024-04-10 12:46 ` [PATCH v7 15/16] Bluetooth: qca: use the power sequencer for QCA6390 Bartosz Golaszewski
2024-04-10 12:46 ` [PATCH v7 16/16] PCI/pwrctl: add a PCI power control driver for power sequenced devices Bartosz Golaszewski
2024-04-10 16:05 ` Jeff Johnson
2024-04-11 12:11 ` [PATCH v7 00/16] power: sequencing: implement the subsystem and add first users Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8EJpq81Z4YH1apTidntwcfpsL3YjgMM_y+G0=waaoPjRL-Cw@mail.gmail.com' \
--to=dmitry.baryshkov@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=elder@linaro.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=lukas@wunner.de \
--cc=m.szyprowski@samsung.com \
--cc=mani@kernel.org \
--cc=marcel@holtmann.org \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=will@kernel.org \
--cc=wuxilin123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).