From: Ani Sinha <ani@anisinha.ca>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Ani Sinha <ani@anirban.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Keith Busch <keith.busch@intel.com>,
Frederick Lawler <fred@fredlawl.com>,
Denis Efremov <efremov@linux.com>, Lukas Wunner <lukas@wunner.de>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Cleanup unused HP_SUPR_RM macro
Date: Mon, 20 Apr 2020 18:22:46 +0530 [thread overview]
Message-ID: <CAARzgwwk+=pRAfhg7bv8Zi8f91m5AMv8gVn9Rwxfgc7-RJ-dxg@mail.gmail.com> (raw)
In-Reply-To: <20200420090913.GV2586@lahna.fi.intel.com>
On Mon, Apr 20, 2020 at 2:39 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Sun, Apr 19, 2020 at 07:06:20PM +0530, Ani Sinha wrote:
> > We do not use PCIE hotplug surprise (PCI_EXP_SLTCAP_HPS) bit anymore.
> > Consequently HP_SUPR_RM() macro is not used in the kernel source anymore.
> > Let's clean it up.
> >
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> BTW, there seem to be other macros like EMI() that is not used anymore
> so maybe worth removing them as well.
Sent a patch.
>
>
> > ---
> > drivers/pci/hotplug/pciehp.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> > index ae44f46..5747967 100644
> > --- a/drivers/pci/hotplug/pciehp.h
> > +++ b/drivers/pci/hotplug/pciehp.h
> > @@ -148,7 +148,6 @@ struct controller {
> > #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
> > #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
> > #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> > -#define HP_SUPR_RM(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_HPS)
> > #define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
> > #define NO_CMD_CMPL(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
> > #define PSN(ctrl) (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
> > --
> > 2.7.4
prev parent reply other threads:[~2020-04-20 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 13:36 [PATCH] PCI: pciehp: Cleanup unused HP_SUPR_RM macro Ani Sinha
2020-04-20 9:09 ` Mika Westerberg
2020-04-20 12:52 ` Ani Sinha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAARzgwwk+=pRAfhg7bv8Zi8f91m5AMv8gVn9Rwxfgc7-RJ-dxg@mail.gmail.com' \
--to=ani@anisinha.ca \
--cc=andy.shevchenko@gmail.com \
--cc=ani@anirban.org \
--cc=bhelgaas@google.com \
--cc=efremov@linux.com \
--cc=fred@fredlawl.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).