From: Ani Sinha <ani@anisinha.ca>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ani Sinha <ani@anirban.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Keith Busch <keith.busch@intel.com>,
Frederick Lawler <fred@fredlawl.com>,
Denis Efremov <efremov@linux.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Lukas Wunner <lukas@wunner.de>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: remove unused EMI() macro
Date: Thu, 23 Apr 2020 23:31:47 +0530 [thread overview]
Message-ID: <CAARzgwzjqgqJY4+MdHCYEKOKxxVbt_d3C-fMwKtjSSFOnw+PqQ@mail.gmail.com> (raw)
In-Reply-To: <20200420175734.GA53587@google.com>
On Mon, Apr 20, 2020 at 11:27 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> Hi Ani,
>
> On Mon, Apr 20, 2020 at 06:21:41PM +0530, Ani Sinha wrote:
> > EMI() macro seems to be unused. So removing it. Thanks
> > Mika Westerberg <mika.westerberg@linux.intel.com> for
> > pointing it out.
> >
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> > ---
> > drivers/pci/hotplug/pciehp.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> > index 5747967..4fd200d 100644
> > --- a/drivers/pci/hotplug/pciehp.h
> > +++ b/drivers/pci/hotplug/pciehp.h
> > @@ -148,7 +148,6 @@ struct controller {
> > #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
> > #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
> > #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> > -#define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
>
> Thanks for the patch! Can you squash it together with the HP_SUPR_RM
> removal (and also check for any other unused ones at the same time)?
> For trivial things like this, I'd rather merge one patch that removes
> several unused things at once instead of several patches.
>
> I like the subject of this one ("Removed unused ..."), but please
> capitalize it as you did for the HP_SUPR_RM one so it matches previous
> history.
I have sent an updated patch few days back.
ani
prev parent reply other threads:[~2020-04-23 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 12:51 [PATCH] PCI: pciehp: remove unused EMI() macro Ani Sinha
2020-04-20 13:22 ` Mika Westerberg
2020-04-20 17:57 ` Bjorn Helgaas
2020-04-23 18:01 ` Ani Sinha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAARzgwzjqgqJY4+MdHCYEKOKxxVbt_d3C-fMwKtjSSFOnw+PqQ@mail.gmail.com \
--to=ani@anisinha.ca \
--cc=andy.shevchenko@gmail.com \
--cc=ani@anirban.org \
--cc=efremov@linux.com \
--cc=fred@fredlawl.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).