linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Keith Busch <kbusch@kernel.org>, Koba Ko <koba.ko@canonical.com>,
	Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme <linux-nvme@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Henrik Juul Hansen <hjhansen2020@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] nvme-pci: Avoid to go into d3cold if device can't use npss.
Date: Thu, 27 May 2021 20:08:19 +0800	[thread overview]
Message-ID: <CAAd53p5cF6i_5MiKXva+cpYBxCrVJJVT2ir=2ZiNHafUvO1oWQ@mail.gmail.com> (raw)
In-Reply-To: <20210527114029.GC17266@lst.de>

On Thu, May 27, 2021 at 7:40 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Thu, May 27, 2021 at 12:24:06AM +0800, Kai-Heng Feng wrote:
> > Yes, that's exactly what they said. Because Windows Modern Standby
> > always keep the NVMe at D0, so D3hot is untested by the vendors.
>
> So all the problems we've deal with latetly are that platforms cut the
> power off.  So it is not kept always at D0 which would be the right thing,
> but moved into D3cold.

It's still okay to use D3cold under s2idle if nvme_acpi_storage_d3()
check passes.

Otherwise D0 should be used. I am unsure how to proceed with HMB NVMes
if we can't setup DMA after resume...

>
> Which makes this patch to disable D3cold rather counterintuitive.

The intention of this patch is indeed very unclear.

Kai-Heng

      reply	other threads:[~2021-05-27 12:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210520033315.490584-1-koba.ko@canonical.com>
2021-05-25  7:44 ` [PATCH] nvme-pci: Avoid to go into d3cold if device can't use npss Christoph Hellwig
2021-05-25 16:49   ` Kai-Heng Feng
2021-05-25 20:14   ` Bjorn Helgaas
2021-05-26  2:02   ` Koba Ko
2021-05-26  2:49     ` Keith Busch
2021-05-26 12:11       ` Kai-Heng Feng
2021-05-26 12:59         ` Christoph Hellwig
2021-05-26 14:21           ` Kai-Heng Feng
2021-05-26 14:28             ` Christoph Hellwig
2021-05-26 14:47               ` Kai-Heng Feng
2021-05-26 15:06                 ` Bjorn Helgaas
2021-05-26 16:24                   ` Kai-Heng Feng
2021-05-27 11:40                     ` Christoph Hellwig
2021-05-27 12:08                       ` Kai-Heng Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAd53p5cF6i_5MiKXva+cpYBxCrVJJVT2ir=2ZiNHafUvO1oWQ@mail.gmail.com' \
    --to=kai.heng.feng@canonical.com \
    --cc=axboe@fb.com \
    --cc=bhelgaas@google.com \
    --cc=hch@lst.de \
    --cc=helgaas@kernel.org \
    --cc=hjhansen2020@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=koba.ko@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).