From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5648CC43461 for ; Wed, 16 Sep 2020 06:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16617208E4 for ; Wed, 16 Sep 2020 06:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Emg+QmhT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgIPGTu (ORCPT ); Wed, 16 Sep 2020 02:19:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbgIPGTr (ORCPT ); Wed, 16 Sep 2020 02:19:47 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADF74C06174A; Tue, 15 Sep 2020 23:19:45 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id h4so7029878ioe.5; Tue, 15 Sep 2020 23:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BQU4Vp5hkd72K0GyoRL03/6xjT4XAFXExo8+j37YSQY=; b=Emg+QmhTNMGGm2Yi4tpkGItYJUUePIBz2tdkxU8bs5Wt8dZcpWrB30CmPAIAuy4jXL LUGCbWYagicgR9MxLlzt4mcbULxHbQrGXV5yJSGmZN7ziABoN7mqxaI8h8vAoGb6zGi8 sJCQwNE039cWLxHl1cEUGcya5XSNB2eqh1k6Ct6J+Z01iwefgb948qLGwvJw2ut+v2H8 d6J5PsNNR0Id9Zv3kQxYeMEj07RQM4cJ9ZMCzCexW4ylpGDm895x8xKEKWeeIxpWTfSk mnzMZNy/ftKg1mWqVcmbPNhbHAJzRBOeXbklo65GM9UXektQbYuxvsNnp/LOZUvZLTDy 3bYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BQU4Vp5hkd72K0GyoRL03/6xjT4XAFXExo8+j37YSQY=; b=fXwazVLXYeQmyYqYE3sO9vdSJpJd1jpgW7BA6VCU3zNEEPu7WFzqFDBKJMiQFzCDyd JrrhW9ecMuvJjSC5c9sKosnHgq2FOlVvLwPmy6GT7vKIwpaopndU5QFAGjpDLb/k6RgG Mr+kf8YRdYnrUhUqIVS7o7aSEjqeYsldT7AwZQywtdVDnp/A98UuSlZAHne57irTJLk0 B/MnG3TTp+oq/oNHyXxLx3duo5ZL8PjjlhT4pFtLDcQh5chOUf2uLw+LOHD24TaETVvn J3Q1/x57VCJQ4KgpeKxd4NtiRSWzKDXicVvIIr/a4XpCziAVYR1SR855s49DWjO0cWmQ qYDw== X-Gm-Message-State: AOAM5321r558Z1mYDr6aGuuh2Nb/GU7XcFPIRQXKHSAYqy/WoIkngRFx OvC/xzJ9VNOPzUzSZuGLTn4BSI8hgO16+7E7Phs= X-Google-Smtp-Source: ABdhPJxJwlKzq65lh/+l/0BV+jVylFOtHxLYQBuCozH4dYszDDV7FPy8Umwb6AE6jiBjLbsBhdhchmt7zod0tdyxYnM= X-Received: by 2002:a05:6638:250d:: with SMTP id v13mr16460879jat.50.1600237185081; Tue, 15 Sep 2020 23:19:45 -0700 (PDT) MIME-Version: 1.0 References: <20200915203831.GA1426995@bjorn-Precision-5520> In-Reply-To: <20200915203831.GA1426995@bjorn-Precision-5520> From: Huacai Chen Date: Wed, 16 Sep 2020 02:19:27 -0400 Message-ID: Subject: Re: [RFC PATCH v3] PCI/portdrv: Only disable Bus Master on kexec reboot and connected PCI devices To: Bjorn Helgaas Cc: Tiezhu Yang , Bjorn Helgaas , linux-pci , linux-kernel , "Rafael J. Wysocki" , Konstantin Khlebnikov , Khalid Aziz , Vivek Goyal , Lukas Wunner , "Oliver O'Halloran" , Jiaxun Yang , Xuefeng Li , zhouyanjie , git Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, Bjorn, On Tue, Sep 15, 2020 at 4:38 PM Bjorn Helgaas wrote: > > On Tue, Sep 15, 2020 at 09:36:13AM +0800, Huacai Chen wrote: > > Hi, Tiezhu, > > > > On Mon, Sep 14, 2020 at 7:25 PM Tiezhu Yang wrote: > > > > > > On 09/14/2020 05:46 PM, Huacai Chen wrote: > > > > Hi, Tiezhu, > > > > > > > > On Mon, Sep 14, 2020 at 5:30 PM Tiezhu Yang wrote: > > > >> On 09/14/2020 04:52 PM, Huacai Chen wrote: > > > >>> Hi, Tiezhu, > > > >>> > > > >>> How do you test kexec? kexec -e or systemctl kexec? Or both? > > > >> kexec -l vmlinux --append="root=/dev/sda2 console=ttyS0,115200" > > > >> kexec -e > > > > So you haven't tested "systemctl kexec"? > > > > > > Yes, the distro I used is Loongnix which has not kexec service now. > > > Is there any problem when use systemctl kexec? If you have more details, > > > please let me know. > > If you use systemctl kexec, the first part of kexec is the same as a > > normal reboot/poweroff. So, there is no reason that reboot/poweroff is > > bad but kexec is good. > > Then, Bjorn, what is the best solution now? It seems like my first > > version is OK (commit messages should be improved, of course). > > Sorry, there are too many conversations going on for me to keep track > of what first version you're referring to. Please include a specific > lore.kernel.org URL. My first version means this one: https://patchwork.kernel.org/patch/11695929/ Thanks, Huacai > > Bjorn