From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7227EC47426 for ; Wed, 30 Sep 2020 17:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08F332087D for ; Wed, 30 Sep 2020 17:11:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sE8WZ6lf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730893AbgI3RLB (ORCPT ); Wed, 30 Sep 2020 13:11:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgI3RLB (ORCPT ); Wed, 30 Sep 2020 13:11:01 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D657DC0613D1 for ; Wed, 30 Sep 2020 10:11:00 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id qp15so3006328ejb.3 for ; Wed, 30 Sep 2020 10:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BqedzlGX8MsdvOmncyCbTeaSpoiIv6tQfCYOfAGCm1I=; b=sE8WZ6lfb33YbXSwicY08Buxu2+BclRjKlsf3vmfKYC0cOkGjIdkfWlcD3vKlvxBtD oJvOI0Me7W22ashUodxRg8si+zJpy2Cbj36q0/8yWyYhzL0LsEuNIm7mCi4bt0ydDxiP q2wgS9BmhahiQ+5AI274iqgwQFVzecBus9MZf563ErBkJT7H8HSacjGdi407Qm2FFScB UKBxyo4CmvhG4OhR92jBXUX4a8bOh0QyXvaZZAv6dW3JDWi42Xlo+4DGLRhZ05mHElhm akH0k3vLqe2e1OlNqWiJM/8E0bIvbsaLFvn/nLJrGgZiuIkxYeAIludqN2wsfPhdmkyE UahA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BqedzlGX8MsdvOmncyCbTeaSpoiIv6tQfCYOfAGCm1I=; b=KMNugwRLHRjf0EhQXFfvodduMuWBdzqqYqYV1l/sQZoYC5yPXxnZ73ndhKYXvjD5vF 3iF5dd06p5tioDAn7R/Xh2IMtDrxPhD0tZvQd33IOM5ZT7un05OrOuh6Umm1xH8t4fgw 8uMuXXXn1kVkuaXJZzh4vJYuWmftA2iKigvvYQHRkiTpWvV5ssXgqashFFJXXjE3i6z7 ilTJ7a8TgTj2qb6wm30soLAo32DSQZzbjfE2UTtEGoGKXnKxqUh75igOVhhhOFXmDsIS usTtFxI2iJP3Y9onSifYOcHCmO0uNvU6KF4VzXMyrchEK2rK4pvV5DqAA/2K3bSvq7o6 mxlg== X-Gm-Message-State: AOAM5327ooIeTUGR8uJWnvW7tAWSakP+mU6SW3dk/NVLHerfPTqB53X0 Vlm9iyGMh7pcP5JqAM0TSNpYGo9D/DgW9Jjt+Tj2sg== X-Google-Smtp-Source: ABdhPJxx5zeY+5dc3dMhmlhIH9uf8zM/HMP0iLgIAwPYaEmmMHjXLZ0lmUCgiQV067mtUVMz2xbTNNo7KUcZkaJ7L2A= X-Received: by 2002:a17:906:a256:: with SMTP id bi22mr3767975ejb.375.1601485859067; Wed, 30 Sep 2020 10:10:59 -0700 (PDT) MIME-Version: 1.0 References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-10-samitolvanen@google.com> <20200930095850.GA68612@C02TD0UTHF1T.local> In-Reply-To: <20200930095850.GA68612@C02TD0UTHF1T.local> From: Sami Tolvanen Date: Wed, 30 Sep 2020 10:10:47 -0700 Message-ID: Subject: Re: [PATCH v4 09/29] arm64: disable recordmcount with DYNAMIC_FTRACE_WITH_REGS To: Mark Rutland Cc: Masahiro Yamada , Will Deacon , Steven Rostedt , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , linux-arm-kernel , linux-kbuild , LKML , linux-pci@vger.kernel.org, X86 ML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Mark, On Wed, Sep 30, 2020 at 2:59 AM Mark Rutland wrote: > > Hi Sami, > > On Tue, Sep 29, 2020 at 02:46:11PM -0700, Sami Tolvanen wrote: > > Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to disable > > recordmcount when DYNAMIC_FTRACE_WITH_REGS is selected. > > Could you please add an explanation as to /why/ this is necessary in the > commit message? I couldn't figure this out form the commit message > alone, and reading the cover letter also didn't help. Sorry about that, I'll add a better explanation in the next version. Note that without LTO, this change is not strictly necessary as there's no harm in running recordmcount even if it's not needed. It might slow down the build slightly, but I suspect a few thousand invocations of the program won't take that long. However, with LTO we need to disable recordmcount because it doesn't understand LLVM bitcode. > If the minimum required GCC version supports patchable-function-entry > I'd be happy to make that a requirement for dynamic ftrace on arm64, as > then we'd only need to support one mechanism, and can get rid of some > redundant code. We already default to it when present anyhow. That would be great, but Documentation/process/changes.rst suggests the minimum gcc version is 4.9, and according to Godbolt we would need gcc >= 8 for -fpatchable-function-entry: https://godbolt.org/z/jdzcMW > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 6d232837cbee..ad522b021f35 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -155,6 +155,8 @@ config ARM64 > > select HAVE_DYNAMIC_FTRACE > > select HAVE_DYNAMIC_FTRACE_WITH_REGS \ > > if $(cc-option,-fpatchable-function-entry=2) > > + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY \ > > + if DYNAMIC_FTRACE_WITH_REGS > > This doesn't look quite right to me. Presumably we shouldn't allow > DYNAMIC_FTRACE_WITH_REGS to be selected if HAVE_DYNAMIC_FTRACE_WITH_REGS > isn't. This won't allow DYNAMIC_FTRACE_WITH_REGS to be selected without HAVE_DYNAMIC_FTRACE_WITH_REGS. Testing with a compiler that does support -fpatchable-function-entry, I get the following, as expected: $ grep -E '(DYNAMIC_FTRACE|MCOUNT_USE)' .config CONFIG_HAVE_DYNAMIC_FTRACE=y CONFIG_HAVE_DYNAMIC_FTRACE_WITH_REGS=y CONFIG_DYNAMIC_FTRACE=y CONFIG_DYNAMIC_FTRACE_WITH_REGS=y CONFIG_FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY=y And if the compiler doesn't support -fpatchable-function-entry, we would end up with the following: $ grep -E '(DYNAMIC_FTRACE|MCOUNT_USE)' .config CONFIG_HAVE_DYNAMIC_FTRACE=y CONFIG_DYNAMIC_FTRACE=y CONFIG_FTRACE_MCOUNT_USE_RECORDMCOUNT=y Sami