Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Srinath Mannam <srinath.mannam@broadcom.com>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ray Jui <ray.jui@broadcom.com>
Subject: Re: [PATCH v3 2/6] PCI: iproc: Add INTx support with better modeling
Date: Fri, 6 Dec 2019 15:14:11 +0530
Message-ID: <CABe79T6vAQdk1BQ=yGScJ3F5Xd8qFEbaCiTw29kFoyhrZDLZkQ@mail.gmail.com> (raw)
In-Reply-To: <20191203155514.GE18399@e119886-lin.cambridge.arm.com>

On Tue, Dec 3, 2019 at 9:25 PM Andrew Murray <andrew.murray@arm.com> wrote:
>
> On Tue, Dec 03, 2019 at 10:27:02AM +0530, Srinath Mannam wrote:
> > From: Ray Jui <ray.jui@broadcom.com>
> >
> > Add PCIe legacy interrupt INTx support to the iProc PCIe driver by
> > modeling it with its own IRQ domain. All 4 interrupts INTA, INTB, INTC,
> > INTD share the same interrupt line connected to the GIC in the system,
> > while the status of each INTx can be obtained through the INTX CSR
> > register
> >
> > Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> > ---
> >  drivers/pci/controller/pcie-iproc.c | 100 +++++++++++++++++++++++++++++++++++-
> >  drivers/pci/controller/pcie-iproc.h |   6 +++
> >  2 files changed, 104 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> > index 2d457bf..e90c22e 100644
> > --- a/drivers/pci/controller/pcie-iproc.c
> > +++ b/drivers/pci/controller/pcie-iproc.c
> > @@ -14,6 +14,7 @@
> >  #include <linux/delay.h>
> >  #include <linux/interrupt.h>
> >  #include <linux/irqchip/arm-gic-v3.h>
> > +#include <linux/irqchip/chained_irq.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/of_address.h>
> >  #include <linux/of_pci.h>
> > @@ -270,6 +271,7 @@ enum iproc_pcie_reg {
> >
> >       /* enable INTx */
> >       IPROC_PCIE_INTX_EN,
> > +     IPROC_PCIE_INTX_CSR,
> >
> >       /* outbound address mapping */
> >       IPROC_PCIE_OARR0,
> > @@ -314,6 +316,7 @@ static const u16 iproc_pcie_reg_paxb_bcma[] = {
> >       [IPROC_PCIE_CFG_ADDR]           = 0x1f8,
> >       [IPROC_PCIE_CFG_DATA]           = 0x1fc,
> >       [IPROC_PCIE_INTX_EN]            = 0x330,
> > +     [IPROC_PCIE_INTX_CSR]           = 0x334,
> >       [IPROC_PCIE_LINK_STATUS]        = 0xf0c,
> >  };
> >
> > @@ -325,6 +328,7 @@ static const u16 iproc_pcie_reg_paxb[] = {
> >       [IPROC_PCIE_CFG_ADDR]           = 0x1f8,
> >       [IPROC_PCIE_CFG_DATA]           = 0x1fc,
> >       [IPROC_PCIE_INTX_EN]            = 0x330,
> > +     [IPROC_PCIE_INTX_CSR]           = 0x334,
> >       [IPROC_PCIE_OARR0]              = 0xd20,
> >       [IPROC_PCIE_OMAP0]              = 0xd40,
> >       [IPROC_PCIE_OARR1]              = 0xd28,
> > @@ -341,6 +345,7 @@ static const u16 iproc_pcie_reg_paxb_v2[] = {
> >       [IPROC_PCIE_CFG_ADDR]           = 0x1f8,
> >       [IPROC_PCIE_CFG_DATA]           = 0x1fc,
> >       [IPROC_PCIE_INTX_EN]            = 0x330,
> > +     [IPROC_PCIE_INTX_CSR]           = 0x334,
> >       [IPROC_PCIE_OARR0]              = 0xd20,
> >       [IPROC_PCIE_OMAP0]              = 0xd40,
> >       [IPROC_PCIE_OARR1]              = 0xd28,
> > @@ -846,9 +851,95 @@ static int iproc_pcie_check_link(struct iproc_pcie *pcie)
> >       return link_is_active ? 0 : -ENODEV;
> >  }
> >
> > -static void iproc_pcie_enable(struct iproc_pcie *pcie)
> > +static int iproc_pcie_intx_map(struct irq_domain *domain, unsigned int irq,
> > +                            irq_hw_number_t hwirq)
> >  {
> > +     irq_set_chip_and_handler(irq, &dummy_irq_chip, handle_simple_irq);
> > +     irq_set_chip_data(irq, domain->host_data);
> > +
> > +     return 0;
> > +}
> > +
> > +static const struct irq_domain_ops intx_domain_ops = {
> > +     .map = iproc_pcie_intx_map,
> > +};
> > +
> > +static void iproc_pcie_isr(struct irq_desc *desc)
> > +{
> > +     struct irq_chip *chip = irq_desc_get_chip(desc);
> > +     struct iproc_pcie *pcie;
> > +     struct device *dev;
> > +     unsigned long status;
> > +     u32 bit, virq;
> > +
> > +     chained_irq_enter(chip, desc);
> > +     pcie = irq_desc_get_handler_data(desc);
> > +     dev = pcie->dev;
> > +
> > +     /* go through INTx A, B, C, D until all interrupts are handled */
> > +     do {
> > +             status = iproc_pcie_read_reg(pcie, IPROC_PCIE_INTX_CSR);
>
> By performing this read once and outside of the do/while loop you may improve
> performance. I wonder how probable it is to get another INTx whilst handling
> one?
>
>
> > +             for_each_set_bit(bit, &status, PCI_NUM_INTX) {
> > +                     virq = irq_find_mapping(pcie->irq_domain, bit);
> > +                     if (virq)
> > +                             generic_handle_irq(virq);
> > +                     else
> > +                             dev_err(dev, "unexpected INTx%u\n", bit);
> > +             }
> > +     } while ((status & SYS_RC_INTX_MASK) != 0);
> > +
> > +     chained_irq_exit(chip, desc);
> > +}
> > +
> > +static int iproc_pcie_intx_enable(struct iproc_pcie *pcie)
> > +{
> > +     struct device *dev = pcie->dev;
> > +     struct device_node *node;
> > +     int ret;
> > +
> >       iproc_pcie_write_reg(pcie, IPROC_PCIE_INTX_EN, SYS_RC_INTX_MASK);
> > +     /*
> > +      * BCMA devices do not map INTx the same way as platform devices. All
> > +      * BCMA needs is the above code to enable INTx
> > +      */
>
> NIT: Move this comment above the line of code?
I will change in the next patch set.
>
>
> > +
> > +     node = of_get_compatible_child(dev->of_node, "brcm,iproc-intc");
>
> As the interrupt controller is built into the PCI controller, what is the
> rationale for representing this as a separate device tree device?
In patchset v1, PCIe controller was taken as interrupt controller
which is not correct.
So that, separate DT node was taken, based on comments below link.
https://lore.kernel.org/linux-pci/CAL_Jsq+ac6dmHKS6m0h5N3bv=VseKVL8XLU5K7j1Rn=mgFNLsA@mail.gmail.com/
>
> Thanks,
>
> Andrew Murray
>
> > +     if (node)
> > +             pcie->irq = of_irq_get(node, 0);
> > +
> > +     if (!node || pcie->irq <= 0)
> > +             return 0;
> > +
> > +     /* set IRQ handler */
> > +     irq_set_chained_handler_and_data(pcie->irq, iproc_pcie_isr, pcie);
> > +
> > +     /* add IRQ domain for INTx */
> > +     pcie->irq_domain = irq_domain_add_linear(node, PCI_NUM_INTX,
> > +                                              &intx_domain_ops, pcie);
> > +     if (!pcie->irq_domain) {
> > +             dev_err(dev, "failed to add INTx IRQ domain\n");
> > +             ret = -ENOMEM;
> > +             goto err_rm_handler_data;
> > +     }
> > +
> > +     return 0;
> > +
> > +err_rm_handler_data:
> > +     of_node_put(node);
> > +     irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
> > +
> > +     return ret;
> > +}
> > +
> > +static void iproc_pcie_intx_disable(struct iproc_pcie *pcie)
> > +{
> > +     iproc_pcie_write_reg(pcie, IPROC_PCIE_INTX_EN, 0x0);
> > +
> > +     if (pcie->irq <= 0)
> > +             return;
> > +
> > +     irq_domain_remove(pcie->irq_domain);
> > +     irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
> >  }
> >
> >  static inline bool iproc_pcie_ob_is_valid(struct iproc_pcie *pcie,
> > @@ -1537,7 +1628,11 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)
> >               goto err_power_off_phy;
> >       }
> >
> > -     iproc_pcie_enable(pcie);
> > +     ret = iproc_pcie_intx_enable(pcie);
> > +     if (ret) {
> > +             dev_err(dev, "failed to enable INTx\n");
> > +             goto err_power_off_phy;
> > +     }
> >
> >       if (IS_ENABLED(CONFIG_PCI_MSI))
> >               if (iproc_pcie_msi_enable(pcie))
> > @@ -1582,6 +1677,7 @@ int iproc_pcie_remove(struct iproc_pcie *pcie)
> >       pci_remove_root_bus(pcie->root_bus);
> >
> >       iproc_pcie_msi_disable(pcie);
> > +     iproc_pcie_intx_disable(pcie);
> >
> >       phy_power_off(pcie->phy);
> >       phy_exit(pcie->phy);
> > diff --git a/drivers/pci/controller/pcie-iproc.h b/drivers/pci/controller/pcie-iproc.h
> > index 4f03ea5..103e568 100644
> > --- a/drivers/pci/controller/pcie-iproc.h
> > +++ b/drivers/pci/controller/pcie-iproc.h
> > @@ -74,6 +74,9 @@ struct iproc_msi;
> >   * @ib: inbound mapping related parameters
> >   * @ib_map: outbound mapping region related parameters
> >   *
> > + * @irq: interrupt line wired to the generic GIC for INTx
> > + * @irq_domain: IRQ domain for INTx
> > + *
> >   * @need_msi_steer: indicates additional configuration of the iProc PCIe
> >   * controller is required to steer MSI writes to external interrupt controller
> >   * @msi: MSI data
> > @@ -102,6 +105,9 @@ struct iproc_pcie {
> >       struct iproc_pcie_ib ib;
> >       const struct iproc_pcie_ib_map *ib_map;
> >
> > +     int irq;
> > +     struct irq_domain *irq_domain;
> > +
> >       bool need_msi_steer;
> >       struct iproc_msi *msi;
> >  };
> > --
> > 2.7.4
> >

  parent reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  4:57 [PATCH v3 0/6] PAXB INTx support with proper model Srinath Mannam
2019-12-03  4:57 ` [PATCH v3 1/6] dt-bindings: pci: Update iProc PCI binding for INTx support Srinath Mannam
2019-12-03 19:19   ` Rob Herring
2019-12-03  4:57 ` [PATCH v3 2/6] PCI: iproc: Add INTx support with better modeling Srinath Mannam
2019-12-03 15:55   ` Andrew Murray
2019-12-03 19:27     ` Andy Shevchenko
2019-12-03 22:09       ` Ray Jui
2019-12-04  8:29         ` Andy Shevchenko
2019-12-04 16:07           ` Andrew Murray
2019-12-04 18:36             ` Ray Jui
2019-12-06  9:44     ` Srinath Mannam [this message]
2019-12-03  4:57 ` [PATCH v3 3/6] arm: dts: Change PCIe INTx mapping for Cygnus Srinath Mannam
2019-12-03  4:57 ` [PATCH v3 4/6] arm: dts: Change PCIe INTx mapping for NSP Srinath Mannam
2019-12-03  4:57 ` [PATCH v3 5/6] arm: dts: Change PCIe INTx mapping for HR2 Srinath Mannam
2019-12-03  4:57 ` [PATCH v3 6/6] arm64: dts: Change PCIe INTx mapping for NS2 Srinath Mannam

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABe79T6vAQdk1BQ=yGScJ3F5Xd8qFEbaCiTw29kFoyhrZDLZkQ@mail.gmail.com' \
    --to=srinath.mannam@broadcom.com \
    --cc=andrew.murray@arm.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=ray.jui@broadcom.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git