From: Rajat Jain <rajatja@google.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Frederick Lawler <fred@fredlawl.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3/3] PCI/ASPM: add sysfs attribute for controlling ASPM
Date: Tue, 20 Aug 2019 13:55:10 -0700 [thread overview]
Message-ID: <CACK8Z6ECUwnupMZtY3fyM46za-7WZyJNQYYEFchUWLDsgOMbvA@mail.gmail.com> (raw)
In-Reply-To: <20190820204845.GD14450@google.com>
On Tue, Aug 20, 2019 at 1:48 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Tue, Aug 20, 2019 at 12:51:09PM -0700, Rajat Jain wrote:
> >
> > May be we're digressing now, but I'd like to point out that there is
> > atleast one more file in ASPM that potentially violates the "1 value
> > per file" rule:
> >
> > rajatja@rajat2:/sys/module/pcie_aspm/parameters$ cat policy
> > [default] performance powersave powersupersave
> > rajatja@rajat2:/sys/module/pcie_aspm/parameters$
> >
> > ... although I would argue in this case that it makes it much clear
> > what are the allowable values to write, and which is the current
> > selected one.
>
> Huh, that's a good point. That "policy" file is a little problematic
> for several reasons, one being the config options
> (CONFIG_PCIEASPM_PERFORMANCE, CONFIG_PCIEASPM_POWERSAVE, etc) that
> lock a distro into some default choice.
>
> Maybe there's something we can do there, although there's legacy use
> to consider (there are a zillion web pages that document
> pcie_aspm/parameters/policy as a way to fix things), and it's
> certainly beyond the scope of *this* series.
Agreed!
>
> Bjorn
next prev parent reply other threads:[~2019-08-20 20:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 20:03 [PATCH 0/3] PCI/ASPM: add sysfs attribute for controlling ASPM Heiner Kallweit
2019-05-23 20:03 ` [PATCH 1/3] PCI/ASPM: add L1 sub-state support to pci_disable_link_state Heiner Kallweit
2019-05-23 20:04 ` [PATCH 2/3] PCI/ASPM: allow to re-enable Clock PM Heiner Kallweit
2019-05-23 20:05 ` [PATCH 3/3] PCI/ASPM: add sysfs attribute for controlling ASPM Heiner Kallweit
2019-08-20 10:34 ` Bjorn Helgaas
2019-08-20 17:05 ` Greg KH
2019-08-20 19:05 ` Rajat Jain
2019-08-20 19:32 ` Bjorn Helgaas
2019-08-20 19:51 ` Rajat Jain
2019-08-20 20:48 ` Bjorn Helgaas
2019-08-20 20:55 ` Rajat Jain [this message]
2019-07-01 20:07 ` [PATCH 0/3] " Heiner Kallweit
2019-07-10 6:59 ` AceLan Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACK8Z6ECUwnupMZtY3fyM46za-7WZyJNQYYEFchUWLDsgOMbvA@mail.gmail.com \
--to=rajatja@google.com \
--cc=fred@fredlawl.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).