From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0220C433E0 for ; Fri, 26 Jun 2020 19:02:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C816E2053B for ; Fri, 26 Jun 2020 19:02:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PljCG4p1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725890AbgFZTCR (ORCPT ); Fri, 26 Jun 2020 15:02:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbgFZTCP (ORCPT ); Fri, 26 Jun 2020 15:02:15 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DDBDC03E979 for ; Fri, 26 Jun 2020 12:02:14 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id 9so11434171ljv.5 for ; Fri, 26 Jun 2020 12:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CupTv356WOheWFFcn47AA78Bc8xE85sorZq/DL/d5ow=; b=PljCG4p1Fw8CHLh+rUo2wSWaKZbvtTK+SH69StUSy72aY4d1OYyiZUq/AaW6a5d1MI mq7+P723mcxuKFZJ5YT7j2sJC2nDwAp1KAMuq5VMYdluPT75VMQ3W97a14UhUtX4a1Q2 Y7Br1N0WDugVyuoC8lYZ/SyVf6EN373Kqez82pnoO4DMI2ZgGgU2GH+Ppuhy6J6g/YUt 1XpiIuatKtMKTEm14jT7CRjJOtuvbAALQKYB80RhD2Byety+zKHXncWQo4dJsh1SQeMA nSqGNi15sCpqApCXfW8JO5PL/hkt8la90/o6M5m9jJhBWq0yG5p6KMs8op0c3aNYsphn 8wzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CupTv356WOheWFFcn47AA78Bc8xE85sorZq/DL/d5ow=; b=E/uyPEyxfOpi3+nSgSm/kZuk3muB5GRDX1x9mHPSkzzIRBJaCADne2/+x0as5gnrKB uM9O01wXqWktiPJTKJ07kPvQ1CAvkm5D62sZsO9iz1Fwl70lWnFLjqb7firoAYive2q6 TwsCsf7m3xyo6K0E+1/+kzQwcQCCsZsMLt8nRqwL2Xt55BpeBjeZGgHF+eakWWDWSD1v 1P0bETyDrwuMOobtazw9cLd+/oLCcSjxF3EKw6Ddf3tX1yfoXqibuFBB2kbX41lo8wDy miKzDNGMISA/z/T/crxug1LNbT/1JPD9gYnJ4TAfDbn1IOd/M0IM1AVhztjYl6VTvPjt yARw== X-Gm-Message-State: AOAM533KonAKwCrXU63C058LStJULhWFy6IahIdkBTkppjREFP4Y1s4E 64SIj1MWgrnrwo1C9qKuVXJKp9GZQd2mSwDM53gynQ== X-Google-Smtp-Source: ABdhPJwXqAgY35bZFXo6/B0G8JpMwZbJM19I1mNnWaLF8LNBfGwBsVegK/WyraehTX79S8Hc7skGI2IKEUUkez0pahs= X-Received: by 2002:a2e:92cf:: with SMTP id k15mr2200496ljh.333.1593198132811; Fri, 26 Jun 2020 12:02:12 -0700 (PDT) MIME-Version: 1.0 References: <20200626002710.110200-1-rajatja@google.com> <20200626153906.GA2897118@bjorn-Precision-5520> In-Reply-To: <20200626153906.GA2897118@bjorn-Precision-5520> From: Rajat Jain Date: Fri, 26 Jun 2020 12:01:36 -0700 Message-ID: Subject: Re: [PATCH 1/2] pci: Add pci device even if the driver failed to attach To: Bjorn Helgaas Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , iommu@lists.linux-foundation.org, Linux Kernel Mailing List , linux-pci , ACPI Devel Maling List , Raj Ashok , "Krishnakumar, Lalithambika" , Mika Westerberg , Jean-Philippe Brucker , Prashant Malani , Benson Leung , Todd Broch , Alex Levin , Mattias Nissler , Rajat Jain , Bernie Keany , Aaron Durbin , Diego Rivas , Duncan Laurie , Furquan Shaikh , Jesse Barnes , Christian Kellner , Alex Williamson , Greg Kroah-Hartman , "Oliver O'Halloran" Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jun 26, 2020 at 8:39 AM Bjorn Helgaas wrote: > > Nit: when you update these patches, can you run "git log --oneline > drivers/pci/bus.c" and make your subject lines match the convention? Sorry, will do. > E.g., > > PCI: Add device even if driver attach failed > > On Thu, Jun 25, 2020 at 05:27:09PM -0700, Rajat Jain wrote: > > device_attach() returning failure indicates a driver error > > while trying to probe the device. In such a scenario, the PCI > > device should still be added in the system and be visible to > > the user. > > Nit: please wrap logs to fill 75 characters. "git log" adds 4 spaces > at the beginning, so 75+4 still fits nicely in 80 columns without > wrapping. Sorry, will do. > > > This patch partially reverts: > > commit ab1a187bba5c ("PCI: Check device_attach() return value always") > > > > Signed-off-by: Rajat Jain > > --- > > drivers/pci/bus.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c > > index 8e40b3e6da77d..3cef835b375fd 100644 > > --- a/drivers/pci/bus.c > > +++ b/drivers/pci/bus.c > > @@ -322,12 +322,8 @@ void pci_bus_add_device(struct pci_dev *dev) > > > > dev->match_driver = true; > > retval = device_attach(&dev->dev); > > - if (retval < 0 && retval != -EPROBE_DEFER) { > > + if (retval < 0 && retval != -EPROBE_DEFER) > > pci_warn(dev, "device attach failed (%d)\n", retval); > > - pci_proc_detach_device(dev); > > - pci_remove_sysfs_dev_files(dev); > > Thanks for catching my bug! > > > - return; > > - } > > > > pci_dev_assign_added(dev, true); > > } > > -- > > 2.27.0.212.ge8ba1cc988-goog > >