From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC3D2C433EF for ; Wed, 20 Apr 2022 23:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344735AbiDTX1v (ORCPT ); Wed, 20 Apr 2022 19:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380061AbiDTX1u (ORCPT ); Wed, 20 Apr 2022 19:27:50 -0400 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51D1013E23 for ; Wed, 20 Apr 2022 16:25:03 -0700 (PDT) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-2eafabbc80aso34822417b3.11 for ; Wed, 20 Apr 2022 16:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=faX+8xEq5cxeln2IAgBzOZYC6emkLLqmLHlpGzsrZsI=; b=IdysWrk64gPASP4iboMXdeQr8OBqMtOScTiocxTj/PrXpZ3MpyJ7PLa30ylu64mytC dNZJ48LUjpecPRUYztsGI+HRaMLrBaDd/kcZaLV36ygFMFvmDY057Y+HEiWLnX8GNMwh zze4Y1X6WoKVDIaAGotw8iPC/K8l1onAsVljpkbYO8mFC4YRPbjpiKuiKdaF631UerU7 ti+4EtfpHTfW3DMrUIqjmE+KiLWxhORMBfjPtP60A/UoWuR7wTx2P7q+WOBQloAXxCtG qRwDmPi3kFPBahDbTJXN2rIts8IFZDSrsrgjbq8RbD36cnyF6n/kd7e/lTwEP0I1lCt6 WPMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=faX+8xEq5cxeln2IAgBzOZYC6emkLLqmLHlpGzsrZsI=; b=tkq/OOWFR35F6Ku5qowLaOadQsEJ9w8fV1hD4AnMhnmCOr6RuZIiYYNpW8aqgD+G+E 3PagNzbx0OibfWfgrJF6ncjI23hlH6C7zvpPdjAixD1Lt0Ykl2CMPIRNefP1Bz92ah8l W4NTpJbWDCEKyANbY6ONdb6hAMYp2PN9bVVqnKkDOmUuxAu9JJ8NVNoB29h/b5Nwi911 MLxF5c1aYRs2bGOC95iH/nWoFPx9lDaD4YLMl9ojPKhWe7pq7zfnAAJuUj5psOgrhASX toYmP9YnhhAJ2uLZCcdx/VT5XpfEm7k3MHUlx1oAZVR/Mua++uRZtHhjSrA/6mmA8ULW UkLA== X-Gm-Message-State: AOAM531PFqkw2vguOg89Kp5uVAYEgfD3DnpArc11aivXESTSMzVjSnta U59Z0FHlisH+2phyBAG+xz3c+7ABwoxnmf3Fv7Hqew== X-Google-Smtp-Source: ABdhPJza/ohc+w9rdaX0OxSl3QRR+W9TuPshb4dunNAUPl5XzezXZp8QbAzXuRYReRzLiYb+1tYgVyY2qzk5SSpHy3I= X-Received: by 2002:a81:2154:0:b0:2f4:d79e:35dc with SMTP id h81-20020a812154000000b002f4d79e35dcmr227895ywh.126.1650497102573; Wed, 20 Apr 2022 16:25:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Thu, 21 Apr 2022 01:24:51 +0200 Message-ID: Subject: Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Cc: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, helgaas@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Maira and sorry for being slow on reviews. On Tue, Nov 2, 2021 at 2:04 AM Ma=C3=ADra Canal wrote: > - gpio_set_value_cansleep(imx6_pcie->reset_gpio, > + gpiod_set_raw_value_cansleep(imx6_pcie->reset_gpio, > !imx6_pcie->gpio_active_high); Hm I see you got advised to use the raw api. I'm not so sure about that I like v1 better. > + imx6_pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", > + imx6_pcie->gpio_active_high ? GPIOD_OUT_HIGH : G= PIOD_OUT_LOW); > + if (IS_ERR(imx6_pcie->reset_gpio)) > + return dev_err_probe(dev, PTR_ERR(imx6_pcie->reset_gpio), > + "unable to get reset gpio\n"); Where is this descriptor coming from? Device trees? Can't we just fix the DTS file(s) in that case given how wrong they are if they don't set GPIO_ACTIVE_LOW flag on this IRQ. Yours, Linus Walleij