linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci <linux-pci@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Imre Kaloz <kaloz@openwrt.org>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Zoltan HERPAI <wigyori@uid0.hu>,
	Raylynn Knight <rayknight@me.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	"John W. Linville" <linville@redhat.com>
Subject: Re: [PATCH v6] PCI: ixp4xx: Add a new driver for IXP4xx
Date: Thu, 17 Jun 2021 11:42:04 +0200	[thread overview]
Message-ID: <CACRpkdZJTnrRwaDk+FB2Pzsytz0My0C+SdxdYjTn5YENQP5UoQ@mail.gmail.com> (raw)
In-Reply-To: <20210616151953.GA2973960@bjorn-Precision-5520>

Hi Bjorn,

thanks for your help!

On Wed, Jun 16, 2021 at 5:19 PM Bjorn Helgaas <helgaas@kernel.org> wrote:

> I'm a little sorry to merge a driver that isn't as functional as the
> old one, but I guess this doesn't actually *remove* the old one yet.
> Maybe the Kconfig help should reference the other driver with a hint
> about this case?  I hate for some user that uses the 1GB of space to
> switch to the new improved driver and see breakage without a hint
> about what happened.

I have tried to find these users but it seems they do not exist.
users need to set IXP4XX_INDIRECT_PCI to make use of it
and the only existing userspace for IXP4XX is OpenWrt and
they do not enable this.

Krzysztof Halasa talks about using it for a VGA card at one
point:
https://lore.kernel.org/linux-arm-kernel/m37edwuv8m.fsf@t19.piap.pl/

The plan is to locate these users (if I can) and in case they
need this use an idea from Linville for indirect PCI access,
if they can provide testing (I have nothing to test on
unfortunately...) I can't find Linville's patch right now but Arnd
pointed it out to me.

I fixed all the other comments in my tree.

Yours,
Linus Walleij

  reply	other threads:[~2021-06-17  9:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 23:24 [PATCH v6] PCI: ixp4xx: Add a new driver for IXP4xx Linus Walleij
2021-06-16 13:10 ` Linus Walleij
2021-06-16 15:15   ` Bjorn Helgaas
2021-06-16 15:19 ` Bjorn Helgaas
2021-06-17  9:42   ` Linus Walleij [this message]
2021-06-17 10:45     ` Krzysztof Hałasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZJTnrRwaDk+FB2Pzsytz0My0C+SdxdYjTn5YENQP5UoQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=kaloz@openwrt.org \
    --cc=khalasa@piap.pl \
    --cc=linux-pci@vger.kernel.org \
    --cc=linville@redhat.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=rayknight@me.com \
    --cc=wigyori@uid0.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).