From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214A7C433ED for ; Mon, 17 May 2021 23:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05B81611BE for ; Mon, 17 May 2021 23:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344611AbhEQX6x (ORCPT ); Mon, 17 May 2021 19:58:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239176AbhEQX6w (ORCPT ); Mon, 17 May 2021 19:58:52 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAD1FC061573 for ; Mon, 17 May 2021 16:57:32 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id f12so9357505ljp.2 for ; Mon, 17 May 2021 16:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Z0qUZGfT26ITfIbWe5iIQjL/DVVaqMgfxDEgws9kkSk=; b=Ah/L26KR2XPquHyuahWpR873usJ1ASZQo3dbOp0U9G424EAniTpdty05hu28QHrHKO hiHx8RdVGCFJ5V3KJeXMh3vVxqiGhov9zN0/X0lk/FhR+jPDqXx/VsrtNUt5/yF2l5ow DmVtm33Qk1dra3kupQQaB6J/DR8CtuOkXcA/uQpLsoo2F/mt2cGE6rOcylfudD4hHiaQ i24Fg5zOEcVi6qZSCE0Yh9ahdpGP/7AZlNpJ7PXVxjDbwy0xTDhhLrJOjXE6AHDoCNNs 5HGk0JtSqmPPfkwcuNaLVaWcUNHd33HXSVI+RsNw+9CAGZH2ZVBMY0aAlOTq7pSWPoYf bj2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z0qUZGfT26ITfIbWe5iIQjL/DVVaqMgfxDEgws9kkSk=; b=mZLTZNMxbBKQlAJCegucVAxYsz0352fbJfpLtbcO6H80Pqz8cL90JoAme8Jntud2wA JnCTOwLCg+ZIufn/UZChIUqZ8DpqGBKFWEiJJwBTggFzIhZnm7Coaa6kpfdxet0atyyE Fi1Iu2vFLOhAOoA4a4//VwHq2qeuQQC4iqBwGruACUlTxrIfYpwc7L9fhlli29Mu+zAA X1GsG9f8LqV8uHO6gN1fOg3gZqqxD2myhlzsiF4uIKlXuIpAHiht9DHb+4TNn2HLI6gA pUWdZSNfWJ14hs9LC6DFEkJcoeBMQa5xeOjKaTClLu+TuMILSy5gMvuU5PFqo8zX4hIy Idqg== X-Gm-Message-State: AOAM533CpOlx8vJGiqdruDhY1yOUfrWNYwollOPTPxTb/KwYdyuh2wW/ 6tlPwUvaN05ouBNyNE4bYk7vfgssTR12CIeAK2RH8g== X-Google-Smtp-Source: ABdhPJy+6bXS2bIIKWnuU1MLzKml8LidyaBLX/xVVZdX+UIT/sHYVGWk2dH/bkRSf45nwwwObsfzXCXzDOUn3cDLOBA= X-Received: by 2002:a2e:814d:: with SMTP id t13mr1598888ljg.467.1621295851449; Mon, 17 May 2021 16:57:31 -0700 (PDT) MIME-Version: 1.0 References: <20210517234117.3660-1-rdunlap@infradead.org> In-Reply-To: <20210517234117.3660-1-rdunlap@infradead.org> From: Linus Walleij Date: Tue, 18 May 2021 01:57:20 +0200 Message-ID: Subject: Re: [PATCH v2] PCI: ftpci100: rename macro name collision To: Randy Dunlap Cc: linux-pci , kernel test robot , Jiaxun Yang , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Thomas Bogendoerfer , linux-mips@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, May 18, 2021 at 1:41 AM Randy Dunlap wrote: > PCI_IOSIZE is defined in mach-loongson64/spaces.h, so change the name > of the PCI_* macros in pci-ftpci100.c to use FTPCI_* so that they are > more localized and won't conflict with other drivers or arches. > > ../drivers/pci/controller/pci-ftpci100.c:37: warning: "PCI_IOSIZE" redefi= ned > 37 | #define PCI_IOSIZE 0x00 > | > In file included from ../arch/mips/include/asm/addrspace.h:13, > ... from ../drivers/pci/controller/pci-ftpci100.c:15: > arch/mips/include/asm/mach-loongson64/spaces.h:11: note: this is the loca= tion of the previous definition > 11 | #define PCI_IOSIZE SZ_16M > > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Suggested-by: Linus Walleij > Cc: Jiaxun Yang > Cc: Linus Walleij > Cc: Krzysztof Wilczy=C5=84ski > Cc: Thomas Bogendoerfer > Cc: linux-mips@vger.kernel.org > --- > v2: prefix PCI_ macro names with "FT", thus use FTPCI_ for these macro na= mes. > (suggested by Linus Walleij) Reviewed-by: Linus Walleij Yours, Linus Walleij