From: Linus Walleij <linus.walleij@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: openwrt-devel@openwrt.org,
Florian Fainelli <f.fainelli@gmail.com>,
Paulius Zaleckas <paulius.zaleckas@gmail.com>,
linux-pci <linux-pci@vger.kernel.org>,
Hans Ulli Kroll <ulli.kroll@googlemail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Janos Laube <janos.dev@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] ARM: dts: add PCI to the Gemini DTSI
Date: Sat, 11 Feb 2017 12:17:17 +0100 [thread overview]
Message-ID: <CACRpkdah04ZaRU52Gr6L=qmW57N6XOgZeHYNDzB2GcSH+B3DXA@mail.gmail.com> (raw)
In-Reply-To: <3236035.PSA6VtheyS@wuerfel>
On Fri, Feb 10, 2017 at 4:40 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday, February 6, 2017 10:55:03 AM CET Hans Ulli Kroll wrote:
>>
>> from my IB 4220 sources.
>>
>> #define IRQ_PCI_INTA PCI_IRQ_OFFSET + 0
>> #ifndef CONFIG_DUAL_PCI
>> #define IRQ_PCI_INTB PCI_IRQ_OFFSET + 1
>> #define IRQ_PCI_INTC PCI_IRQ_OFFSET + 2
>> #define IRQ_PCI_INTD PCI_IRQ_OFFSET + 3
>> #else
>> #define IRQ_PCI_INTB 27
>> #define IRQ_PCI_INTC 28
>> #define IRQ_PCI_INTD 29
>> #endif
>>
>> CONFIG_DUAL_PCI is never used
>> IRQ_PCIB - IRQ_PCID or IRQ_PCI_INTB - IRQ_PCI_INTD are also never used.
>
> The source code that Linus quoted earlier had references to
> 'IRQ_PCI_INTA +n' though, which is basically the same thing.
There is essentially two versions of the IP block, one which has
a cascaded interrupt controller in the PCI host bridge, and one
named "dual PCI" that has dedicated IRQs for PCIA, B, C, D on
the primary interrupt controller.
I'll try to codify it into the driver so it's clear how this works on the
two variants.
I'm also pretty sure this is a faraday IP block and not something
from Storlink/Storm/Cortina, so I will rename the compatible strings
etc reflecting that.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-02-11 11:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 20:48 [PATCH 1/4] PCI: add DT bindings for Cortina Gemini PCI Host Bridge Linus Walleij
2017-01-28 20:48 ` [PATCH 2/4] PCI: add driver for Cortina Gemini " Linus Walleij
2017-01-31 0:37 ` Bjorn Helgaas
2017-02-26 19:42 ` Linus Walleij
2017-02-27 16:49 ` Bjorn Helgaas
2017-02-01 11:11 ` Arnd Bergmann
2017-02-04 18:43 ` Linus Walleij
2017-02-16 14:08 ` Arnd Bergmann
2017-02-18 14:05 ` Linus Walleij
2017-02-05 10:00 ` Hans Ulli Kroll
2017-02-05 14:36 ` Linus Walleij
2017-01-28 20:48 ` [PATCH 3/4] ARM: gemini: select MIGHT_HAVE_PCI Linus Walleij
2017-01-28 20:48 ` [PATCH 4/4] ARM: dts: add PCI to the Gemini DTSI Linus Walleij
2017-02-05 10:03 ` Hans Ulli Kroll
2017-02-05 15:00 ` Linus Walleij
2017-02-06 9:55 ` Hans Ulli Kroll
2017-02-10 15:40 ` Arnd Bergmann
2017-02-11 11:17 ` Linus Walleij [this message]
2017-01-31 0:31 ` [PATCH 1/4] PCI: add DT bindings for Cortina Gemini PCI Host Bridge Bjorn Helgaas
2017-02-01 20:00 ` Linus Walleij
2017-02-01 11:09 ` Arnd Bergmann
2017-02-05 14:44 ` Linus Walleij
2017-02-01 11:19 ` Arnd Bergmann
2017-02-05 14:56 ` Linus Walleij
2017-02-06 16:05 ` Arnd Bergmann
2017-02-01 16:02 ` Rob Herring
2017-02-01 20:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdah04ZaRU52Gr6L=qmW57N6XOgZeHYNDzB2GcSH+B3DXA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=janos.dev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=openwrt-devel@openwrt.org \
--cc=paulius.zaleckas@gmail.com \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).