From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06365C4332F for ; Sun, 1 May 2022 21:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376497AbiEAV7L (ORCPT ); Sun, 1 May 2022 17:59:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376274AbiEAV7K (ORCPT ); Sun, 1 May 2022 17:59:10 -0400 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 166A22E0A8 for ; Sun, 1 May 2022 14:55:43 -0700 (PDT) Received: by mail-yb1-xb33.google.com with SMTP id y2so23333490ybi.7 for ; Sun, 01 May 2022 14:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7rmKOmP5MkmzB6kYwqydPOY8Y/8AVOpHSwETVjiHA9I=; b=WAyuZryKlUvTJ6kmm5uy/jwqa15kiwrjusdIJ5eDuY3LzFArwiFBHppsGeFl93dGUA aRFZM3OGRe9/1ZsfBAGsNrxtq9VIqDWOo4wYESFLFR0W3DPEm0C8ARYo3KzTKrBTkijw r9Ri8TPuCaeRW63/lCZyBKuHyXD3oxSXHsAVra2RElgjum4GrMmy4OjAN3XpyQWy8TaO yhLZRuBdNh8ocwUvZOb/5JKSEUzIjBzxE7DFL06GDxVfT8sWPk2RvudjrEDKInmr1+w3 5mOCiOp/5riekUqXbLCnRgTzfgjOdBAs7UcD7j5V28WNlgR84z+jAMc7M2oX2RI1uoY9 cX6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7rmKOmP5MkmzB6kYwqydPOY8Y/8AVOpHSwETVjiHA9I=; b=YDLLovL/yYpAFflERZHXy/qfXJyxkCevJhrlmd0LF7WBxWUe1EgdyHd3OQ7jfi5SjO JxRkioU40WkbLuwdNy72lljRcYYZVhqISWf9sSXQvdLiCvWYZLvW9nNTZM56zuKW6KgN o6OzzV3gm5Yhqq71Z80fmxIlLOo1M0mGb+Byh3yXMamkEZy5HRjtjFXc9fW0F0YgvSvk +iGURMK5BpsIj+vWr65Cl0gxSV8eJzBBEi1cbizlN+2Vr37v+O/mfb03D/W8wyLMZHrD Cptjjc6vuIwHDx9v2HSd1TCAWToZjxkVPM2XdNQZELyVt7flD9wUhAIuVW5n3qY8jtAC 98aQ== X-Gm-Message-State: AOAM530MU/lwLSV/xIdECR1zJ0NrjEyBO8HoIckxckh/4G9YFKJKN3Cq Fz4Yfv/MYtQ1dwWV7mq3J8XPT1gvdGOCAMU56hzo9A== X-Google-Smtp-Source: ABdhPJxqR+wj7vzqumSDiGlciHIivrD/WScHz6GVJNOR1rgSzhxVA4VDvKDovYr4a2IaCgbibVBmgNfiIylUorU7RJY= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr8676157ybh.369.1651442142362; Sun, 01 May 2022 14:55:42 -0700 (PDT) MIME-Version: 1.0 References: <20220429135108.2781579-1-schnelle@linux.ibm.com> <20220429135108.2781579-19-schnelle@linux.ibm.com> In-Reply-To: From: Linus Walleij Date: Sun, 1 May 2022 23:55:31 +0200 Message-ID: Subject: Re: [RFC v2 10/39] gpio: add HAS_IOPORT dependencies To: William Breathitt Gray Cc: Niklas Schnelle , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Apr 29, 2022 at 5:37 PM William Breathitt Gray wrote: > On Fri, Apr 29, 2022 at 04:46:00PM +0200, Niklas Schnelle wrote: > > Good question. As far as I can see most (all?) of these have "select > > ISA_BUS_API" which is "def_bool ISA". Now "config ISA" seems to > > currently be repeated in architectures and doesn't have an explicit > > HAS_IOPORT dependency (it maybe should have one). But it does only make > > sense on architectures with HAS_IOPORT set. > > There is such a thing as ISA DMA, but you'll still need to initialize > the device via the IO Port bus first, so perhaps setting HAS_IOPORT for > "config ISA" is the right thing to do: all ISA devices are expected to > communicate in some way via ioport. Adding that dependency seems like the right solution to me. Yours, Linus Walleij