From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5B2C43334 for ; Wed, 8 Jun 2022 22:18:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236502AbiFHWR7 (ORCPT ); Wed, 8 Jun 2022 18:17:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232847AbiFHWR6 (ORCPT ); Wed, 8 Jun 2022 18:17:58 -0400 Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 448AD38BD1 for ; Wed, 8 Jun 2022 15:17:55 -0700 (PDT) Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-fe15832ce5so3293883fac.8 for ; Wed, 08 Jun 2022 15:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=sjggaWHpjbyPFtlZQEJUzFJDBjr7IqTMh+s2+xOurSk=; b=Dtey83E7P4XRafF2kgiWH0Nqj5Cu/jeuMmiOiioNWcp94xnELMeJ1RLV2iLC42j0Aw vCmjggpU3Yl6QpeWoegxYrh6J7IDD8XSIdZ2dxl8ayz6AqICySZnX6Thyqq1YqdkfE0I Q2WHDA+Oabqn8z0zRq7k93+lKjUbaR/QzPGB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=sjggaWHpjbyPFtlZQEJUzFJDBjr7IqTMh+s2+xOurSk=; b=cFo641k3z0ZQf5UAiany50DWyPbX8eNRlbxSkVdcdEDu1FCY80rs3vyWQ7gL2DI5SP 3AKlvtAjVXR5Jv7KmVPNkm+N/Dxr4SD8uTp6a9OCXOj3bBiWpX012/uUGhMoub3Q/PoI Mb6u+mbMf3uuHmWIvlhKF/yYUoVgBcT4ek/wvs0ESmjSKzQZnW22BR3mr2Qjm/8pfRE7 Cq69AdYKwWw/iUlL30xeED1RHC7HzQTbcmLYv3ZoFRgo4Bsqk9a+++CKsPeJYUNlx0E/ p1T1UslUyqIol9mHSZs0qmwN/Re6KCmq7wjc1DLT/8UBV9XtT9d/WuV7KL2mWj69Usen awgg== X-Gm-Message-State: AOAM531RUB2MPt7Q9Vcr9VerAFY3xlCuv2hhQLNf3svYSoMRfdSw+p09 J33vLg+djN7n53GqAHkWTe7mJjHo7kdmlxrsvZM9UA== X-Google-Smtp-Source: ABdhPJxjhinNFopJWfMD6r4u711h/8HphOSbID6Nj3U0jXyaNq7zLF2fz4Du5aIyA170mLwnTOdfDEPL4IFLBfactqI= X-Received: by 2002:a05:6870:b381:b0:fe:2004:b3b5 with SMTP id w1-20020a056870b38100b000fe2004b3b5mr93795oap.63.1654726674487; Wed, 08 Jun 2022 15:17:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 8 Jun 2022 15:17:54 -0700 MIME-Version: 1.0 In-Reply-To: <1654240730-31322-1-git-send-email-quic_krichai@quicinc.com> References: <1654240730-31322-1-git-send-email-quic_krichai@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Wed, 8 Jun 2022 15:17:54 -0700 Message-ID: Subject: Re: [PATCH v1] PCI: qcom: Allow L1 and its sub states on qcom dwc wrapper To: Krishna chaitanya chundru , helgaas@kernel.org Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_hemantk@quicinc.com, quic_ramkri@quicinc.com, manivannan.sadhasivam@linaro.org, Andy Gross , Bjorn Andersson , Stanimir Varbanov , Lorenzo Pieralisi , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Quoting Krishna chaitanya chundru (2022-06-03 00:18:50) > Allow L1 and its sub-states in the qcom dwc pcie wrapper. > By default its disabled. So enable it explicitly. > Would be good to add some more details about why it's disabled by default. I guess it's disabled by default in the hardware and enabling it is OK to do unconditionally for all qcom dwc pcie devices?