From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Subject: Re: [PATCH 2/5] pciehp: Don't enable presence notification while surprise removal is not supported.
Date: Wed, 11 Jul 2012 17:05:11 -0700 [thread overview]
Message-ID: <CAE9FiQU1NkYr2jPFoRazYyniRK0TnjXsyLnALA8muaf3F04-pg@mail.gmail.com> (raw)
In-Reply-To: <CAErSpo4=W7kejZ9BsUeZfu5R0=R8tzq5+q96aOX+VbOsOY6CLw@mail.gmail.com>
On Wed, Jul 11, 2012 at 3:24 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> If we *do* want to change something there, I don't like the proposal
> above any better. It's still basically saying "presence detect is
> only reliable when X is set" when X is not clearly related to presence
> detect.
>
> I think it's better to disable the presence detect interrupt
> completely if it's not reliable, as your original patch did. My
> complaint with that is that HP_SUPR_RM() doesn't seem like the right
> test for "the interrupt is not reliable."
ok.
>
> Having a "Presence Detect State" bit and an interrupt that tells you
> when it changed is only meaningful if that bit gives you useful
> information. If hardware supplies that bit but it toggles all the
> time when the slot is empty because it's hooked up to link training
> attempts, that just means the hardware screwed up. The hardware
> *should* have included some logic to filter out the attempts and
> toggle the bit only when a card is actually added or removed. I
> believe the functionality of "Presence Detect State" is logically
> independent of "Hot-Plug Surprise" and "Attention Button Present."
the cpu vendor already agreed that is out of spec for that.
>
> So if we want to disable the "Presence Detect Changed" interrupt,
> that's fine, but I think we should do it based on a quirk or
> blacklist, or based on the fact that we have no need for it. One
> reason to want the interrupt is if "Hot-Plug Surprise" is set,
> indicating that an adapter might be removed without notice, and if
> that's the only reason, we could use your original patch.
no, with that patch, we will not get interrupt for present bit change
for non-hotplug-surprise
case.
> But if we
> do, I think we should change interrupt_event_handler() to look
> something like this:
>
> case INT_PRESENCE_ON:
> if (!ATTN_BUTTN(ctrl))
> handle_surprise_event(p_slot); /* omit this if you don't
> think it's useful */
> break;
> case INT_PRESENCE_OFF:
> handle_surprise_event(p_slot);
> break;
yes, this one should be good. and it is enhancement.
>
> If you did make a change like this, I propose (as a separate patch)
> passing info->event_type into handle_surprise_event(). We've already
> read the "Presence Detect State" bit, so there's no need for
> handle_surprise_event() to do it again.
ok. will prepare patches for that.
Yinghai
next prev parent reply other threads:[~2012-07-12 0:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 7:42 [PATCH 0/5] PCI: hotplug related misc patches Yinghai Lu
2012-06-23 7:42 ` [PATCH 1/5] PCI, acpiphp: remove not used res_lock Yinghai Lu
2012-06-23 7:42 ` [PATCH 2/5] pciehp: Don't enable presence notification while surprise removal is not supported Yinghai Lu
2012-06-26 1:26 ` Kaneshige, Kenji
2012-06-26 18:03 ` Yinghai Lu
2012-07-10 22:56 ` Bjorn Helgaas
2012-07-10 23:12 ` Yinghai Lu
2012-07-10 23:28 ` Bjorn Helgaas
2012-07-10 23:40 ` Yinghai Lu
2012-07-11 16:21 ` Bjorn Helgaas
2012-07-11 17:58 ` Yinghai Lu
2012-07-11 18:15 ` Bjorn Helgaas
2012-07-11 18:49 ` Yinghai Lu
2012-07-11 19:56 ` Bjorn Helgaas
2012-07-11 20:28 ` Yinghai Lu
2012-07-11 20:48 ` Bjorn Helgaas
2012-07-11 20:56 ` Yinghai Lu
2012-07-11 22:24 ` Bjorn Helgaas
2012-07-12 0:05 ` Yinghai Lu [this message]
2012-07-12 20:20 ` Bjorn Helgaas
2012-07-13 0:19 ` Yinghai Lu
2012-07-13 15:30 ` Bjorn Helgaas
2012-07-13 18:07 ` Yinghai Lu
2012-06-23 7:42 ` [PATCH 3/5] PCI, acpiphp: Merge acpiphp_debug and debug Yinghai Lu
2012-06-23 7:42 ` [PATCH 4/5] PCI, acpiphp: add is_hotplug_bridge detection Yinghai Lu
2012-07-11 15:50 ` Bjorn Helgaas
2012-07-11 17:14 ` Jason Baron
2012-07-11 19:42 ` Bjorn Helgaas
2012-07-16 16:05 ` Bjorn Helgaas
2012-07-17 14:14 ` Jason Baron
2012-08-15 19:36 ` Bjorn Helgaas
2012-08-20 14:35 ` Jason Baron
2012-08-22 23:19 ` Bjorn Helgaas
2012-09-04 20:55 ` Jason Baron
2012-06-23 7:42 ` [PATCH 5/5] PCI: add root bus children dev's res to fail list Yinghai Lu
2012-07-10 19:30 ` [PATCH 0/5] PCI: hotplug related misc patches Yinghai Lu
2012-07-11 18:32 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQU1NkYr2jPFoRazYyniRK0TnjXsyLnALA8muaf3F04-pg@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).