linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>, vl.homutov@gmail.com
Cc: bugzilla-daemon@bugzilla.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [Bug 18412] Intel DP43BF requires "pci=assign-busses" to discover some devices
Date: Fri, 7 Sep 2012 15:35:57 -0700	[thread overview]
Message-ID: <CAE9FiQWaY_RzxRtSfNi-u9rBW0SOVzTeXnOvc6NAbLPyzYigxA@mail.gmail.com> (raw)
In-Reply-To: <CAE9FiQXO3R8oQH2rNky64SWe-4DRx7HJr3-rp0eqEZvQbN4W2A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Fri, Sep 7, 2012 at 3:15 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Fri, Sep 7, 2012 at 2:52 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Fri, Sep 7, 2012 at 2:40 PM,  <bugzilla-daemon@bugzilla.kernel.org> wrote:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=18412
>>
>>> --- Comment #4 from VL <vl.homutov@gmail.com>  2012-09-07 21:40:04 ---
>>> The bug is still there with behaviour exactly as specified by reporter.
>>>
>>> Tested with linux-3.4.9 (gentoo), DP43BF motherboard and Intel PRO/1000 NICs.
>>> With pci=assign-busses lspci shows devices properly, without it nothing
>>> is in the list.
>
> VL,
>
> I rebased for-pci-busn-alloc branch to current pci-next
>
> please check if could fix the problem.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
> for-pci-busn-alloc
>
> http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=shortlog;h=refs/heads/for-pci-busn-alloc
>

also you could try attached patch

Thanks

Yinghai

[-- Attachment #2: pci_bridge_more_bus_check.patch --]
[-- Type: application/octet-stream, Size: 544 bytes --]

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 3cdba8b..0fc2703 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -729,7 +729,8 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev *dev, int max,
 
 	/* Check if setup is sensible at all */
 	if (!pass &&
-	    (primary != bus->number || secondary <= bus->number)) {
+	    (primary != bus->number || secondary <= bus->number ||
+	     secondary > subordinate )) {
 		dev_dbg(&dev->dev, "bus configuration invalid, reconfiguring\n");
 		broken = 1;
 	}

  reply	other threads:[~2012-09-07 22:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-18412-41252@https.bugzilla.kernel.org/>
     [not found] ` <20120907214005.5077211FC43@bugzilla.kernel.org>
2012-09-07 21:52   ` [Bug 18412] Intel DP43BF requires "pci=assign-busses" to discover some devices Bjorn Helgaas
2012-09-07 22:15     ` Yinghai Lu
2012-09-07 22:35       ` Yinghai Lu [this message]
     [not found] ` <20120909082717.63E5011FBF5@bugzilla.kernel.org>
2012-09-10 23:43   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE9FiQWaY_RzxRtSfNi-u9rBW0SOVzTeXnOvc6NAbLPyzYigxA@mail.gmail.com \
    --to=yinghai@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=vl.homutov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).