From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f179.google.com ([209.85.216.179]:33588 "EHLO mail-qc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759889AbaJ3T1g (ORCPT ); Thu, 30 Oct 2014 15:27:36 -0400 Received: by mail-qc0-f179.google.com with SMTP id o8so4605857qcw.38 for ; Thu, 30 Oct 2014 12:27:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1414621570-20777-1-git-send-email-yinghai@kernel.org> <20141030170913.GA6982@google.com> From: Bjorn Helgaas Date: Thu, 30 Oct 2014 13:27:15 -0600 Message-ID: Subject: Re: [PATCH] PCI: fix sriov enabling with virtual bus To: Yinghai Lu Cc: "linux-pci@vger.kernel.org" , Linux Kernel Mailing List , "Rafael J. Wysocki" , ACPI Devel Maling List Content-Type: text/plain; charset=UTF-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, Oct 30, 2014 at 12:57 PM, Yinghai Lu wrote: > On Thu, Oct 30, 2014 at 10:09 AM, Bjorn Helgaas wrote: >>> Fixing: commit 6cd33649fa83 ("PCI: Add pci_configure_device() during enumeration") >> >> Thanks for including this, but why not use the same format everybody else >> does: >> >> Fixes: 6cd33649fa83 ("PCI: Add pci_configure_device() during enumeration") > > will do that later. Is that formalized ? I don't know that it's formalized, but it seems to be a common convention, and using "Fixing: commit" instead of "Fixes:" doesn't seem to add value. I guess I must spend more time reading git logs than most people :) > checkpatch.pl only need 12 commit code, and (" ..") format.