From: Bjorn Helgaas <firstname.lastname@example.org>
To: Gavin Shan <email@example.com>
Cc: firstname.lastname@example.org, email@example.com
Subject: Re: [PATCH V9 0/5] Minimal alignment for p2p bars
Date: Fri, 7 Sep 2012 15:49:41 -0700 [thread overview]
Message-ID: <CAErSpo559Hr-fnZTDZGOfz9T6_GSHKhoKChgNbq-apLuLqbaYQ@mail.gmail.com> (raw)
On Thu, Sep 6, 2012 at 10:00 PM, Gavin Shan <firstname.lastname@example.org> wrote:
> v1 -> v2:
> * Shorten the varaible names so that they looks more short.
> * Changelog adjustment so that they looks more meaningful.
> v2 -> v3:
> * Rebase to 3.5.RC4
> v3 -> v4:
> * Merge Yinghai's patches.
> * Split patch for easy review.
> * Add function to retrieve the minimal alignment of p2p bridge.
> v4 -> v5:
> * Rebase to 3.5.RC7
> * Introduce weak function pcibios_window_alignment() to retrieve
> I/O and memory alignment for P2P bridges.
> * Introduce pcibios_window_alignment() for ppc to override the
> PCI function.
> * Add ppc_md.pcibios_window_alignment() for specific platform like
> powernv can override ppc's pcibios_window_alignment().
> v5 -> v6:
> * Refactor pcibios_window_alignment() so the platform-specific
> implementation needn't return the default alignment according
> to Bjorn's suggestion.
> * Simplify pbus_size_mem() according to Bjorn's suggestion: Just
> check the platform required alignment at very end and adjust
> the "min_align" if necessary.
> v6 -> v7:
> * Change "type" to "b_res->flags & mask" while retrieving the
> minimal alignment for memory window according to Ram's suggestion.
> * Refactor pbus_size_mem() according to Ram's suggestion.
> * ppc_md.pcibios_window_alignment returns 1 for those PCI bridges
> behind PCI bridges so that PCI core will use default alignment
> v7 -> v8:
> * Rebase to 3.6.RC2, which starts to use "struct resource" to represent
> the range of PCI bus numbers that specific p2p bridge covers.
> * Define macros for the default alignment of P2P bars according to
> Richard's comments.
> v8 -> v9:
> * Rebase to 3.6.RC4
> * Remove the original first 3 patches since they're irrevelant to the
> * Platform can override p2p I/O alignment even the p2p bridge explicitly
> requires 1KiB I/O alignment according to Bjorn's comments.
> * In function pbus_size_io(), the maximal allowed I/O alignment was changed
> from 4KiB to 1KiB for those p2p bridges that require 1KiB alignment, which
> is traced by variable "io_align". I'm not sure that's correct for 100% since
> the original implementation had 1KiB for "io_align" for the case.
> * Adjustment for pnv_pci_window_alignment() so that we can use the default
> alignments (4KiB for I/O, 1MiB for memory) if the PCI bus isn't the top
> level bus in the associated EEH segment.
> Gavin Shan(5)
> pci: weak function returns alignment
> pci: resource assignment based on p2p alignment
> pci: refactor function pbus_size_mem
> ppc/pci: override pcibios_window_alignment
> ppc/pnv: I/O and memory alignment for p2p bridges
> arch/powerpc/include/asm/machdep.h | 3 +
> arch/powerpc/kernel/pci-common.c | 20 +++++++
> arch/powerpc/platforms/powernv/pci-ioda.c | 39 ++++++++++++++
> drivers/pci/setup-bus.c | 81 +++++++++++++++++++++--------
> include/linux/pci.h | 2 +
> 5 files changed, 124 insertions(+), 21 deletions(-)
I applied these to:
Assuming they pass Fengguang's build/smoke test, I'll merge that to my
"next" branch soon. Thanks!
next prev parent reply other threads:[~2012-09-07 22:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 5:00 [PATCH V9 0/5] Minimal alignment for p2p bars Gavin Shan
2012-09-07 5:00 ` [PATCH 1/5] pci: weak function returns alignment Gavin Shan
2012-09-07 5:00 ` [PATCH 2/5] pci: resource assignment based on p2p alignment Gavin Shan
2012-09-07 5:00 ` [PATCH 3/5] pci: refactor function pbus_size_mem Gavin Shan
2012-09-07 5:00 ` [PATCH 4/5] ppc/pci: override pcibios_window_alignment Gavin Shan
2012-09-07 5:00 ` [PATCH 5/5] ppc/pnv: I/O and memory alignment for p2p bridges Gavin Shan
2012-09-07 22:49 ` Bjorn Helgaas [this message]
2012-09-07 23:51 ` [PATCH V9 0/5] Minimal alignment for p2p bars Benjamin Herrenschmidt
2012-09-10 22:42 ` Bjorn Helgaas
2012-09-10 23:33 ` Benjamin Herrenschmidt
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).