linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: marcel.a@redhat.com
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <matthew@wil.cx>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug
Date: Thu, 1 May 2014 14:00:41 -0600	[thread overview]
Message-ID: <CAErSpo6SOc-OPQDyjweAataRXwjPYgXM3+P1nhK7zQ2vRjRE2g@mail.gmail.com> (raw)
In-Reply-To: <1398970625.18595.24.camel@localhost.localdomain>

On Thu, May 1, 2014 at 12:57 PM, Marcel Apfelbaum
<marcel.apfelbaum@gmail.com> wrote:
> On Thu, 2014-05-01 at 21:13 +0300, Marcel Apfelbaum wrote:
>> On Thu, 2014-05-01 at 12:02 -0600, Bjorn Helgaas wrote:
>> > On Thu, May 1, 2014 at 8:35 AM, Marcel Apfelbaum <marcel.a@redhat.com> wrote:
>> > > When a board is added, the shpchp driver checks if there
>> > > is a mismatch between the bridge's adapter and the bus speed.
>> > > If there is, it sets the subordinate speed (if there is no device on it).
>> > >
>> > > However, it takes the reference of the board speed from the primary bus
>> > > and not from the subordinate. If the primary bus is PCI and not PCIX/PCIe,
>> > > its speed is not updated and remains 0xff. As a result hotplug fails
>> > > with error: "Speed of bus ff and adapter 0 mismatch".
>> >
>> > It'd be cool to have a bugzilla for this with lspci and dmesg output.
>> > I'll also have to check the other hotplug drivers for similar issues,
>> > unless you've already done that.
>> I'll open a BZ with the details, sure.
> Done: https://bugzilla.kernel.org/show_bug.cgi?id=75251
> If you need further details, please let me know.

Thanks.  Would you mind attaching the "lspci -vv" output?  That should
show more details, including the information used to compute the bus
speed.

Also, you checked the "regression" box.  Can you confirm that and
identify a known-working kernel?  If we know which kernels are broken,
we can potentially mark the fix to be backported to them.

Bjorn

  reply	other threads:[~2014-05-01 20:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01 14:35 [PATCH] PCI/shpchp: fix a bus speed issue on hotplug Marcel Apfelbaum
2014-05-01 15:43 ` Michael S. Tsirkin
2014-05-01 18:02 ` Bjorn Helgaas
2014-05-01 18:13   ` Marcel Apfelbaum
2014-05-01 18:57     ` Marcel Apfelbaum
2014-05-01 20:00       ` Bjorn Helgaas [this message]
2014-05-01 20:36         ` Marcel Apfelbaum
2014-05-04 10:40         ` Marcel Apfelbaum
2014-05-04 13:48 ` Ronen Hod
2014-05-04 14:07   ` Marcel Apfelbaum
2014-05-15 18:41 ` Bjorn Helgaas
2014-05-17 18:47   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAErSpo6SOc-OPQDyjweAataRXwjPYgXM3+P1nhK7zQ2vRjRE2g@mail.gmail.com \
    --to=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=marcel.a@redhat.com \
    --cc=matthew@wil.cx \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).