From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f54.google.com ([209.85.213.54]:36130 "EHLO mail-yh0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756132AbbFRULE convert rfc822-to-8bit (ORCPT ); Thu, 18 Jun 2015 16:11:04 -0400 Received: by yhan67 with SMTP id n67so64140879yha.3 for ; Thu, 18 Jun 2015 13:11:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-11-git-send-email-robh@kernel.org> <20150618165954.GE7710@google.com> From: Bjorn Helgaas Date: Thu, 18 Jun 2015 15:10:43 -0500 Message-ID: Subject: Re: [PATCH 10/15] PCI: kill off set_irq_flags usage To: Rob Herring Cc: Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Kishon Vijay Abraham I , Murali Karicheri , Thierry Reding , Stephen Warren , Alexandre Courbot , Jingoo Han , Pratyush Anand , Simon Horman , Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , linux-omap , "linux-pci@vger.kernel.org" , "linux-tegra@vger.kernel.org" , SH-Linux Content-Type: text/plain; charset=UTF-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On Thu, Jun 18, 2015 at 3:08 PM, Rob Herring wrote: > On Thu, Jun 18, 2015 at 11:59 AM, Bjorn Helgaas wrote: >> On Tue, Jun 09, 2015 at 01:26:36PM -0500, Rob Herring wrote: >>> set_irq_flags is ARM specific with custom flags which have genirq >>> equivalents. Convert drivers to use the genirq interfaces directly, so we >>> can kill off set_irq_flags. The translation of flags is as follows: >>> >>> IRQF_VALID -> !IRQ_NOREQUEST >>> IRQF_PROBE -> !IRQ_NOPROBE >>> IRQF_NOAUTOEN -> IRQ_NOAUTOEN >>> >>> For IRQs managed by an irqdomain, the irqdomain core code handles clearing >>> and setting IRQ_NOREQUEST already, so there is no need to do this in >>> .map() functions and we can simply remove the set_irq_flags calls. Some >>> users also set IRQ_NOPROBE and this has been maintained although it is not >>> clear that is really needed. There appears to be a great deal of blind >>> copy and paste of this code. >>> >>> Signed-off-by: Rob Herring >>> Cc: Kishon Vijay Abraham I >>> Cc: Bjorn Helgaas >>> Cc: Murali Karicheri >>> Cc: Thierry Reding >>> Cc: Stephen Warren >>> Cc: Alexandre Courbot >>> Cc: Jingoo Han >>> Cc: Pratyush Anand >>> Cc: Simon Horman >>> Cc: Michal Simek >>> Cc: "Sören Brinkmann" >>> Cc: linux-omap@vger.kernel.org >>> Cc: linux-pci@vger.kernel.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-tegra@vger.kernel.org >>> Cc: linux-sh@vger.kernel.org >> >> This is the only part of the series on linux-pci, so I assume this will be >> merged by somebody else along with the rest. > > I copied you on the intro, but all the lists and all the maintainers > was too long to cc. Being late in the cycle I didn't really intend for > this to be for 4.2, but you can pick up this patch if you want to as > it doesn't have any dependencies. If you don't, then I will submit the > whole series for 4.3. OK, why don't you just include this with the rest of the series, since I assume the whole series is related even if there's no actual dependency. Bjorn