linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matthew Wilcox <matthew.r.wilcox@intel.com>,
	Robert Hancock <hancockrwd@gmail.com>
Subject: Re: [PATCH 0/2] PCI: decode disable fixes
Date: Mon, 9 Jul 2012 21:23:03 -0600	[thread overview]
Message-ID: <CAErSpo6aOq5Ph9yJ_Oa2Uo2TBdvG9MbXcZe8zrXVOU4=Dne4Xw@mail.gmail.com> (raw)
In-Reply-To: <20120709181745.18165.93914.stgit@bhelgaas.mtv.corp.google.com>

On Mon, Jul 9, 2012 at 12:20 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> Since 2.6.36 (253d2e5498), we've disabled MEM & IO decoding while we size
> BARs (except for host bridge devices).  These patches tweak this in two
> ways:
>
> 1) We only kept decoding disabled while sizing the low-order dword
> of 64-bit BARs.  I think we should keep it disabled while we do the
> high-order dword also.
>
> 2) I think we should also disable decoding while updating 64-bit BARs,
> e.g., when we move a device into an aperture of an upstream bridge.  I'm
> only proposing to disable decoding for 64-bit BAR updates because 32-bit
> ones can be done atomically, while 64-bit updates require two writes and
> the half-written state is a potential problem.
>
> I'm considering these changes for the 3.6 merge window, which is
> approaching fast, so let me know if you see issues with either of these.
>
> ---
>
> Bjorn Helgaas (2):
>       PCI: leave MEM and IO decoding disabled during 64-bit BAR sizing, too
>       PCI: disable MEM decoding while updating 64-bit MEM BARs
>
>
>  drivers/pci/probe.c     |    6 +++---
>  drivers/pci/setup-res.c |   18 ++++++++++++++++++
>  2 files changed, 21 insertions(+), 3 deletions(-)

I applied these to my "next" branch.

      parent reply	other threads:[~2012-07-10  3:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 18:20 [PATCH 0/2] PCI: decode disable fixes Bjorn Helgaas
2012-07-09 18:20 ` [PATCH 1/2] PCI: leave MEM and IO decoding disabled during 64-bit BAR sizing, too Bjorn Helgaas
2012-07-09 20:18   ` Jacob Pan
2012-08-23  7:28   ` Olof Johansson
2012-08-23 18:02     ` Bjorn Helgaas
2012-08-23 18:20       ` Olof Johansson
2012-07-09 18:20 ` [PATCH 2/2] PCI: disable MEM decoding while updating 64-bit MEM BARs Bjorn Helgaas
2012-07-10  3:23 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAErSpo6aOq5Ph9yJ_Oa2Uo2TBdvG9MbXcZe8zrXVOU4=Dne4Xw@mail.gmail.com' \
    --to=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hancockrwd@gmail.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew.r.wilcox@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).