From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13010C48BE0 for ; Fri, 21 Jun 2019 18:13:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE135208C3 for ; Fri, 21 Jun 2019 18:13:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jpDMD7h4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726080AbfFUSNN (ORCPT ); Fri, 21 Jun 2019 14:13:13 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:37817 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfFUSNN (ORCPT ); Fri, 21 Jun 2019 14:13:13 -0400 Received: by mail-wm1-f66.google.com with SMTP id f17so7465954wme.2 for ; Fri, 21 Jun 2019 11:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dEyGlTsnsKuBLwX5xX2JKI/ESGQXtRFnkrYp5ebnbEM=; b=jpDMD7h4CQgiptV4ihUW/bUNgJKDqTi71iQj64iG0gyAevW/vejPrbeHwJKqytGUxs JH//IpRhhpQq5/ACeHQIHb/A0y8Y+60JkKT9VVqp6Y5N1SSLTFYLqjmfxB5qNM8NYNEi wKFg81RKKrcff5f4kOgSsGDmV7e/fagFLOX3fnLvxw1/PIFWBbs5tzHdOrVuGHa16z41 WM/EOmwP0nCV72YLzbXnExNO5PreQzUviu7SnqBKpMjro3IHKcxkQUyFnWRPHz1mLlWQ 3fqK2GFsob1NgeqZeby50at4AgQenZ/yDnz1A0hUrXWaBs/j2FK9iNBCxwbKNfZprUtZ aBMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dEyGlTsnsKuBLwX5xX2JKI/ESGQXtRFnkrYp5ebnbEM=; b=Z1fEiKH73/Y0OZz+VshrnSTlFTgRLqewmWaz3phHATQ6y6pg3+pThnqZyrsGPw1wII Af3PbLVAyZzjvCAN6oWkLXTZKJORQbkMLj3FaWrdX5rnMo7H2oFbzSwKDknaORFq9jdZ vicV+M3jjyLPjGF2rHef6kmUf0j1j/wzJJB9skGB8yLVJZpv8u6+e0GXVb1aP+I4dW1U 2p0N1Vz1kqEI3CGldnTRPu3fSPsLRIM015ZSFiP52uLSOvATl8q5/zIR8YEo9HOmSqYs 0Lq4UTkywm17J8UR3noY3CDWgI8d508tkZDMTkFflC62tZg5yXbQHiPkgFZDWjLFAhp5 k8Rw== X-Gm-Message-State: APjAAAUQfGpe26xZ5kXqM5RccNywErhDDIsaIeUa5qxDHfi+C7OEfY91 zfFj9WZpcPDcJ93831OGdYApPQ/uH6ukWgXH5Rpd X-Google-Smtp-Source: APXvYqyDZAMAe0SGrsikwsOgiVKLU6ZWCS7eXygDIMzxOPc8qc57aRbkICtb2bfT9w1wvSlQ1kgHFd43Ln85KNGdZs8= X-Received: by 2002:a1c:3dc1:: with SMTP id k184mr5129288wma.88.1561140791059; Fri, 21 Jun 2019 11:13:11 -0700 (PDT) MIME-Version: 1.0 References: <20190621163921.26188-1-puranjay12@gmail.com> <698d3e3614ae903ae9582547d64c6a9846629e57.camel@perches.com> In-Reply-To: <698d3e3614ae903ae9582547d64c6a9846629e57.camel@perches.com> From: Bjorn Helgaas Date: Fri, 21 Jun 2019 13:12:58 -0500 Message-ID: Subject: Re: [PATCH 0/3] net: ethernet: atheros: atlx: Use PCI generic definitions instead of private duplicates To: Joe Perches Cc: Puranjay Mohan , Jay Cliburn , Chris Snook , Shuah Khan , Bjorn Helgaas , netdev , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Linux PCI Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jun 21, 2019 at 12:27 PM Joe Perches wrote: > > (adding the atlx maintainers to cc) > > On Fri, 2019-06-21 at 12:11 -0500, Bjorn Helgaas wrote: > > On Fri, Jun 21, 2019 at 11:39 AM Puranjay Mohan wrote: > > > This patch series removes the private duplicates of PCI definitions in > > > favour of generic definitions defined in pci_regs.h. > > > > > > Puranjay Mohan (3): > > > net: ethernet: atheros: atlx: Rename local PCI defines to generic > > > names > > > net: ethernet: atheros: atlx: Include generic PCI definitions > > > net: ethernet: atheros: atlx: Remove unused and private PCI > > > definitions > > > > > > drivers/net/ethernet/atheros/atlx/atl2.c | 5 +++-- > > > drivers/net/ethernet/atheros/atlx/atl2.h | 2 -- > > > drivers/net/ethernet/atheros/atlx/atlx.h | 1 - > > > 3 files changed, 3 insertions(+), 5 deletions(-) > > > > Let's slow this down a little bit; I'm afraid we're going to overwhelm folks. > > I generally disagree. > > Consolidation of these sorts of changes are generally > better done treewide all at once, posted as a series to > a list and maintainers allowing time (weeks to months) > for the specific maintainers to accept them and then > whatever remainder exists reposted and possibly applied > by an overall maintainer (e.g.: Dave M) > > > Before posting more to LKML/netdev, how about we first complete a > > sweep of all the drivers to see what we're getting into. It could be > > that this will end up being more churn than it's worth. > > Also doubtful. > > Subsystem specific local PCI #defines without generic > naming is poor style and makes treewide grep and > refactoring much more difficult. Don't worry, we have the same objectives. I totally agree that local #defines are a bad thing, which is why I proposed this project in the first place. I'm just saying that this is a "first-patch" sort of learning project and I think it'll avoid some list spamming and discouragement if we can figure out the scope and shake out some of the teething problems ahead of time. I don't want to end up with multiple versions of dozens of little 2-3 patch series posted every week or two. I'd rather be able to deal with a whole block of them at one time. > The atlx maintainers should definitely have been cc'd > on these patches. > > Jay Cliburn (maintainer:ATLX ETHERNET DRIVERS) > Chris Snook (maintainer:ATLX ETHERNET DRIVERS) > > Puranjay, can you please do a few things more here: > > 1: Make sure you use scripts/get_maintainer.pl to cc the > appropriate people. > > 2: Show that you compiled the object files and verified > where possible that there are no object file changes. Do you have any pointers for the best way to do this? Is it as simple as comparing output of "objdump -d"? > 3: State that there are no object changes in the proposed > commit log. Thanks for the additional tips. Bjorn