archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <>
To:, Yinghai Lu <>
Subject: Re: [Bug 18412] Intel DP43BF requires "pci=assign-busses" to discover some devices
Date: Mon, 10 Sep 2012 17:43:53 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Sep 9, 2012 at 2:27 AM,  <> wrote:
> --- Comment #14 from VL <>  2012-09-09 08:27:17 ---
>> Given the [bus 20-08] range, I suspect that the patch in comment #9 may fix it,
>> and that's something we could apply.  Can you try just that patch on top of a
>> 3.5 or 3.6-rc4 kernel?
> yes, this patch fixes the problem.

Yinghai, you put the following (whitespace damaged) patch in the
bugzilla, and VL says it fixes his sytem.  He has a P2P bridge with
secondary > subordinate:

    pci 0000:00:1e.0: PCI bridge to [bus 20-08] (subtractive decode)

The current kernel doesn't probe behind this bridge, so it doesn't
find a couple devices.  With the patch below, we reassign the
secondary bus number from 20 to 08, so we do find those devices.

I'm slightly concerned that if we apply a patch like this, it removes
one way a BIOS could hide devices from the OS.  But maybe we don't
need to worry about that.  We have to configure hot-added P2P bridges
from scratch, so maybe we should be aggressive about fixing bridges
like this, too.

Are you comfortable enough with this patch to post it with a Signed-off-by?

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 3cdba8b..a8f1bf6 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -729,7 +729,8 @@ int __devinit pci_scan_bridge(struct pci_bus *bus,
struct pci_dev *dev, int max,

 	/* Check if setup is sensible at all */
 	if (!pass &&
-	    (primary != bus->number || secondary <= bus->number)) {
+	    (primary != bus->number || secondary <= bus->number ||
+	     secondary > subordinate)) {
 		dev_dbg(&dev->dev, "bus configuration invalid, reconfiguring\n");
 		broken = 1;

      parent reply	other threads:[~2012-09-10 23:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
     [not found] ` <>
2012-09-07 21:52   ` [Bug 18412] Intel DP43BF requires "pci=assign-busses" to discover some devices Bjorn Helgaas
2012-09-07 22:15     ` Yinghai Lu
2012-09-07 22:35       ` Yinghai Lu
     [not found] ` <>
2012-09-10 23:43   ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).