linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: EHCI: fix crash during hibernation on ASUS computers
       [not found] ` <201208112356.26719.rjw@sisk.pl>
@ 2012-08-12 21:26   ` Rafael J. Wysocki
  2012-08-15 19:15     ` Bjorn Helgaas
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2012-08-12 21:26 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Alan Stern, AceLan Kao, alex.hung, Oleksij Rempel,
	Linux-pm mailing list, linux-pci, LKML


Commit dbf0e4c (PCI: EHCI: fix crash during suspend on ASUS
computers) added a workaround for an ASUS suspend issue related to
USB EHCI and a bug in a number of ASUS BIOSes that attemt to shut
down the EHCI controller during system suspend if its PCI command
register doesn't contain 0 at that time.

It turns out that the same workaround is necessary in the analogous
hibernation code path, so add it.

References: https://bugzilla.kernel.org/show_bug.cgi?id=45811
Reported-and-tested-by: Oleksij Rempel <bug-track@fisher-privat.net>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: stable@vger.kernel.org
---

Hi Bjorn,

Please push this to Linus ASAP, we need it in 3.6 and -stable.

Thanks,
Rafael

---
 drivers/pci/pci-driver.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux/drivers/pci/pci-driver.c
===================================================================
--- linux.orig/drivers/pci/pci-driver.c
+++ linux/drivers/pci/pci-driver.c
@@ -959,6 +959,13 @@ static int pci_pm_poweroff_noirq(struct
 	if (!pci_dev->state_saved && !pci_is_bridge(pci_dev))
 		pci_prepare_to_sleep(pci_dev);
 
+	/*
+	 * The reason for doing this here is the same as for the analogous code
+	 * in pci_pm_suspend_noirq().
+	 */
+	if (pci_dev->class == PCI_CLASS_SERIAL_USB_EHCI)
+		pci_write_config_word(pci_dev, PCI_COMMAND, 0);
+
 	return 0;
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: EHCI: fix crash during hibernation on ASUS computers
  2012-08-12 21:26   ` [PATCH] PCI: EHCI: fix crash during hibernation on ASUS computers Rafael J. Wysocki
@ 2012-08-15 19:15     ` Bjorn Helgaas
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2012-08-15 19:15 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Alan Stern, AceLan Kao, alex.hung, Oleksij Rempel,
	Linux-pm mailing list, linux-pci, LKML

On Sun, Aug 12, 2012 at 3:26 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> Commit dbf0e4c (PCI: EHCI: fix crash during suspend on ASUS
> computers) added a workaround for an ASUS suspend issue related to
> USB EHCI and a bug in a number of ASUS BIOSes that attemt to shut
> down the EHCI controller during system suspend if its PCI command
> register doesn't contain 0 at that time.
>
> It turns out that the same workaround is necessary in the analogous
> hibernation code path, so add it.
>
> References: https://bugzilla.kernel.org/show_bug.cgi?id=45811
> Reported-and-tested-by: Oleksij Rempel <bug-track@fisher-privat.net>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: stable@vger.kernel.org
> ---
>
> Hi Bjorn,
>
> Please push this to Linus ASAP, we need it in 3.6 and -stable.

Applied to my for-linus branch, thanks.  I'll ask Linus to pull it in
a couple days, after it's had a chance in -next.

> ---
>  drivers/pci/pci-driver.c |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> Index: linux/drivers/pci/pci-driver.c
> ===================================================================
> --- linux.orig/drivers/pci/pci-driver.c
> +++ linux/drivers/pci/pci-driver.c
> @@ -959,6 +959,13 @@ static int pci_pm_poweroff_noirq(struct
>         if (!pci_dev->state_saved && !pci_is_bridge(pci_dev))
>                 pci_prepare_to_sleep(pci_dev);
>
> +       /*
> +        * The reason for doing this here is the same as for the analogous code
> +        * in pci_pm_suspend_noirq().
> +        */
> +       if (pci_dev->class == PCI_CLASS_SERIAL_USB_EHCI)
> +               pci_write_config_word(pci_dev, PCI_COMMAND, 0);
> +
>         return 0;
>  }
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-15 19:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <Pine.LNX.4.44L0.1208110959320.21252-100000@netrider.rowland.org>
     [not found] ` <201208112356.26719.rjw@sisk.pl>
2012-08-12 21:26   ` [PATCH] PCI: EHCI: fix crash during hibernation on ASUS computers Rafael J. Wysocki
2012-08-15 19:15     ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).