From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3721AC433E4 for ; Tue, 28 Jul 2020 01:50:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 159052078E for ; Tue, 28 Jul 2020 01:50:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C2LHZbx6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726278AbgG1Buy (ORCPT ); Mon, 27 Jul 2020 21:50:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgG1Buy (ORCPT ); Mon, 27 Jul 2020 21:50:54 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA43EC061794; Mon, 27 Jul 2020 18:50:53 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id r13so7772270ilt.6; Mon, 27 Jul 2020 18:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=d8AIX6Jt0FrGJJO5RxD/791F0xEbWlpcv94oWhzTkkQ=; b=C2LHZbx60OkuSsmGiL3SWROsKh85t9fN7z189B8DUbUN9j1FwVDMqO5oERtzxRKhU6 aMjvnaoUb1DsWpMbg9k1+utFyw4df2IiVO4rTn/SaOCrsWlBohDzGsKNu7/kEWc6j7jk lZ4wTSulYDx0D5ehBrZcR4BPSRo0RAKuPjchN8rNK5V2b9KROzsM55DNsdqbFWLKfKTc X1P1uvmvgxpCqpWwwabbnlzQnBH/d0kO8UnrOT76HcMZoTLrMIjNAalbE9DnQcVZpjM7 eAlbNQu+Tdt3m2HEerEmjxbTNshpzLMqEvagdqWbke3M0iDOVwiMKhgOISzSshS6hk10 tzvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d8AIX6Jt0FrGJJO5RxD/791F0xEbWlpcv94oWhzTkkQ=; b=X83mW0On7Yg1wEnlQmmry3pOOeUXj93wEEvHWuzybKeoEXD6Ts7OlBa+sNNhkNnFPY 35r1XZJC61GymFq+MeC9Ws85CJaqU2R45hRBE4IBsHf55v/4X3WlJybbi2+MBwfSyneo QEZluNi10X3RqBGg8OfXabgz8CQUQj3csw0HlT9c7Nft9D1zcz/bYlJPik1GQQ8lZCfj 6yggpz3EGNSe4eJT2G70R34+WYXXUZD2KUpWt9LQFRQ/VBeEU7Y4ylVkswYZ7e5c+UjT uIOnKDlTIWVKVNbRztO8rkOXXAc9ieZz1ACrJFvsOzroXcNa/tYXIc8125oV9/it2hpJ cRbw== X-Gm-Message-State: AOAM531SWNMCNMERxn3PxWZDQJ/2tnYUzM/xWj+JTZpxmnyBcIV9kI70 TZFi0low4pnMWRgOEdyAC/0lhE39nE0SX2FaoE0= X-Google-Smtp-Source: ABdhPJwzdRuIxBXTsqmO3T8lV5HJYUyVEvHoJS4NFcEmdwrQH3gqqCuv4KOKHYoLewEVooxtEn7LK9uJ/t8opb5kHv0= X-Received: by 2002:a05:6e02:8e4:: with SMTP id n4mr18085163ilt.96.1595901053248; Mon, 27 Jul 2020 18:50:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6602:2a46:0:0:0:0 with HTTP; Mon, 27 Jul 2020 18:50:52 -0700 (PDT) In-Reply-To: References: <20191029170250.GA43972@google.com> <20200222165617.GA207731@google.com> <20200226011310.GA2116625@rani.riverdale.lan> <6e9db1f6-60c4-872b-c7c8-96ee411aa3ca@aol.com> <20200226045104.GA2191053@rani.riverdale.lan> <20200225212054.09865e0b@fido6> From: "Michael ." Date: Tue, 28 Jul 2020 11:50:52 +1000 Message-ID: Subject: Re: PCI device function not being enumerated [Was: PCMCIA not working on Panasonic Toughbook CF-29] To: bluerocksaddles@willitsonline.com Cc: Philip Langdale , Arvind Sankar , Trevor Jacobs , Ulf Hansson , Bjorn Helgaas , Dominik Brodowski , Linux PCI , Linux Kernel Mailing List , Kris Cleveland , Morgan Klym , Pierre Ossman , Maxim Levitsky , linux-mmc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org I have just compiled and uploaded a kernel to test for this issue, members of the Toughbook community have been provided with the link, though a forum discussion, to download the kernel and test it. Hopefully we will get positive results and can confirm the MMC_RICOH_MMC flag is the culprit. Regards. Stay safe. Michael. On 27/02/2020, bluerocksaddles@willitsonline.com wrote: > Somewhere in these messages is a clue....in that SD reader was involved. > > MK 4 and 5 have SD whilst MK 1, 2 and three do not. > > > > On 2020-02-25 22:10, Michael . wrote: >>> Someone with access to real hardware could >>> easily experiment with changing that magic value and seeing if it >>> changes which function is disabled. >> >> One of our members has offered to supply a machine to a dev that can >> use it to test any theory. >> >> It is nearly beyond the scope of the majority of us to do much more >> than just testing. We appreciate all the effort the devs put in and >> are willing to help in anyway we can but we aren't kernel devs. >> >> I, personally, use Debian. Others use Debian based distros such as MX >> and Mint. We have been able to test many different distros such as >> those listed in other comments but don't have the skills or expertise >> to do much more. It is our hope that this discussion and subsequent >> effort may enable others who prefer distros other than Debian based >> distros can use a CF-29 (and possibly earlier) Toughbook with the >> distro of their choice without having to rebuild a kernel so they can >> use hardware that worked back in 2010. To do this the fix needs to be >> at the kernel dev level not a local enthusiast level because while I >> can rebuild a Debian kernel I can't rebuild a Fedora or Arch or >> Slackware kernel. >> >> I did a search about this issue before I made initial contact late >> last year and the issue was discovered on more than Toughbooks and >> posted about on various sites not long after distros moved from >> 2.6.32. It seems back then people just got new machines that didn't >> have a 2nd slot so the search for an answer stopped. Us Toughbook >> users are a loyal group we use our machines because they are exactly >> what we need and they take alot of "punishment" taht other machines >> simply cannot handle. Our machines are used rather than recycled or >> worse still just left to sit in waste management facilities in a >> country that the western world dumps its rubbish in, we are Linux and >> Toughbook enthusiasts and hope to be able to keep our machines running >> for many years to come with all their native capabilities working as >> they were designed to but using a modern Linux instead of Windows XP >> or Windows 7. (that wasn't a pep talk, its just an explanation of why >> we are passionate about this). >> >> Let us know what you need us to do, we will let you know if we are >> capable of it and give you any feedback you ask for. Over the weekend >> I will try to rebuild a Debian kernel with the relevant option >> disabled, provide it to my peers for testing and report back here what >> the outcome is. >> >> Thank you all for all your time and effort, it is truly appreciated. >> Cheers. >> Michael. >> >> On 26/02/2020, Philip Langdale wrote: >>> On Tue, 25 Feb 2020 23:51:05 -0500 >>> Arvind Sankar wrote: >>> >>>> On Tue, Feb 25, 2020 at 09:12:48PM -0600, Trevor Jacobs wrote: >>>> > That's correct, I tested a bunch of the old distros including >>>> > slackware, and 2.6.32 is where the problem began. >>>> > >>>> > Also, the Panasonic Toughbook CF-29s effected that we tested are >>>> > the later marks, MK4 and MK5 for certain. The MK2 CF-29 worked just >>>> > fine because it has different hardware supporting the PCMCIA slots. >>>> > I have not tested a MK3 but suspect it would work ok as it also >>>> > uses the older hardware. >>>> > >>>> > Thanks for your help guys! >>>> > Trevor >>>> > >>>> >>>> Right, the distros probably all enabled MMC_RICOH_MMC earlier than >>>> upstream. Can you test a custom kernel based off your distro kernel >>>> but just disabling that config option? That's probably the easiest >>>> fix >>>> currently, even though not ideal. Perhaps there should be a command >>>> line option to disable specific pci quirks to make this easier. >>>> >>>> An ideal fix is I feel hard, given this quirk is based on >>>> undocumented >>>> config registers -- it worked on Dell machines (that's where the >>>> original authors seem to have gotten their info from), perhaps they >>>> had only one Cardbus slot, but the code ends up disabling your second >>>> Cardbus slot instead of disabling the MMC controller. >>> >>> Keeping in mind that this was 12+ years ago, you can at least still >>> read the original discussion in the archives. My original Dell laptop >>> (XPS m1330) had no cardbus slots at all, and used the r5c832 >>> controller. There was a subsequent change that I was not involved with >>> which added support for the rl5c476, which is the problematic device >>> in >>> this thread. >>> >>> As a hypothesis, based on the observed behaviour, the quirk (keeping >>> in >>> mind that these are magic configuration register values that are not >>> documented) probably disabled function 1, regardless of what it is, >>> and >>> the original example that motivated adding the rl5c476 quirk probably >>> had one cardbus slot and the card reader functions were all moved up >>> one, or something along those lines. >>> >>> Truly making this smart would then involve having the code enumerate >>> the pci functions and identify the one that is the unwanted mmc >>> controller, based on function ID or class or whatever, and then >>> disabling that (assuming the magic can be reverse engineered: eg, the >>> current magic ORs the disable flag with 0x02 - chances are, that's the >>> index of the function: 0x01 would be the 0th function, 0x04 would be >>> the 2nd function, etc). Someone with access to real hardware could >>> easily experiment with changing that magic value and seeing if it >>> changes which function is disabled. >>> >>> Good luck. >>> >>> --phil >>> >