From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416A0C433E0 for ; Wed, 20 Jan 2021 19:51:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE50C23442 for ; Wed, 20 Jan 2021 19:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391908AbhATTvH (ORCPT ); Wed, 20 Jan 2021 14:51:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392786AbhATTtN (ORCPT ); Wed, 20 Jan 2021 14:49:13 -0500 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91CC0C0613C1 for ; Wed, 20 Jan 2021 11:48:33 -0800 (PST) Received: by mail-yb1-xb32.google.com with SMTP id k132so13450082ybf.2 for ; Wed, 20 Jan 2021 11:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ObV+Zrw0ag3h+RPkcqP4IfhPjoMoAtg+NMqr3jjO+Go=; b=oC6SN/sbj4bIrF3B4GUuhs9TwpbLn4WPe1e9cjwF7wwmLDRIO7pF44hc+PlUUR5s6f BUa/nNUWktSkKrynSgljkxdDWgmOVVMVyk8uWzs3rc62W0hdOV2OZFhKAvCRrJue94uF dtTS6xLCZnR4CARQJgq3BQNQntv8GvoIMDidgambBPn09cfAnJTf/fW2G1wUUaSef+Lb eUdBgvApC0YkqmFU3YIk/cUwKzppcJs1fvb2jH3Mxq+LoT5Y1ONy+9CAcS/N9SgllEh8 BpR65N56lr1oYN/R2Sk1xRq0HxiULzg425ngiI8FJXDLpvPxGxLFwJJPKAUdWbIf3wHj w/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ObV+Zrw0ag3h+RPkcqP4IfhPjoMoAtg+NMqr3jjO+Go=; b=VWonWKowHGSzCTIYJayYixiAPAayrTaqH0LiQCyscFRh0YVMcvdFXFP1E99nv3f4Pr c7o4hnlRmKWZJrN9xAkJohmr66Xn9rdNOYkbjJ52ZGFvuCJThwLFcnK61aZe3A1xAVWY Q25sbyH373pTMtvZAgYbWURGKFRndMLN4QhSuJSlJYe51F/LVoat8iTdQvPVYbFoief5 L1nweG1DflBS4AL3x+GhcG8sE020OBWezCAenrNrNCR1pefa84pNTugjlKbTYyICvAsR TIqQlcKpranUP7KhTRFo4ZZnSZQtW/iPTVGGfzbpt3xW5MIJKxW0nZeKEDScdk9OgSS8 hIWg== X-Gm-Message-State: AOAM532dwSpBask/9R3D78Q/Ke0a5wh7/Py74cgaxZEakuii/mD2MsRt a+JTvfl3ofju/Mc6REN6wSmdErwA7XgkfhT1kvebBA== X-Google-Smtp-Source: ABdhPJwnmI7Ki+dDkxtJ432CAmCzDl+L83UkNWO3KhRK6fxwAFD24zUFGq1C6V2bl4d7oNvSYCj+gOEJxriWc7ov3P4= X-Received: by 2002:a25:b703:: with SMTP id t3mr17175535ybj.96.1611172112724; Wed, 20 Jan 2021 11:48:32 -0800 (PST) MIME-Version: 1.0 References: <20210120105246.23218-1-michael@walle.cc> In-Reply-To: From: Saravana Kannan Date: Wed, 20 Jan 2021 11:47:56 -0800 Message-ID: Subject: Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver() To: Michael Walle Cc: Rob Herring , linuxppc-dev , PCI , linux-arm-kernel , LKML , Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Bjorn Helgaas , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Jan 20, 2021 at 11:47 AM Saravana Kannan wrote: > > On Wed, Jan 20, 2021 at 11:28 AM Michael Walle wrote: > > > > [RESEND, fat-fingered the buttons of my mail client and converted > > all CCs to BCCs :(] > > > > Am 2021-01-20 20:02, schrieb Saravana Kannan: > > > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: > > >> > > >> On Wed, Jan 20, 2021 at 4:53 AM Michael Walle > > >> wrote: > > >> > > > >> > fw_devlink will defer the probe until all suppliers are ready. We can't > > >> > use builtin_platform_driver_probe() because it doesn't retry after probe > > >> > deferral. Convert it to builtin_platform_driver(). > > >> > > >> If builtin_platform_driver_probe() doesn't work with fw_devlink, then > > >> shouldn't it be fixed or removed? > > > > > > I was actually thinking about this too. The problem with fixing > > > builtin_platform_driver_probe() to behave like > > > builtin_platform_driver() is that these probe functions could be > > > marked with __init. But there are also only 20 instances of > > > builtin_platform_driver_probe() in the kernel: > > > $ git grep ^builtin_platform_driver_probe | wc -l > > > 20 > > > > > > So it might be easier to just fix them to not use > > > builtin_platform_driver_probe(). > > > > > > Michael, > > > > > > Any chance you'd be willing to help me by converting all these to > > > builtin_platform_driver() and delete builtin_platform_driver_probe()? > > > > If it just moving the probe function to the _driver struct and > > remove the __init annotations. I could look into that. > > Yup. That's pretty much it AFAICT. > > builtin_platform_driver_probe() also makes sure the driver doesn't ask > for async probe, etc. But I doubt anyone is actually setting async > flags and still using builtin_platform_driver_probe(). > And thanks for agreeing to help! -Saravana