linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, svarbanov@mm-sol.com,
	linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
	linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com,
	bhelgaas@google.com, robh+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
	agross@kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: phy: qcom,qmp: Add SM8150 PCIe PHY bindings
Date: Thu, 24 Feb 2022 16:42:14 +0530	[thread overview]
Message-ID: <CAH=2Ntx0zKV7SNtuh6ATVp2qA1LKaks8KSMQoU2qtM=EmB52pQ@mail.gmail.com> (raw)
In-Reply-To: <1645648568.439634.1426821.nullmailer@robh.at.kernel.org>

Hi Rob,

On Thu, 24 Feb 2022 at 02:06, Rob Herring <robh@kernel.org> wrote:
>
> On Thu, 24 Feb 2022 00:59:42 +0530, Bhupesh Sharma wrote:
> > Add the following two PCIe PHYs found on SM8150, to the QMP binding:
> >
> > QMP GEN3x1 PHY - 1 lane
> > QMP GEN3x2 PHY - 2 lanes
> >
> > Cc: Rob Herring <robh@kernel.org>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1596890
>
>
> phy@1c06000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml

Thanks for the above check.
Although the warnings reflected in 'dtbs_check' are not related to this patch.

Still, looking at them, I can figure out that an additional patch is
required to make
''#clock-cells'' as optional property in the bindings as several qmp
phy variants
don't require the same.

I will add it in v2.

Regards,
Bhupesh


>
> phy@1c07000: '#clock-cells' is a required property
>         arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml
>
> phy@1c07000: 'lanes@1c06000' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>         arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml
>         arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml
>         arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml
>
> phy@1c0a000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
>
> phy@1c0e000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml
>         arch/arm64/boot/dts/qcom/sc7280-crd.dt.yaml
>         arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml
>         arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml
>
> phy@1c0e000: 'lanes@1c0e200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>         arch/arm64/boot/dts/qcom/sc7280-crd.dt.yaml
>         arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml
>         arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml
>         arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml
>
> phy@1c16000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml
>
> phy@1d87000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml
>         arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-hdk.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8450-qrd.dt.yaml
>
> phy@1d87000: 'lanes@1d87400', 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>         arch/arm64/boot/dts/qcom/sm8450-qrd.dt.yaml
>
> phy@1d87000: 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>         arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dt.yaml
>
> phy@1da7000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml
>
> phy@34000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml
>
> phy@58000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml
>
> phy@627000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml
>         arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml
>
> phy@627000: 'vdda-phy-max-microamp', 'vdda-pll-max-microamp', 'vddp-ref-clk-always-on', 'vddp-ref-clk-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>         arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml
>
> phy@7410000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml
>
> phy@78000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml
>
> phy@88e9000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dt.yaml
>
> phy@88eb000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml
>         arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml
>
> phy@c010000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-lilac.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-maple.dt.yaml
>         arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dt.yaml
>
> phy@ff6000: '#clock-cells' is a required property
>         arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml
>         arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml
>         arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml
>
> phy-wrapper@88e9000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/sm8350-hdk.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-mtp.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8450-qrd.dt.yaml
>
> phy-wrapper@88e9000: 'vdda-phy-supply' is a required property
>         arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml
>
> phy-wrapper@88e9000: 'vdda-pll-supply' is a required property
>         arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml
>
> phy-wrapper@88eb000: '#clock-cells' is a required property
>         arch/arm64/boot/dts/qcom/sm8350-hdk.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dt.yaml
>         arch/arm64/boot/dts/qcom/sm8350-mtp.dt.yaml
>
> ssphy@78000: 'lane@78200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>         arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
>

  reply	other threads:[~2022-02-24 11:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 19:29 [PATCH 0/6] Add PCIe support for SM8150 SoC Bhupesh Sharma
2022-02-23 19:29 ` [PATCH 1/6] dt-bindings: pci: qcom: Document PCIe bindings " Bhupesh Sharma
2022-02-25 19:43   ` Rob Herring
2022-02-23 19:29 ` [PATCH 2/6] dt-bindings: phy: qcom,qmp: Add SM8150 PCIe PHY bindings Bhupesh Sharma
2022-02-23 20:36   ` Rob Herring
2022-02-24 11:12     ` Bhupesh Sharma [this message]
2022-02-25 19:44   ` Rob Herring
2022-02-23 19:29 ` [PATCH 3/6] phy: qcom-qmp: Add SM8150 PCIe QMP PHYs Bhupesh Sharma
2022-02-23 19:29 ` [PATCH 4/6] PCI: qcom: Add SM8150 SoC support Bhupesh Sharma
2022-02-23 21:51   ` Dmitry Baryshkov
2022-02-23 19:29 ` [PATCH 5/6] arm64: dts: qcom: sm8150: Add pcie nodes for SM8150 Bhupesh Sharma
2022-02-23 19:29 ` [PATCH 6/6] arm64: dts: qcom: sa8155: Enable pcie nodes Bhupesh Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH=2Ntx0zKV7SNtuh6ATVp2qA1LKaks8KSMQoU2qtM=EmB52pQ@mail.gmail.com' \
    --to=bhupesh.sharma@linaro.org \
    --cc=agross@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bhupesh.linux@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=svarbanov@mm-sol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).