From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA0BC432C0 for ; Wed, 27 Nov 2019 10:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9D8D2070B for ; Wed, 27 Nov 2019 10:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574852379; bh=MCpEOE5vXkp/TLtWfq/5Qoio1Rf8C0b6msp7BvaJnCw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ajNEqI3DVsa0SCt7cp7wFnXn9mpIbTjYbQz+jSa9GS3d6EqqAdLjpS7/uEpOg1jjy ApIHE8CUqrLVkvqZmr02u0KBdHXiaR0qUMRUk1gy4rXN9wk2pWxKWXEgsxsPtJUTA9 6vaHAqI3YU2uNWlDQ8/yNrnOEGJrD7GlKW6hRxkI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726673AbfK0K7j (ORCPT ); Wed, 27 Nov 2019 05:59:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:33638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfK0K7j (ORCPT ); Wed, 27 Nov 2019 05:59:39 -0500 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 648862071E for ; Wed, 27 Nov 2019 10:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574852378; bh=MCpEOE5vXkp/TLtWfq/5Qoio1Rf8C0b6msp7BvaJnCw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sitl8TCjgEMU+PW0gRQBGFqnl1wr5qAURH2zuVSPssYVBxEr0mYz83XBunhWtc0gA GYy2jci5Wy6nWetFKQaCV7Y+7DnApNEJK1C73tWX07HWh9Pv1uaGwrl9pC5eGjeOwS YXiuYGd8jbL8Dk6QKU+IIwO6Fmu6dUVXpp34scnc= Received: by mail-qk1-f173.google.com with SMTP id m16so19031538qki.11 for ; Wed, 27 Nov 2019 02:59:38 -0800 (PST) X-Gm-Message-State: APjAAAUDaA8GpsFXGCVIlHOi4Dao2CjMIc+6Tw3J3h0hoNRlQR5j8glM 7T/deJPKUnDoFslyiEkvUNY3EjH86s0u6tk1xAM= X-Google-Smtp-Source: APXvYqwTN9F0eFceWFgZarzm5oysR9AAku3lU/GSNSvf682xFJhgeujv+L5Fas9b6peKSRsiGE4+Hie8jf/usIrOSbE= X-Received: by 2002:a05:620a:1327:: with SMTP id p7mr3630409qkj.148.1574852377544; Wed, 27 Nov 2019 02:59:37 -0800 (PST) MIME-Version: 1.0 References: <20191115135842.119621-1-wei.liu@kernel.org> <20191126230524.GA197236@google.com> In-Reply-To: <20191126230524.GA197236@google.com> From: Wei Liu Date: Wed, 27 Nov 2019 10:59:26 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: build Broadcom PAXC quirks unconditionally To: Bjorn Helgaas Cc: Wei Liu , linux-pci@vger.kernel.org, rjui@broadcom.com Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, 26 Nov 2019 at 23:05, Bjorn Helgaas wrote: > > On Fri, Nov 15, 2019 at 01:58:42PM +0000, Wei Liu wrote: > > CONFIG_PCIE_IPROC_PLATFORM only gets defined when the driver is built > > in. Removing the ifdef will allow us to build the driver as a module. > > > > Signed-off-by: Wei Liu > > Sorry, I missed this thinking it would be under drivers/pci/controller > and hence handled by Lorenzo. > > So I guess this doesn't fix a build problem, but without this patch, > we just don't run the quirk if the driver is a module, right? > Yes, this is correct. Without this patch, the quirk doesn't get to run if the driver is a module. Wei.