From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FCC1C432C3 for ; Mon, 25 Nov 2019 14:55:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 319832084D for ; Mon, 25 Nov 2019 14:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574693753; bh=Rxky72PqstIbIlKI/tQIOcS9CSX6zD0sQOuqRSkAbfk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=wpilkIQtkMYWmlzsHLIVRhq6GTFWS2rAbsHednEJfDA4GUaE6h9HZNpUwNYVXUVo7 njQ3U+khOCpFi+ns2QOw0rMSU6vPuO+5NwaqXpIs03MCAsgYP4Wy8N8IwSqWzVzokY SlZNQj7f+zbR50G8xarqnpFipO9OTJR/5fKuRiGE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728275AbfKYOzw (ORCPT ); Mon, 25 Nov 2019 09:55:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:33056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728071AbfKYOzw (ORCPT ); Mon, 25 Nov 2019 09:55:52 -0500 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CDEBF2084D for ; Mon, 25 Nov 2019 14:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574693751; bh=Rxky72PqstIbIlKI/tQIOcS9CSX6zD0sQOuqRSkAbfk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jkdf/7MjXmux3932g1T35YDJErfO4O/Hd6dOGdf0AW6G2GwaQZErpt7JiTohVjca9 iXmejzu+/wYpKw+xwMrql6BcWA0vzVnN9yyEV22UOfJUxIMJc9HmPIQm7CUbBFnvHA p8DAQp1geBRyaNtwL/83HTRKzznZ7owuQoFSV1Fs= Received: by mail-qk1-f180.google.com with SMTP id m16so12905490qki.11 for ; Mon, 25 Nov 2019 06:55:51 -0800 (PST) X-Gm-Message-State: APjAAAWlHsO4TqfKwPf5q2bTnxVD6fczHFtZL5lhTFczk4XWWwbaEFUx Q7eZnpRuU/oWh+1GIuyEm1SWAyiXyLikJvDcuV4= X-Google-Smtp-Source: APXvYqyqpZ/vCxtErRlNJFtu7hfc+t7+vo0/X9gR4FrRc0kI9p7P6lPw70p3sR7aJWPnFo2VSF7IHPauCrzFbIc+0EM= X-Received: by 2002:a05:620a:120e:: with SMTP id u14mr1392078qkj.325.1574693750891; Mon, 25 Nov 2019 06:55:50 -0800 (PST) MIME-Version: 1.0 References: <20191115135842.119621-1-wei.liu@kernel.org> In-Reply-To: <20191115135842.119621-1-wei.liu@kernel.org> From: Wei Liu Date: Mon, 25 Nov 2019 14:55:39 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: build Broadcom PAXC quirks unconditionally To: Wei Liu Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , rjui@broadcom.com Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 15 Nov 2019 at 13:58, Wei Liu wrote: > > CONFIG_PCIE_IPROC_PLATFORM only gets defined when the driver is built > in. Removing the ifdef will allow us to build the driver as a module. > > Signed-off-by: Wei Liu > --- > Alternatively, we can change the condition to: > > #ifdef CONFIG_PCIE_IPROC_PLATFORM || CONFIG_PCIE_IPROC_PLATFORM_MODULE > . > > I chose to remove the ifdef because that's what other quirks looked like > in this file. Bjorn and Ray, any comment on this trivial patch? Wei.