From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F9DC432C0 for ; Tue, 3 Dec 2019 14:46:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB90B2064B for ; Tue, 3 Dec 2019 14:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575384393; bh=1tc5gXPWwVgPzYdPrdTiVNPjY98/vv22P0ubwxUh7lw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=eblXDoJPvqVdq3QY6Kk6k68uqsc6xFMcYoPTSvB/R71fn8mXeVqjqpUDOETL/9Kx5 1cRd58yrEZpVp1d8DcZ9pfjEDM0lYyiZ4TNMNW+BrZfvvlqYZ8Lx2YibZjti5bg09Z CoNqEBr3tWsm4i3sgerO1sOX30aWuRjq9hp+XPvM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726075AbfLCOqc (ORCPT ); Tue, 3 Dec 2019 09:46:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:57692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbfLCOqc (ORCPT ); Tue, 3 Dec 2019 09:46:32 -0500 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 875DF2064B for ; Tue, 3 Dec 2019 14:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575384391; bh=1tc5gXPWwVgPzYdPrdTiVNPjY98/vv22P0ubwxUh7lw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OsIX9EAYhlumlE8w0MrA4ASb7IExxOlzCQo8s6pOZuHt9lbyHT6hbit4nalof+WZz zU4PENi677i0iW4TuC0qrxKVBTq5R28D4bft9MEZaXU3BhP9ShKJKG7HhB8EsWUZVU SOwXIRj5m6aQmgrZjsNmRKgwlSgwpTc+xti6aZ/A= Received: by mail-qv1-f52.google.com with SMTP id b18so1602626qvy.3 for ; Tue, 03 Dec 2019 06:46:31 -0800 (PST) X-Gm-Message-State: APjAAAUQXlGnmF2vU2QATC8beInItY9sdLOSHEU7rKoZH6OMIOnAyJDY c12phiqhdVXLqkHVroMjOKpxYwk7EUHKfA2TL/A= X-Google-Smtp-Source: APXvYqwIMlXI6ZCNSCwzRodkJ+nn2SARfHVqfH3NXZPHUTY0u7FOTIJX9WAq/1/NTt6NZjL412Y4Af1pTnQnLOSJW8Q= X-Received: by 2002:a0c:e503:: with SMTP id l3mr5433952qvm.92.1575384387693; Tue, 03 Dec 2019 06:46:27 -0800 (PST) MIME-Version: 1.0 References: <20191203144226.GA255690@google.com> In-Reply-To: <20191203144226.GA255690@google.com> From: Wei Liu Date: Tue, 3 Dec 2019 14:46:16 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: build Broadcom PAXC quirks unconditionally To: Bjorn Helgaas Cc: Wei Liu , linux-pci@vger.kernel.org, rjui@broadcom.com Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, 3 Dec 2019 at 14:42, Bjorn Helgaas wrote: > > On Tue, Dec 03, 2019 at 02:06:57PM +0000, Wei Liu wrote: > > On Wed, 27 Nov 2019 at 10:59, Wei Liu wrote: > > > > > > On Tue, 26 Nov 2019 at 23:05, Bjorn Helgaas wrote: > > > > > > > > On Fri, Nov 15, 2019 at 01:58:42PM +0000, Wei Liu wrote: > > > > > CONFIG_PCIE_IPROC_PLATFORM only gets defined when the driver is built > > > > > in. Removing the ifdef will allow us to build the driver as a module. > > > > > > > > > > Signed-off-by: Wei Liu > > > > > > > > Sorry, I missed this thinking it would be under drivers/pci/controller > > > > and hence handled by Lorenzo. > > > > > > > > So I guess this doesn't fix a build problem, but without this patch, > > > > we just don't run the quirk if the driver is a module, right? > > > > > > Yes, this is correct. > > > > > > Without this patch, the quirk doesn't get to run if the driver is a module. > > > > Are you satisfied with the patch? What do I need to do to get it merged? > > You needn't do anything. I'll clarify the changelog (the patch > doesn't actually *enable* building the driver as a module; it merely > ensures that we include the quirk in that case). > > This is too late for v5.5, so it will get merged for v5.6 unless the > modular driver itself was enabled for v5.5. > OK. Thanks for the clarification. Wei. > Bjorn