From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Paul Menzel <pmenzel@molgen.mpg.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: `pci_apply_final_quirks()` taking half a second
Date: Wed, 3 May 2017 21:42:06 +0300 [thread overview]
Message-ID: <CAHp75VcZs++L0svPq5W7gz0sH3RZvF=wMoFcjEUn8puF+mvQ-Q@mail.gmail.com> (raw)
In-Reply-To: <20170408190628.GB16832@bhelgaas-glaptop.roam.corp.google.com>
On Sat, Apr 8, 2017 at 10:06 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote:
>> ...
>> I note it's also reading PCI_CACHE_LINE_SIZE From config space for each
>> device in pci_apply_final_quirks(). How long does that take?
>
> I don't know, but it's pointless on modern PCIe systems where the
> Cache Line Size has no effect. It'd be really nice if somebody
> cleaned that up and got rid of the read itself and the useless
> messages.
What I can think of is 10ms delay for PM. The laptop might be one of
Intel BayTrails where we have it.
But it's just a guess.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-05-03 18:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 21:07 `pci_apply_final_quirks()` taking half a second Paul Menzel
2017-04-08 15:41 ` Bjorn Helgaas
2017-04-08 17:00 ` David Woodhouse
2017-04-08 19:06 ` Bjorn Helgaas
2017-05-03 18:42 ` Andy Shevchenko [this message]
2017-12-26 15:55 ` Paul Menzel
2017-12-28 21:27 ` Bjorn Helgaas
2017-12-29 16:14 ` Alan Stern
2017-12-31 7:18 ` Paul Menzel
2017-12-31 21:16 ` Alan Stern
2018-01-01 10:21 ` Paul Menzel
2018-01-01 15:47 ` Alan Stern
2018-06-24 16:49 ` `quirk_usb_handoff_ohci` takes over 73 ms (twice) on AMD system (was: `pci_apply_final_quirks()` taking half a second) Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcZs++L0svPq5W7gz0sH3RZvF=wMoFcjEUn8puF+mvQ-Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=dwmw2@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).