From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V3 3/3] platform/x86: Intel PMT Telemetry capability driver
Date: Tue, 14 Jul 2020 11:51:20 +0300 [thread overview]
Message-ID: <CAHp75VeueLvou3SEtR=EcTi0x+0qpLz7_cvE2KBXHXa_crS8cA@mail.gmail.com> (raw)
In-Reply-To: <20200714062323.19990-4-david.e.box@linux.intel.com>
On Tue, Jul 14, 2020 at 9:22 AM David E. Box
<david.e.box@linux.intel.com> wrote:
>
> PMT Telemetry is a capability of the Intel Platform Monitoring Technology.
> The Telemetry capability provides access to device telemetry metrics that
> provide hardware performance data to users from continuous, memory mapped,
> read-only register spaces.
>
> Register mappings are not provided by the driver. Instead, a GUID is read
> from a header for each endpoint. The GUID identifies the device and is to
> be used with an XML, provided by the vendor, to discover the available set
> of metrics and their register mapping. This allows firmware updates to
> modify the register space without needing to update the driver every time
> with new mappings. Firmware writes a new GUID in this case to specify the
> new mapping. Software tools with access to the associated XML file can
> then interpret the changes.
>
> This module manages access to all PMT Telemetry endpoints on a system,
> independent of the device exporting them. It creates a pmt_telemetry class
> to manage the devices. For each telemetry endpoint, sysfs files provide
> GUID and size information as well as a pointer to the parent device the
> telemetry came from. Software may discover the association between
> endpoints and devices by iterating through the list in sysfs, or by looking
> for the existence of the class folder under the device of interest. A
> device node of the same name allows software to then map the telemetry
> space for direct access.
>
> This patch also creates an pci device id list for early telemetry hardware
> that requires workarounds for known issues.
Some more style issues, after addressing feel free to add
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Since you are submitting this the order of the above SoB chain is a
bit strange. I think something like
SoB: Alexander
Co-developed-by: Alexander
SoB: David
is expected (same for patch 2).
...
> +Contact: David Box <david.e.box@linux.intel.com>
> +Description:
> + The telem<x> directory contains files describing an instance of
> + a PMT telemetry device that exposes hardware telemetry. Each
> + telem<x> directory has an associated /dev/telem<x> node. This
> + node may be opened and mapped to access the telemetry space of
> + the device. The register layout of the telemetry space is
> + determined from an XML file that matches the pci device id and
PCI
> + guid for the device.
GUID
Same for all code where it appears.
...
> + psize = (PFN_UP(entry->base_addr + entry->header.size) - pfn) *
> + PAGE_SIZE;
I wouldn't mind having this on one line.
...
> +static ssize_t guid_show(struct device *dev, struct device_attribute *attr,
> + char *buf)
Ditto.
...
> +static ssize_t offset_show(struct device *dev, struct device_attribute *attr,
> + char *buf)
Ditto.
...
> +static bool pmt_telem_is_early_client_hw(struct device *dev)
> +{
> + struct pci_dev *parent;
> +
> + parent = to_pci_dev(dev->parent);
Can be one line.
> + return !!pci_match_id(pmt_telem_early_client_pci_ids, parent);
> +}
...
> + entry->header_res = platform_get_resource(pdev, IORESOURCE_MEM,
> + i);
One line, please.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-14 8:51 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200505013206.11223-1-david.e.box@linux.intel.com>
2020-05-05 1:32 ` [PATCH 1/3] pci: Add Designated Vendor Specific Capability David E. Box
2020-05-05 8:49 ` Andy Shevchenko
2020-05-05 15:00 ` David E. Box
2020-05-05 16:34 ` Bjorn Helgaas
2020-05-05 2:31 ` [PATCH 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-05-05 2:31 ` [PATCH 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-05-05 13:49 ` Andy Shevchenko
2020-05-05 21:09 ` David E. Box
2020-05-08 2:33 ` David E. Box
2020-05-05 2:53 ` [PATCH 2/3] mfd: Intel Platform Monitoring Technology support Randy Dunlap
2020-05-05 14:55 ` David E. Box
2020-05-05 9:02 ` Andy Shevchenko
2020-05-05 15:15 ` David E. Box
2020-05-08 2:18 ` [PATCH v2 0/3] Intel Platform Monitoring Technology David E. Box
2020-05-08 9:59 ` Andy Shevchenko
2020-07-14 6:23 ` [PATCH V3 " David E. Box
2020-07-17 19:06 ` [PATCH V4 " David E. Box
2020-07-27 10:23 ` Andy Shevchenko
2020-07-27 16:29 ` David E. Box
2020-07-29 21:37 ` [PATCH V5 " David E. Box
2020-08-10 14:15 ` David E. Box
2020-08-10 14:42 ` Umesh A
2020-08-11 8:04 ` Lee Jones
2020-08-11 14:50 ` David E. Box
2020-07-29 21:37 ` [PATCH V5 1/3] PCI: Add defines for Designated Vendor-Specific Extended Capability David E. Box
2020-07-29 21:37 ` [PATCH V5 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-29 21:37 ` [PATCH V5 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-17 19:06 ` [PATCH V4 1/3] PCI: Add defines for Designated Vendor-Specific Extended Capability David E. Box
2020-07-17 20:11 ` Andy Shevchenko
2020-07-17 19:06 ` [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-28 7:58 ` Lee Jones
2020-07-28 20:35 ` David E. Box
2020-07-29 22:59 ` Mark D Rustad
2020-07-30 17:53 ` David E. Box
2020-07-31 6:19 ` Lee Jones
2020-07-17 19:06 ` [PATCH V4 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-14 6:23 ` [PATCH V3 1/3] PCI: Add defines for Designated Vendor-Specific Capability David E. Box
2020-07-14 8:40 ` Andy Shevchenko
2020-07-16 2:55 ` Randy Dunlap
2020-07-16 15:07 ` Bjorn Helgaas
2020-07-16 15:07 ` Randy Dunlap
2020-07-16 17:18 ` Alexander Duyck
2020-07-16 18:31 ` David E. Box
2020-07-14 6:23 ` [PATCH V3 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-14 6:23 ` [PATCH V3 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-14 8:51 ` Andy Shevchenko [this message]
2020-07-15 7:39 ` Alexey Budankov
2020-07-15 23:59 ` David E. Box
2020-07-16 5:57 ` Alexey Budankov
2020-07-16 2:57 ` Randy Dunlap
2020-05-08 2:18 ` [PATCH v2 1/3] PCI: Add defines for Designated Vendor-Specific Capability David E. Box
2020-05-08 2:18 ` [PATCH v2 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-05-08 9:15 ` Andy Shevchenko
2020-05-08 2:18 ` [PATCH v2 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-05-08 9:57 ` Andy Shevchenko
2020-05-09 16:27 ` David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeueLvou3SEtR=EcTi0x+0qpLz7_cvE2KBXHXa_crS8cA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=andy@infradead.org \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).