From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 433EBCA9ECF for ; Mon, 4 Nov 2019 10:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F9BE21E6F for ; Mon, 4 Nov 2019 10:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572863358; bh=Ip+fTs+MxXZ5PyybE5alIpEci4Feha8x1S5OQp3j/48=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=PjjwTRIItXso8TcnV4gScIcwO0lfmdBGnXWtgTH007sdUv7frio8gEBDsK3KX/2Ab nX9VEANSYxdQCx1MlRsA63vejn+mek8tljGnog8Rf59dowr7chfIziHbnL+Cb1SIWg IlMsBox4n4hw8Pu4lzRHDRAn4ZYLAsj4WQy2NlD4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728321AbfKDK3R (ORCPT ); Mon, 4 Nov 2019 05:29:17 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:40149 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbfKDK3R (ORCPT ); Mon, 4 Nov 2019 05:29:17 -0500 Received: by mail-oi1-f194.google.com with SMTP id r27so13610195oij.7; Mon, 04 Nov 2019 02:29:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SMaIK5rI7m/XaGA7nbAfirt41zqNOSaQ5u4JanEnkug=; b=BYetKR2HRiOchQmzTF7hw1EeVCQSvJaafGLuWrzhQjiRXSyU5E8ZTEfOHJSpSzrgVa WHv3i4hEPNa7TN2Bt0HHBc1SYCaSbsu8yfmg3paUGLGNPBtn39QHDiA448eHK7Z6VJEM dDdUT82I5itLJJC4J1qnzyWD6OGAuviyRjnBiiJ5MXboWORNYkFQc02cW7qvbTjk97jR zhBAwhHH4tvfLh6KholtORK7KDI8cK4Z2riRB5cbaGTaO1evhz3FgelExIoHG1adAYnq SQNFxr0DYJSW25NvuWztfXc0jtoU/+ArVmXTlxHixKKL6bliQVX6fEOm5bHq6NSbtaT+ azvw== X-Gm-Message-State: APjAAAXUKoQMynYHi1mxBVzxxbZhDmmZMwjWLd8uG0eFVUy8168lNe+j STcZl8iPGeh4YkcHzgW0WsqjCyiVwBYV9wBotfm90Q== X-Google-Smtp-Source: APXvYqxQUk0WYQBzPpqoGAwgt5HqYDWNnE/GxSDuAM84IjirBT0shkbB8HKRCkoo58R/wbA9vlSePjd7Oefh6i5mh4g= X-Received: by 2002:aca:fdd8:: with SMTP id b207mr8222796oii.57.1572863354723; Mon, 04 Nov 2019 02:29:14 -0800 (PST) MIME-Version: 1.0 References: <20191101204558.210235-1-helgaas@kernel.org> <20191101204558.210235-2-helgaas@kernel.org> In-Reply-To: <20191101204558.210235-2-helgaas@kernel.org> From: "Rafael J. Wysocki" Date: Mon, 4 Nov 2019 11:29:03 +0100 Message-ID: Subject: Re: [PATCH 1/6] PCI/PM: Apply D2 delay as milliseconds, not microseconds To: Bjorn Helgaas Cc: Linux PCI , "Rafael J . Wysocki" , Linux Kernel Mailing List , Linux PM , Bjorn Helgaas Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Nov 1, 2019 at 9:46 PM Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > PCI_PM_D2_DELAY is defined as 200, which is milliseconds, but previously we > used udelay(), which only waited for 200 microseconds. Use msleep() > instead so we wait the correct amount of time. See PCIe r5.0, sec 5.9. > > Signed-off-by: Bjorn Helgaas Reviewed-by: Rafael J. Wysocki > --- > drivers/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index e7982af9a5d8..cd96874ae76d 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -886,7 +886,7 @@ static int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state) > if (state == PCI_D3hot || dev->current_state == PCI_D3hot) > pci_dev_d3_sleep(dev); > else if (state == PCI_D2 || dev->current_state == PCI_D2) > - udelay(PCI_PM_D2_DELAY); > + msleep(PCI_PM_D2_DELAY); > > pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr); > dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK); > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog >