* [PATCH v6 3/7] resource: Introduce resource_union() for overlapping resources
2020-11-03 20:45 [PATCH v6 0/7] resource: introduce union(), intersection() API Andy Shevchenko
@ 2020-11-03 20:45 ` Andy Shevchenko
2020-11-03 20:45 ` [PATCH v6 6/7] PCI/ACPI: Replace open coded variant of resource_union() Andy Shevchenko
2020-11-16 16:51 ` [PATCH v6 0/7] resource: introduce union(), intersection() API Andy Shevchenko
2 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2020-11-03 20:45 UTC (permalink / raw)
To: linux-acpi, Greg Kroah-Hartman, linux-kernel
Cc: Andy Shevchenko, Hanjun Guo, Rafael J . Wysocki, Mika Westerberg,
Kuppuswamy Sathyanarayanan, Bjorn Helgaas, linux-pci
Some already present users may utilize resource_union() helper.
Provide it for them and for wider use in the future.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Tested-by: Hanjun Guo <guohanjun@huawei.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
---
include/linux/ioport.h | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/linux/ioport.h b/include/linux/ioport.h
index df4581107536..40320eb5bc0e 100644
--- a/include/linux/ioport.h
+++ b/include/linux/ioport.h
@@ -10,9 +10,10 @@
#define _LINUX_IOPORT_H
#ifndef __ASSEMBLY__
+#include <linux/bits.h>
#include <linux/compiler.h>
+#include <linux/minmax.h>
#include <linux/types.h>
-#include <linux/bits.h>
/*
* Resources are tree-like, allowing
* nesting etc..
@@ -235,6 +236,16 @@ static inline bool resource_overlaps(struct resource *r1, struct resource *r2)
return r1->start <= r2->end && r1->end >= r2->start;
}
+static inline bool
+resource_union(struct resource *r1, struct resource *r2, struct resource *r)
+{
+ if (!resource_overlaps(r1, r2))
+ return false;
+ r->start = min(r1->start, r2->start);
+ r->end = max(r1->end, r2->end);
+ return true;
+}
+
/* Convenience shorthand with allocation */
#define request_region(start,n,name) __request_region(&ioport_resource, (start), (n), (name), 0)
#define request_muxed_region(start,n,name) __request_region(&ioport_resource, (start), (n), (name), IORESOURCE_MUXED)
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v6 6/7] PCI/ACPI: Replace open coded variant of resource_union()
2020-11-03 20:45 [PATCH v6 0/7] resource: introduce union(), intersection() API Andy Shevchenko
2020-11-03 20:45 ` [PATCH v6 3/7] resource: Introduce resource_union() for overlapping resources Andy Shevchenko
@ 2020-11-03 20:45 ` Andy Shevchenko
2020-11-16 16:51 ` [PATCH v6 0/7] resource: introduce union(), intersection() API Andy Shevchenko
2 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2020-11-03 20:45 UTC (permalink / raw)
To: linux-acpi, Greg Kroah-Hartman, linux-kernel
Cc: Andy Shevchenko, Kuppuswamy Sathyanarayanan, Hanjun Guo,
Bjorn Helgaas, linux-pci, Rafael J . Wysocki
Since we have resource_union() helper, let's utilize it here.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Tested-by: Hanjun Guo <guohanjun@huawei.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/pci_root.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index c12b5fb3e8fb..0bf072cef6cf 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -722,9 +722,7 @@ static void acpi_pci_root_validate_resources(struct device *dev,
* our resources no longer match the ACPI _CRS, but
* the kernel resource tree doesn't allow overlaps.
*/
- if (resource_overlaps(res1, res2)) {
- res2->start = min(res1->start, res2->start);
- res2->end = max(res1->end, res2->end);
+ if (resource_union(res1, res2, res2)) {
dev_info(dev, "host bridge window expanded to %pR; %pR ignored\n",
res2, res1);
free = true;
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v6 0/7] resource: introduce union(), intersection() API
2020-11-03 20:45 [PATCH v6 0/7] resource: introduce union(), intersection() API Andy Shevchenko
2020-11-03 20:45 ` [PATCH v6 3/7] resource: Introduce resource_union() for overlapping resources Andy Shevchenko
2020-11-03 20:45 ` [PATCH v6 6/7] PCI/ACPI: Replace open coded variant of resource_union() Andy Shevchenko
@ 2020-11-16 16:51 ` Andy Shevchenko
2020-11-16 16:59 ` Rafael J. Wysocki
2 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2020-11-16 16:51 UTC (permalink / raw)
To: linux-acpi, Greg Kroah-Hartman, linux-kernel
Cc: Kuppuswamy Sathyanarayanan, Bjorn Helgaas, linux-pci
On Tue, Nov 03, 2020 at 10:45:03PM +0200, Andy Shevchenko wrote:
> Some users may want to use resource library to manage their own resources,
> besides existing users that open code union() and intersection()
> implementations.
>
> Provide a generic API for wider use.
Greg, Rafael, if there is no further comments, can it be applied?
> Changelog v6:
> - added missed tags
>
> Changelog v5:
> - added test cases (Greg)
>
> Changelog v4:
> - added Rb tag (Rafael)
> - Cc'ed to LKML and Greg (Rafael)
>
> Changelog v3:
> - rebased on top of v5.10-rc1
> - dropped upstreamed dependencies
> - added Rb tag to the last patch (Mika)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v6 0/7] resource: introduce union(), intersection() API
2020-11-16 16:51 ` [PATCH v6 0/7] resource: introduce union(), intersection() API Andy Shevchenko
@ 2020-11-16 16:59 ` Rafael J. Wysocki
2020-11-17 17:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2020-11-16 16:59 UTC (permalink / raw)
To: Andy Shevchenko
Cc: ACPI Devel Maling List, Greg Kroah-Hartman,
Linux Kernel Mailing List, Kuppuswamy Sathyanarayanan,
Bjorn Helgaas, Linux PCI
On Mon, Nov 16, 2020 at 5:51 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Nov 03, 2020 at 10:45:03PM +0200, Andy Shevchenko wrote:
> > Some users may want to use resource library to manage their own resources,
> > besides existing users that open code union() and intersection()
> > implementations.
> >
> > Provide a generic API for wider use.
>
> Greg, Rafael, if there is no further comments, can it be applied?
I don't have any. so I can take this series if there are no concerns from Greg.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v6 0/7] resource: introduce union(), intersection() API
2020-11-16 16:59 ` Rafael J. Wysocki
@ 2020-11-17 17:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2020-11-17 17:08 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Andy Shevchenko, ACPI Devel Maling List, Greg Kroah-Hartman,
Linux Kernel Mailing List, Kuppuswamy Sathyanarayanan,
Bjorn Helgaas, Linux PCI
On Mon, Nov 16, 2020 at 5:59 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Mon, Nov 16, 2020 at 5:51 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Tue, Nov 03, 2020 at 10:45:03PM +0200, Andy Shevchenko wrote:
> > > Some users may want to use resource library to manage their own resources,
> > > besides existing users that open code union() and intersection()
> > > implementations.
> > >
> > > Provide a generic API for wider use.
> >
> > Greg, Rafael, if there is no further comments, can it be applied?
>
> I don't have any. so I can take this series if there are no concerns from Greg.
No concerns mentioned, so applied as 5.11 material, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread